_ColorConvertRGBtoHSL does not use right bases

[Nine]

The formulas are good but the base to finalize the results is wrong. H is a degree so base should be 360, S and L are percentages, so base should be 100. But in the current UDF (color.au3) the base used is 240 !

[Melba23]

Looking into it, but at first glance it seems you are correct.

M23

[Melba23]

A fairly simple fix.

We need to replace this single constant:

Global Const $__COLORCONSTANTS_HSLMAX = 240

with these 2:

Global Const $__COLORCONSTANTS_HMAX = 360
Global Const $__COLORCONSTANTS_SLMAX = 100

and adjust the formulae in the 2 conversion functions to match:

; _ColorConvertHSLtoRGB
Local $nR, $nG, $nB
Local $nH = Number($aArray[0]) / $__COLORCONSTANTS_HMAX
Local $nS = Number($aArray[1]) / $__COLORCONSTANTS_SLMAX
Local $nL = Number($aArray[2]) / $__COLORCONSTANTS_SLMAX
.
.
.
; _ColorConvertRGBtoHSL
$aArray[0] = $nH * $__COLORCONSTANTS_HMAX
$aArray[1] = $nS * $__COLORCONSTANTS_SLMAX
$aArray[2] = $nL * $__COLORCONSTANTS_SLMAX

That gives me the correct values according to colour conversion websites.

M23

[Melba23]

Fixed by revision [12186] in version: 3.3.15.1