Incorrect return values for up to 4 UDFs

[MHz]

I have done a quick review of usage of SetError and SetExtended in the current Beta include files. I did this to check if the default return value of 1 of SetError and SetExtended is used. Most are good with using all parameters to override the default return value of 1.

I found some issues that may need attention

SetError Use

Note: The following UDF starts with double underscore. It is removed as the tracker software is changing it.

SQLite_ReportError lines 972 and 981 of SQLite.au3
Return not set or used anywhere. It is a internal function so set explicit return value to 0 is my advise.

_StringEncrypt() lines 59 and 61 of String.au3
Sets all 3 values without using the keyword Return which is ill use. It would return 0 on failure instead of the documented blank string.

_WinAPI_SetLastError() line 31 of WinAPIError.au3
Only 2 values for SetError. Perhaps set 3 parameters and use 1 as return value. Actually nothing is checked to qualify the default return value of 1 so 0 seems suitable. Document states return value is none so it seems to be a code bug. MSDN for SetLastError states "This function does not return a value"

SetExtended Use

_VersionCompare() line 449 of Misc.au3
SetExtended is reset by the following inbuilt function call before returning from the UDF when number comparison is used.

[guinness]

Which beta version are you using please?

[MHz]

Beta Version 3.3.9.13

[guinness]

I have moved the discussion to the help issues thread for clarification, as lines numbers aren't matching up either.

[guinness]

Fixed by revision [8312] in version: 3.3.9.14