Crash with _GUICtrlListBox_InsertString()

[Valik]

The following code crashes Autoit (taken from #2147):

#include <GUIListBox.au3>

GUICreate("Test", 200, 320)
Local $list=GUICtrlCreateList("", 5, 2, 190, 280)
Local $button=GUICtrlCreateButton("Do It!", 40, 290, 120, 25)
GUISetState()

Global $msg
While 1
	$msg = GUIGetMsg()
	If $msg = -3 Then
		Exit
	ElseIf $msg = $button Then
		_GUICtrlListBox_InsertString($list, 1)	; Crash
	EndIf
WEnd

Changing the marked line to _GUICtrlListBox_InsertString($list, String(1)) fixes the crash.

[BrewManNH <bobmarotte@…>]

I noticed that if you use the code below it works without crashing too.

_GUICtrlListBox_InsertString(GUICtrlGetHandle($list), 1)

[Valik]

Right. The crash is actually with GUICtrlSendMsg(). I imagine it looks at the type of the variant to determine what to pass to SendMessage(). Since in this example it is passing a number it gives SendMessage() a number but then the message handler tries to treat that number as a pointer to a string and boom, AutoIt crashes. I'm not sure that we can prevent the crash with GUICtrlSendMsg(). I think the best we can get here is a forced String() cast and a review of all code that uses GUICtrlSendMsg() to ensure it properly casts input to the correct type to prevent other crashes.

[guinness]

Fixed by revision [7223] in version: 3.3.9.5