Date.au3: calls to _Date_Time_SetLocalTime($pSystemTime) are not checking @error

[gtyler]

In Date.au3, there are several function that call _Date_Time_SetLocalTime() and do not check for @error.
They expect the function to always return an array and then try to reference index 0 which generates an exception.

Here is the last two lines of _SetDate()

Local $iRetval = _Date_Time_SetLocalTime($lpSystemTime)
Return SetError(@error, @extended, Int($iRetval[0]))

[Valik]

Fixed by revision [5440] in version: 3.3.1.7

[gtyler]

There are still two pieces of code in Date.au3 that concern me:

Local $aResult = DllCall("kernel32.dll", "dword", "GetTimeZoneInformation", "ptr", DllStructGetPtr($tTimeZone))
If @error Or $aResult[0] = -1 Then Return SetError(@error, @extended, 0)

Local $aResult = DllCall("kernel32.dll", "bool", "SetLocalTime", "ptr", $pSystemTime)
If @error Or Not $aResult Then Return SetError(@error, @extended, False)

If @error is 0 but the second condition is met for each of those OR statements, then 0 will be returned in @error and the calling function may still try to access the array since it will only check for @error.
I think it should explicity set @error or all the calling programs need to use isArray() to make sure an array has been returned.