Modify

#2305 closed Bug (Fixed)

_ScreenCapture_Capture() - Width & Heigth wrong

Reported by: KaFu Owned by: guinness
Milestone: 3.3.9.5 Component: Standard UDFs
Version: 3.3.8.1 Severity: None
Keywords: Cc:

Description

Local $iW = ($iRight - $iLeft) + 1
Local $iH = ($iBottom - $iTop) + 1

should be

Local $iW = ($iRight - $iLeft)
Local $iH = ($iBottom - $iTop)

I don't see the necessity for the +1, makes all my captures 1px too large.

Attachments (0)

Change History (5)

comment:1 by guinness, on Jan 17, 2013 at 3:55:49 PM

This change was introduced in Revision: 5671 because of this ticket #1446

Last edited on Jan 17, 2013 at 4:00:51 PM by guinness (previous) (diff)

comment:2 by anonymous, on Jan 17, 2013 at 4:07:06 PM

Well, a really philosophical question... Capturing the full screen starts at 0,0 and thus the +1 results in a pic of 801x601 on a 800x600 screen.

comment:3 by anonymous, on Jan 17, 2013 at 4:23:50 PM

So maybe leave the +1 untouched and replace

If $iRight = -1 Then $iRight = _WinAPI_GetSystemMetrics($SCREENCAPTURECONSTANT_SM_CXSCREEN)
If $iBottom = -1 Then $iBottom = _WinAPI_GetSystemMetrics($
SCREENCAPTURECONSTANT_SM_CYSCREEN)

with

If $iRight = -1 Then $iRight = _WinAPI_GetSystemMetrics($SCREENCAPTURECONSTANT_SM_CXSCREEN) - 1 ; -1 to correct 0,0 initial screen-pos
If $iBottom = -1 Then $iBottom = _WinAPI_GetSystemMetrics($
SCREENCAPTURECONSTANT_SM_CYSCREEN) - 1 ; -1 to correct 0,0 initial screen-pos

?

comment:5 by guinness, on Mar 27, 2013 at 9:20:58 AM

Milestone: 3.3.9.5
Owner: set to guinness
Resolution: Fixed
Status: newclosed

Fixed by revision [7693] in version: 3.3.9.5

Modify Ticket

Action
as closed The owner will remain guinness.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.