Add Files to treeview

Jewtus · June 26, 2016

I have some code that I found somewhere on the web sometime back and I modded to meet my purpose, but I'm revisiting it because now I also want the file structure. This is my code:

Func FileBrowser()
    $gui = GUICreate("File Browser", 756, 272, -1, -1)
    global $iTree = GUICtrlCreateTreeView(0, 0, 361, 233)
    $cButton = GUICtrlCreateButton("Save", 672, 240, 75, 25)
    $cAddSelected = GUICtrlCreateButton(">", 368, 40, 35, 25)
    $cRemoveSelected = GUICtrlCreateButton("<", 368, 72, 35, 25)
    $cRemoveAll = GUICtrlCreateButton("<<", 368, 104, 35, 25)
    $cPathList = GUICtrlCreateListView("", 408, 0, 345, 233,0x0003)
    _GUICtrlListView_AddColumn($cPathList,"Folder",340)
    $hImage = _GUIImageList_Create(16, 16, 5, 2)
    _GUIImageList_AddIcon($hImage, @SystemDir & "\shell32.dll", 4)
    _GUIImageList_AddIcon($hImage, @SystemDir & "\shell32.dll", 54)
    _GUICtrlTreeView_SetNormalImageList($iTree, $hImage)
    GUIRegisterMsg($WM_NOTIFY, "WM_NOTIFY")
    $aDrives=DriveGetDrive("Fixed")
    For $x=1 to UBound($aDrives)-1
        _GUICtrlTreeView_AddChild($iTree,"",StringUpper($aDrives[$x]),0)
    Next
    GUISetState(@SW_SHOW)

    While 1
        $nMsg = GUIGetMsg()
        Switch $nMsg
            Case $GUI_EVENT_CLOSE
                Exit
            Case $cRemoveSelected
                _GUICtrlListView_DeleteItemsSelected($cPathList)
            Case $cRemoveAll
                _GUICtrlListView_DeleteAllItems($cPathList)
            Case $cAddSelected
                $sPath=GetSelectedPath($iTree)
                _GUICtrlListView_AddItem($cPathList,$sPath)
            Case $cButton
                MsgBox(0,"","WORKING ON IT")
        EndSwitch
    WEnd
EndFunc

Func GetSelectedPath($iTree)
    $hWndTreeView = GUICtrlGetHandle($iTree)
    $item=_GUICtrlTreeView_GetSelection($hWndTreeView)
    $txt = _GUICtrlTreeView_GetText($hWndTreeView,$item)
    Do
        $parent = _GUICtrlTreeView_GetParentHandle($hWndTreeView,$item)
        If $parent <> 0 Then
            $txt = _GUICtrlTreeView_GetText($hWndTreeView,$parent) & "\" & $txt
            $item = $parent
        EndIf
    Until $parent = 0
    Return $txt
EndFunc

Func _SearchFolder($folder,$parent,$level=0)
    If $level >= 1 Then Return
    $folders = _FileListToArray($folder,"*",2)
    _FolderFunc($folders,$folder,$parent,$level)
EndFunc

Func _FolderFunc($folders,$folder,$parent,$level)
    For $i = 1 To UBound($folders)-1
        $parentitem = _GUICtrlTreeView_AddChild($iTree,$parent,$folders[$i],0)
        _SearchFolder($folder & "\" & $folders[$i],$parentitem,$level+1)
    Next
EndFunc

Func WM_NOTIFY($hWnd, $iMsg, $iwParam, $ilParam)
    Local $hWndFrom, $iIDFrom, $iCode, $tNMHDR
    $hWndTreeView = GUICtrlGetHandle($iTree)
    $tNMHDR = DllStructCreate($tagNMHDR, $ilParam)
    $hWndFrom = HWnd(DllStructGetData($tNMHDR, "hWndFrom"))
    $iIDFrom = DllStructGetData($tNMHDR, "IDFrom")
    $iCode = DllStructGetData($tNMHDR, "Code")
    Switch $hWndFrom
        Case $hWndTreeView
            Switch $iCode
                Case -451
                    $item = _GUICtrlTreeView_GetSelection($hWndTreeView)
                    $root = $item
                    If _GUICtrlTreeView_GetChildCount($hWndTreeView,$item) <= 0 Then
                        $txt = _GUICtrlTreeView_GetText($hWndTreeView,$item)
                        Do
                            $parent = _GUICtrlTreeView_GetParentHandle($hWndTreeView,$item)
                            If $parent <> 0 Then
                                $txt = _GUICtrlTreeView_GetText($hWndTreeView,$parent) & "\" & $txt
                                $item = $parent
                            EndIf
                        Until $parent = 0
                        _SearchFolder($txt,$root)
                    EndIf
            EndSwitch
    EndSwitch
    Return $GUI_RUNDEFMSG
EndFunc

Now, the problem I'm not able to figure out is how to add the files to the treeview. I tried changing _FileListToArray($folder,"*",2) to search for all but it still doesn't add the files to the list view. I'm also assuming that I'll need to handle icon sets for this to show the right icons in the tree view right?

Am I reinventing the wheel here or has someone already built one of these as a UDF?

JLogan3o13 · June 26, 2016

@Jewtus You have been around long enough to know you get more help if you post runnable code (includes, etc.) rather than asking others to first get it working for you and then help you improve it.

And now that I have gotten it running, my response to your question would be yes, you most certainly are reinventing the wheel - it's called Windows Explorer. Just curious what you're hoping your file explorer is going to bring to the table that you can't get from either the built in Explorer, or one of the many open source explorers already out there?

Melba23 · June 26, 2016

Jewtus,

Look at my ChooseFileFolder UDF - the _CFF_Fill_Branch function fills the TreeView.

M23

Jewtus · June 27, 2016

@JLogan3o13, The reason I'm building this UI is so I can sift through my entire media library (video, audio, documents) to standardize them. I want to filter out anything that already has a confirmed conversion (been having issues with MKVs killing the stream). The reason this is important to me (and why I don't want to do it via the explorer) is because I have about 2 terabytes worth of files to fix and I don't really feel like doing them as one off. The part of the code I didn't share is where I run ffmpeg/lame with multiple threads and monitor the threads for errors. I want to continue using the UI while conversions take place (basically I want to be able to keep flagging content as I convert or just walk away for a few hours and come back to a finished up queue). And just as a note... I spent about 20 minutes on this part before asking because I didn't want to waste time... I spent that vast majority of the time with my multithreader and monitor.

@Melba23 Thank you, I'll take a look.

Jewtus · June 28, 2016

So i've been playing with Melba's example and it actually looks like EX 5 is exactly what I wanted.

I am having some issues with it though and I wanted to see if this was an issue with my version of autoit. When I look at example 5, it seems to work so I copied it to my script:

$sRet = _CFF_Choose("Select", -300, 500, -1, -1, "", Default, 0 + 4 + 8 + 16, 20)

When I ran this, it put every item under my C drive (even if it was on my other drive). I went back to the example and checked to see if there was the same issue, and it put everything under my M drive. I used the exact same line as in the example and got 2 different results. Any ideas?

Melba23 · June 28, 2016

Jewtus,

When I run that snippet I get exactly what I expect to see - all my files and folder neatly arranged under their respective drives.

Do you have a peculiar drive setup? What does DriveGetDrive("ALL") return for you?

M23

Jewtus · June 28, 2016

I get both the C and M drives (those show up) but it dumps the contents of those drives to other locations. I'm at work now, but when I get home I'll post my autoit version and system specs.. I've noticed other issues with some autoit functions on windows 10 (like splash screens and GUI background images not working) so that might be one of the issues.

Jewtus · June 29, 2016

I'm using autoit beta 3.3.13.19,

system info:

Quote

OS Name: Microsoft Windows 10 Pro
OS Version: 10.0.10586 N/A Build 10586
System Manufacturer: Dell Inc.
System Model: Studio XPS 435MT
System Type: x64-based PC
Processor(s): Intel64 Family 6 Model 26 Stepping 5 GenuineIntel ~2668 Mhz
BIOS Version: Dell Inc. 1.1.1, 5/5/2009
Total Physical Memory: 8,183 MB
Virtual Memory: Max Size: 10,099 MB

I also noticed that when I click the C drive to expand it (I'm using your example for this one) I get the contents of the M drive (screenshot).

Then when I click the M drive, the C drive's content shows up under C as well (screenshot).

Edited June 29, 2016 by Jewtus
added more details

Melba23 · June 29, 2016

Jewtus,

Not that I think that will cause a problem here, but any particular reason why you are still using an out-dated Beta release?

I will look into coding something to produce various debugging details so we can see what is happening internally when you list the files, but that may have to wait until the weekend as I am quite busy until then.

M23

Jewtus · June 29, 2016

I have no reason for using an old beta... I use the portable version and often forget to update it.

I'll update it when I get home today and see if the updated beta fixes the issue. I'll also look in to your code a bit to try to see if I can figure it out as well and I'll report back before the weekend.

spudw2k · June 29, 2016

On 6/26/2016 at 6:52 AM, Jewtus said:

I have some code that I found somewhere on the web sometime back and I modded to meet my purpose,

That looks familiar. Glad you found some use of it...but I second Melba's recommendation. His UDF is a much more mature and robust solution than crafting it your/myself. It was a fun learning exercise at best.

Melba23 · June 30, 2016

Jewtus,

I found a few moments - try running this debug version of the UDF and see if it gives the correct drive listing and then adds items to the correct parent when expanding: <snip>. If, as your earlier tests seem to indicate, it does not add to the correct parent we can work back and try to find out why.

If any other Win10 users would care to test I would be most grateful - the simple script I used is as follows:

#include "ChooseFileFolder_Debug.au3"

_CFF_RegMsg()

$sRet = _CFF_Choose("Select", -300, 500, -1, -1, "", Default, 0 + 4 + 8 + 16, 20)

ConsoleWrite("Returned: " & $sRet & @CRLF)

M23

Edited July 8, 2016 by Melba23
Removed Beta code

Jewtus · June 30, 2016

I'll try this when I get home today.

Jewtus · July 2, 2016

Ok so when I use the debug version, I first get an arraydisplay that shows all my drives without issue.

Then i clicked the C drive then the M drive (in that order) this was the console readout:
Checking for folders on path: C:\
Adding folder to: C:
Adding folder to: C:
Adding folder to: C:
Adding folder to: C:
Adding folder to: C:
Adding folder to: C:
Adding folder to: C:
Adding folder to: C:
Adding folder to: C:
Adding folder to: C:
Adding folder to: C:
Adding folder to: C:
Adding folder to: C:
Adding folder to: C:
Adding folder to: C:
Adding folder to: C:
Adding folder to: C:
Adding folder to: C:
Checking for files on path: C:\
Adding file to: C:
Adding file to: C:
Adding file to: C:
Adding file to: C:

Also, on startup the tree view has everything from my M drive in my C drive and nothing listed for m

When I double click on the M drive to add it, it does add the M drive to the Lower box.

Edited July 2, 2016 by Jewtus

Melba23 · July 2, 2016

Jewtus,

I will look at adding further debug lines to the UDF to try to find out why it does not recognise where you have clicked - wait out.

M23

Edit:

Please try this version - it will tell you which branch it thinks you are expanding when you click on a [+] : <snip>

Edit 2: Added some more debugging lines to the code. When I click on the [+] next to the M: drive I get this:

Handler Item Handle: 0x02361E78
Passed handle: 0x02361E78
Used handle: 0x02361E78
Expanding: M:
Checking for folders on path: M:\
Checking for files on path: M:\
Passed handle: 0x00000000

What do you get?

Edited July 8, 2016 by Melba23
Beta code removed

Jewtus · July 3, 2016

This is what happened when I clicked the C then the M's + button (same thing happens when I do starting with M)

Quote

Handler Item Handle: 0x00000278242CDE30
Passed handle: 0x242CDE30
Used handle: 0x00000278242CDE30
Expanding: C:
Checking for folders on path: C:\
Checking for files on path: C:\
Passed handle: 0x00000000
Handler Item Handle: 0x00000278242CED90
Passed handle: 0x242CED90
Used handle: 0x00000278242CDE30
Expanding: C:
Passed handle: 0x00000000

I think I figured out what is going on. When I hit the + button, it expands what every I have highlighted.

The weirdest part is when I start clicking around. I had something in M selected (not actually in the M drive but it was showing up there) then I the + on another folder and it lists one of the files in the M drives root:

Quote

Handler Item Handle: 0x0000026BB8922270
Checking for folders on path: M:\
Checking for files on path: M:\
Passed handle: 0xB8922270
Used handle: 0x0000026BB8922DB0
Expanding: M:\bohemian_rhapsody_muppets.mp4
Checking for folders on path: M:\bohemian_rhapsody_muppets.mp4\
Checking for files on path: M:\bohemian_rhapsody_muppets.mp4\
Passed handle: 0x00000000

Edited July 3, 2016 by Jewtus

Melba23 · July 3, 2016

Jewtus,

Quote

When I hit the + button, it expands what every I have highlighted.

That certainly is not the case on my Win7 machine. Please run this little script: select "Root 1" with a single click and then try and expand "Root 2" using the [+]:

#include <GUIConstants.au3>
#include <WindowsConstants.au3>
#include <GUITreeview.au3>

; Array to hold Item ControlIDs
Global $aRoot[3]

; Create GUI
$hGUI = GUICreate("Test", 500, 500)

$cTreeView = GUICtrlCreateTreeView(10, 10, 200, 300)
$hTreeView = GUICtrlGetHandle($cTreeView)

$aRoot[1] = GUICtrlCreateTreeViewItem("Root 1", $cTreeView)
ConsoleWrite("Root 1 handle: " & GUICtrlGetHandle($aRoot[1]) & @CRLF)
For $i = 1 To 5
    GUICtrlCreateTreeViewItem("Item 1-" & $i, $aRoot[1])
Next
$aRoot[2] = GUICtrlCreateTreeViewItem("Root 2", $cTreeView)
ConsoleWrite("Root 2 handle: " & GUICtrlGetHandle($aRoot[2]) & @CRLF)
For $i = 1 To 5
    GUICtrlCreateTreeViewItem("Item 2-" & $i, $aRoot[2])
Next

GUISetState()

GUIRegisterMsg($WM_NOTIFY, "_WM_NOTIFY")

; Loop
While 1

    $iMsg = GUIGetMsg()
    Switch $iMsg
        Case $GUI_EVENT_CLOSE
            Exit
        Case Else
            For $i = 1 To 2
                If $iMsg = $aRoot[$i] Then
                    ConsoleWrite("Root " & $i & " selected" & @CRLF)
                    ExitLoop
                EndIf
            Next
    EndSwitch

WEnd

Func _WM_NOTIFY($hWnd, $iMsg, $wParam, $lParam)

    #forceref $hWnd, $iMsg, $wParam

    ; Create NMTREEVIEW structure
    Local $tStruct = DllStructCreate("struct;hwnd hWndFrom;uint_ptr IDFrom;INT Code;endstruct;" & _
            "uint Action;struct;uint OldMask;handle OldhItem;uint OldState;uint OldStateMask;" & _
            "ptr OldText;int OldTextMax;int OldImage;int OldSelectedImage;int OldChildren;lparam OldParam;endstruct;" & _
            "struct;uint NewMask;handle NewhItem;uint NewState;uint NewStateMask;" & _
            "ptr NewText;int NewTextMax;int NewImage;int NewSelectedImage;int NewChildren;lparam NewParam;endstruct;" & _
            "struct;long PointX;long PointY;endstruct", $lParam)
    Local $hWndFrom = DllStructGetData($tStruct, "hWndFrom")
    Local $hItem = DllStructGetData($tStruct, "NewhItem")
    Local $iCode = DllStructGetData($tStruct, "Code")

    If $hWndFrom = $hTreeView Then
        ; Check action
        Switch $iCode
            Case -2 ; $NM_CLICK
                ; Fire the dummy control
                ConsoleWrite("Handler - Single click - " & $hItem & @CRLF)
            Case -3 ; $NM_DBLCLK 0xFFFFFFFD
                ; Fire the dummy control
                ConsoleWrite("Handler - Double Click - " & $hItem & @CRLF)
            Case $TVN_ITEMEXPANDEDW, $TVN_ITEMEXPANDEDA
                ConsoleWrite("Handler - Expand Item - " & $hItem & @CRLF)
            Case $TVN_SELCHANGEDA, $TVN_SELCHANGEDW
                ConsoleWrite("Handler - Selected Item - " & $hItem & @CRLF)
        EndSwitch
    EndIf

EndFunc

I get this:

Root 1 handle: 0x02336760
Root 2 handle: 0x02336958
Handler - Single click - 0x00000001
Handler - Selected Item - 0x00000000
Handler - Selected Item - 0x02336760 <<<<<<<<<<<<< Root 1 clicked
Root 1 selected
Handler - Single click - 0x00000001
Handler - Expand Item - 0x02336958   ,,,,,,,,,,,,, Root 2 expanded

What do you see?

M23

Jewtus · July 4, 2016

So I got pretty much the same thing (other then the handles)

Quote

Root 1 handle: 0x000001EB95559B30
Root 2 handle: 0x000001EB95558D50
Handler - Single click - 0x00007FF914FC97A6
Handler - Selected Item - 0x0000000000000000
Handler - Selected Item - 0x000001EB95559B30
Root 1 selected
Handler - Single click - 0x00007FF914FC97A6
Handler - Expand Item - 0x000001EB95558D50

Melba23 · July 4, 2016

Jewtus,

Well, that looks as if the Windows messages and the struct the UDF uses to identify the item to fill are working correctly - which I did not really doubt. I am now at a loss as to where to go next - I will have to have a think about it. The fact that you are the only person ever to have reported such a problem makes me incline to a problem at your end, but let us not be hasty. Do you see a similar problem in any other of the UDF example scripts?

M23

Jewtus · July 4, 2016

I've had issues with the Image UDFs on windows 10 (other people have said they have the same issue). I have both a background img and a splash icon that don't show up on the windows 10 machine (they show up on my other machines). I'm going to also load this script up on my VM and see if I experience the same issues.... My desktop is pretty customized and I run a number of services from it (one of which being a streaming service... which is why I'm building this script to begin with).

I'll also try to boot up a windows 10 VM and see if it is just my instance or my machine.

EDIT: Script seems to work without issue on my windows 7 VM.

Edited July 4, 2016 by Jewtus

Add Files to treeview

Recommended Posts

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Create an account or sign in to comment

Create an account

Sign in

Recently Browsing 0 members