[SOLVED] Two equal functions, but different result...

[johnmcloud]

I don't have idea, but i have two equal code, but give me two different result

This script work, and i have at finish the MsgBox

Func A()
$Path = GUICtrlRead($FolderInput_LvA)
$Pre = "Test.exe"
$Command = "-e -p"
$Folders= _FileListToArray($Path, '*', 1)
$Folders[0] = "@echo off" & @CRLF
  
For $i = 1 to UBound($Folders) -1
    $Success = $Folders[$i] = RunWait(@ComSpec & " /c " & $pre & " " & $command & " " & " " & '"' & $Path & "\" & $Folders[$i] & '"', @TempDir, @SW_HIDE)
Next
If GUICtrlRead($FolderCheckbox) = $GUI_CHECKED Then
Test()
EndIf
If $Success Then
MsgBox(0,"Information","Success")
FileDelete(@TempDir & "\Test.txt")
EndIf
Return 1
EndFunc

This do the @ComSpec command but i don't have the MsgBox, because the result is different ( i have try to make "If Not $Success Then" and i have the MsgBox)

I have only change the $FolderInput_LvB and the command, i have both code in the same script, but two different Func()

Func B()
$Path = GUICtrlRead($FolderInput_LvB)
$Pre = "Test.exe"
$Command = "-f -p"
$Folders= _FileListToArray($Path, '*', 1)
$Folders[0] = "@echo off" & @CRLF
  
For $i = 1 to UBound($Folders) -1
    $Success = $Folders[$i] = RunWait(@ComSpec & " /c " & $pre & " " & $command & " " & " " & '"' & $Path & "\" & $Folders[$i] & '"', @TempDir, @SW_HIDE)
Next
If GUICtrlRead($FolderCheckbox) = $GUI_CHECKED Then
Test()
EndIf
If $Success Then
MsgBox(0,"Information","Success")
FileDelete(@TempDir & "\Test.txt")
EndIf
Return 1
EndFunc

What is the problem?

Thanks

Edited December 31, 2011 by johnmcloud

[spudw2k]

upon examination it looks to me (without testing) that perhaps the -f flag is the culprit.

If you run the command in a cmd prompt do you get the results you'd expect?

Also, not too sure about the following statement

$Success = $Folders[$i] = RunWait(.....)

I've never seen a statement with an $var1 = $var2 = Func

Edited December 30, 2011 by spudw2k

[johnmcloud]

upon examination it looks to me (without testing) that perhaps the -f flag is the culprit.

If you run the command in a cmd prompt do you get the results you'd expect?

Also, not too sure about the following statement

$Success = $Folders[$i] = RunWait(.....)

I've never seen a statement with an $var1 = $var2 = Func

Mmm how strange...

I have changed to this for second script:

$Folders[$i] = RunWait(@ComSpec & " /c " & $pre & " " & $command & " " &  " " & '"' & $Path & "" & $Folders[$i] & '"', @TempDir, @SW_HIDE)
$Success = $Folders[$i]

i have the MsgBox for FuncB(), but if i try to apply THE SAME THING to FuncA() don't work, i have message for B and not for A, before i have MsgBox for A and not for B...

Edited December 30, 2011 by johnmcloud

[jaberwacky]

Check that these values are correct:

$Path  = GUICtrlRead($FolderInput_LvA)
$Path  = GUICtrlRead($FolderInput_LvB)

Is variable $Success a global? If so, do you assign any values to variable $Success within function Test()?

Edited December 30, 2011 by LaCastiglione

[johnmcloud]

I have resolved, this time without your hand guys

I have changed this part like this and work for both code:

$Success = $Folders[$i] = RunWait(@ComSpec & " /c " & $pre & " " & $command & " " & " " & '"' & $Path & "" & $Folders[$i] & '"', @TempDir, @SW_HIDE)
Next
If GUICtrlRead($FolderCheckbox) = $GUI_CHECKED Then
Test()
EndIf
If $Success = 1 Then
MsgBox(0,"Information","Success")
FileDelete(@TempDir & "Test.txt")
Else
MsgBox(16,"Error","Error")
FileDelete(@TempDir & "Test.txt")
EndIf
Return 1

Thanks anyway for support

Edited December 30, 2011 by johnmcloud

[kylomas]

johnmlcoud,

Congrats!

$Success = $Folders[$i] = RunWait(@ComSpec & " /c " & $pre & " " & $command & " " & " " & '"'...

This is kind of an unusual construct. $success seems to evaluate to true or false depending on the results of the 2nd and third parts of this construct. Is this your intent? How did you arrive at this?

kylomas

[johnmcloud]

johnmlcoud,

Congrats!

$Success = $Folders[$i] = RunWait(@ComSpec & " /c " & $pre & " " & $command & " " & " " & '"'...

This is kind of an unusual construct. $success seems to evaluate to true or false depending on the results of the 2nd and third parts of this construct. Is this your intent? How did you arrive at this?

kylomas

Thanks for congrats, but i'm only a noob respect of all guru of this forum.

Yes, was my intent, I got there at random attempts and seem work fine for my script

Work like $success is 1 if $Folders[$i]=1 if RunWait=1

If one of there is 0 the result is 0, i think

Edited December 30, 2011 by johnmcloud

[kylomas]

johnmcloud,

All the better for you! If everyone was willing to dig a bit...well that is not relevant here.

I wonder what a dev thinks of that construct????

kylomas

[jaberwacky]

Here's what I get:

Global $Success = ''
Global $Test = ''

$Success = $Test = 123

ConsoleWrite("$Success: " & $Success & @CRLF & "$Test: " & $Test & @CRLF)

$Success: False
$Test:

My guess is that $Test is not being assigned to and so it returns false which gets assigned to $Success.

Edited December 30, 2011 by LaCastiglione

[kylomas]

LaCastiglione,

Tried the same with

local $a = 10, $b = 20, $c = 30
$a = $b = $c
consolewrite($a & @lf & $b & @lf & $c & @lf)

which resulted in

false

20

30

kylomas

[Melba23]

Kylomas,

I wonder what a dev thinks of that construct????

This Mod thinks it is an abomination and it only works by pure luck.

johnmcloud,

I would strongly advise against using non-standard contructs of that sort - you will only get bitten by one not working as you expect one day. And will you be able to remember how it is supposed to work when you look again at the script in several months time?

Go for simplicity - AutoIt is slow enough that any time you save will be minimal, and large enough when compiled that you do not save much in size terms by condensing assign statements like that. Finally anything involving Booleans should be simple as possible as getting their logic right is difficult enough as it is

M23

[kylomas]

@M23,

Thanks, suspected as much...

kylomas

[kylomas]

@m23,

Interesting though that this resolves to True

Local $a = 5, $b = 6, $c = 6
$a = $b = $c
ConsoleWrite($a & @LF & $b & @LF & $c & @lf)

kylomas

edit: conjecture...ternary ops come to mind!

Edited December 30, 2011 by kylomas

[johnmcloud]

Ok guys, is only fortune

You are more expert then me, someone can show the "right" way to do that script?

I have do it that way because i can't find different solution for both code in the same script

Thanks

[BrewManNH]

It evaluates as true because $b equals $c, they're both 6.

[Melba23]

kylomas,

Ternary ops have been brought up several times in other closed parts of the forum - the last time it was sort of agreed that in a language that strives for ease of use they were an unneccesary complication. Although I did like one pro-ternary comment in particular (and it did not come from the person you might think!):

I still don't find that just because it's easier to cut your head off with a chainsaw than an axe that a chainsaw isn't a viable tool. Yes it can turn the situation ugly much faster than an axe, but that's all up to the user. You can't save people from stupid.

M23

[BrewManNH]

$a = $b = $C isn't any different than doing something like If $B = $C Then <do something>. It's evaluating whether or not $B equals $C and if it does (True), do something. The initial value of $a is overwritten by the boolean comparison result.

[kylomas]

brewmanNH,

OF course, my conjecture was only that the form was vaguely reminiscent of ternary ops..

@m23,

I still don't find that just because it's easier to cut your head off with a chainsaw than an axe that a chainsaw isn't a viable tool. Yes it can turn the situation ugly much faster than an axe, but that's all up to the user. You can't save people from stupid.

my new mantra

kylomas

[jaberwacky]

$a = $b = $C isn't any different than doing something like If $B = $C Then <do something>. It's evaluating whether or not $B equals $C and if it does (True), do something. The initial value of $a is overwritten by the boolean comparison result.

I think BrewManNH is right because:

Global $Success = ''
Global $Test = 123

$Success = $Test = 123

ConsoleWrite("$Success: " & $Success & @CRLF & "$Test: " & $Test & @CRLF)

I still think of AutoIt in terms of a low-level language.

Edited December 30, 2011 by LaCastiglione

[Dana]

Of course if you really want one line you could make it less ambiguous by using $a = ($b = $c), no?

I sometimes use redundant parentheses to make things more clear (or more ovbious).

Now this may be a stupid question, but how does AutoIt know that $a = $b = $c means "assign to $a the result of the comparision $b=$c", rather than "set $a equal to $b, and then compare to $c (since per the helpfile when two operators have the same precedence the expression is evaluated left to right.)? It looks like an equal sign that's the first operator on any line is assumed to be assignment, whereas any other use of equal is assumed to be comparison?