How to convert GUI scripts to v3.2.12.0

[Jon]

Thanks Mike.

That worked. I just assumed it should have been fine in the first place being a sample au3 script that was installed during the setup.

Damn, I thought I'd checked them all. Thanks.

[Andy007]

Damn, I thought I'd checked them all. Thanks.

Sorry Jon. Will send PM next time I see one.

[James]

Phew, I thought I had just broken all my scripts

[muzle6074]

I'm wanting to use the IE builder program but I get an error message found here: http://www.autoitscript.com/forum/index.php?showtopic=71705

What # < includes > do I need to add to the script?

Regards.

[monoceres]

I'm wanting to use the IE builder program but I get an error message found here: http://www.autoitscript.com/forum/index.php?showtopic=71705

What # < includes > do I need to add to the script?

Regards.

It looks like you need, StaticConstants.au3, but you could also try running it through my script on page one as it will fix all the constants you need

Edited May 21, 2008 by monoceres

[muzle6074]

Thank you monoceres!

I didn't see your post of page 1 - IE builder works fine now

Regards.

[enaiman]

Great work with fixing "#include"

... now I have to work on changing command names (e.g. _GUICtrlListViewGetItemText= _GUICtrlListView_GetItemText) and in some cases parameter's order ... ... and I have only a "couple" scripts over 3k lines ...

That's not so bad ... I will fix them sometime.

[gcue]

wow awesome script!!

thank you for posting!!!

Discuss.

[Walker8]

Thanks for the script monoceres, it makes everything a lot easier haha.

[MrCreatoR]

Needs some more detail, and maybe a step by step guide of how to convert a couple of scripts - please reply to this thread with suggestions/drafts of how this post should look and I'll update. This is to help with the inevitable flood of questions when 3.2.12.0 is released.

Here is one version of Step by Step (to add the needed includes):

In v3.2.12.0 a number of changes were made to the include files used for the GUI:

• GUIConstants.au3 is identical to GUIConstantsEx.au3. This means that many scripts using advanced GUI functionality will need to use additional #include statements to include files containing constants that were previously and erroneously included.
• GUIDefaultConstants.au3 no longer exists. You must now #include the corresponding individual constants file for the control type you need.

How you can find out what includes are needed for your script:

• First of all open AutoIt install dir, go to the Include dir, and open the Search tool (F3).
• Now run a "Syntax Check" for your script (from SciTE's Tools menu).
• To jump to the next error press F4, and look at the variable (Constant) that error is pointing on (above the "~~~~~~~^" or "ERROR ^").
• Now copy/remember that variable, go to the Search folder that you open previously, and type under "Search Text" the copied variable, and press Search.
• You will see now the #include File that got your variable, so now you know what #include your script is missing, add it.
• After few "error jumps" and adding new #include files, you can repeat the "Syntax Check" operation to narrow the error results.
• Repeat steps 2, 3, 4, 5 untill you got no errors.

Perhaps need more polishing/corrections, but this is only an idea.

[GEOSoft]

Great work with fixing "#include"

... now I have to work on changing command names (e.g. _GUICtrlListViewGetItemText= _GUICtrlListView_GetItemText) and in some cases parameter's order ... ... and I have only a "couple" scripts over 3k lines ...

That's not so bad ... I will fix them sometime.

I have the name change one already done if it will help you. I'm onto the next steps.

[Valiante]

Can I just ask why this was done? I'm sure there's a good reason, but I just can't think what it might be...

Surely one include was better than two, three or sometimes more?

I'm slightly miffed that now I have to go back and amend all my GUI scripts that worked just fine before...

[monoceres]

I think it was due to the fact that a lot of things were included in GUIConstants that were redundant in most scripts.

If that is not a concern for you then you could always replace your GUIConstants in the include folder with this:

#include-once
#include <AVIConstants.au3>
#include <ButtonConstants.au3>
#include <ComboConstants.au3>
#include <Constants.au3>
#include <DateTimeConstants.au3>
#include <EditConstants.au3>
#include <FontConstants.au3>
#include <GDIPlusConstants.au3>
#include <GUIConstants.au3>
#include <GUIConstantsEx.au3>
#include <HeaderConstants.au3>
#include <ImageListConstants.au3>
#include <IPAddressConstants.au3>
#include <ListBoxConstants.au3>
#include <ListViewConstants.au3>
#include <MemoryConstants.au3>
#include <MenuConstants.au3>
#include <ProgressConstants.au3>
#include <RebarConstants.au3>
#include <ScrollBarConstants.au3>
#include <SecurityConstants.au3>
#include <SliderConstants.au3>
#include <StaticConstants.au3>
#include <StatusBarConstants.au3>
#include <StructureConstants.au3>
#include <TabConstants.au3>
#include <ToolbarConstants.au3>
#include <ToolTipConstants.au3>
#include <TreeViewConstants.au3>
#include <UpDownConstants.au3>
#include <WindowsConstants.au3>

But beware!

On my computer the startup time for my scripts grew from 0.17 ms to 9.5 ms when using this instead of just GUIConstantsEx.

Edited May 30, 2008 by monoceres

[GEOSoft]

Can I just ask why this was done? I'm sure there's a good reason, but I just can't think what it might be...

Surely one include was better than two, three or sometimes more?

I'm slightly miffed that now I have to go back and amend all my GUI scripts that worked just fine before...

One include is not always better than two. There are in excess of 3200 Constants used, why would you want to include all those that your script does not require? For example if your script does not use a ListView control, then why include all of the ListView constants? If you look in Example scripts I have a #Include updater that has not missed yet. It may be somewhat slower than others but the accuracy seems better and you can just pass it an array of file names and get them all done at one time.

Edit: and it was particularily irksome when people used to #include the old GUIConstants file, which #included the list monoceres pointed to above, for the sake of only using one of those constants (usually GUIEventClose) and there was no need for a constants file to be included at all. They could have just put the value of the constant in.

Edited May 30, 2008 by GEOSoft

[cramaboule]

In v3.2.12.0 a number of changes were made to the include files used for the GUI:

• GUIConstants.au3 is identical to GUIConstantsEx.au3. This means that many scripts using advanced GUI functionality will need to use additional #include statements to include files containing constants that were previously and erroneously included.
• GUIDefaultConstants.au3 no longer exists. You must now #include the corresponding individual constants file for the control type you need.

Needs some more detail, and maybe a step by step guide of how to convert a couple of scripts - please reply to this thread with suggestions/drafts of how this post should look and I'll update. This is to help with the inevitable flood of questions when 3.2.12.0 is released.

Is it possible to add the correct <#include> in the Help file,... like the others includes ???

Thanks for your wonderful work !

C.

[Jos]

I am thinking about adding the idea of monoceres into AutoIt3Wrapper and update a script one time when a directive is specified.

I took the original script/idea and created this UDF. Its somewhat faster but could you folfs give it a spin to see if it works as it should be?

Directive will be : #AutoIt3Wrapper_Fix_Includes=y

Which will be reset to "n"when ran to avoid running it each time.

expandcollapse popup

#include <File.au3>
Global $Lines2Add
$ScriptFile_In = FileOpenDialog("Choose script that will be fixed", @ScriptDir, "au3 (*.au3)")
;~ $autoitdir = FileSelectFolder("Autoit Include folder", "")
$INP_AutoitDir = RegRead("HKLM\Software\AutoIt v3\Autoit", 'InstallDir')
Fix_Includes()


Func Fix_Includes()
    ConsoleWrite("+ Check for missing include files:")
    Local $includelines, $scriptdata
    Local $count = 0, $const
    $scriptdata = FileRead($ScriptFile_In)
    Local $includes = _FileListToArray($INP_AutoitDir & "\include", "*Constants*.au3")
    For $i = 1 To UBound($includes) - 1
; don't include GUIConstants.au3
        If $includes[$i] = "GUIConstants.au3" Then ContinueLoop
; Skip already included Include files
        If StringRegExp($scriptdata, "(?s)#include(\s*?)<" & $includes[$i] & ">", 0) Then ContinueLoop
; Get all Constants from include file into Array
        Local $ConstArray
        $ConstArray = StringRegExp(FileRead($INP_AutoitDir & "\include\" & $includes[$i]), "(?i)Global[\s]Const[\s](.*?) = ", 3); '<(?i)test>(.*?)</(?i)test>'
        For $j = 1 To UBound($ConstArray) - 1
            If StringRegExp($scriptdata, "(?s)\" & $ConstArray[$j] & "", 0) Then
                    $Lines2Add &= "#include <" & $includes[$i] & ">" & @CRLF
                    $count += 1
                    ExitLoop
            EndIf
        Next
    Next
; Added required Include statements to the Scriptfile plus some commentlines
    If $count Then
        Local $H_Outf = FileOpen($ScriptFile_In, 2)
        FileWriteLine($H_Outf, "; *** Start added by AutoIt3Wrapper ***" )
        FileWrite($H_Outf, $Lines2Add)
        FileWriteLine($H_Outf, "; *** End added by AutoIt3Wrapper ***")
        FileWriteLine($H_Outf, $scriptdata)
        FileClose($H_Outf)
    EndIf
    ConsoleWrite(" " & $count & " include(s) were added" & @CRLF)
; update directive to n to avoid running it each time
    $ToTalFile = @CRLF & FileRead($ScriptFile_In)
    $ToTalFile = StringRegExpReplace($ToTalFile, '(?i)' & @CRLF & '(\h?)#AutoIt3Wrapper_Fix_Includes(\h*?)=(.*?)' & @CRLF, @CRLF & '#AutoIt3Wrapper_Fix_Includes=n' & @CRLF)
    $H_Outf = FileOpen($ScriptFile_In, 2)
    FileWrite($H_Outf, StringMid($ToTalFile, 3))
    FileClose($H_Outf)
EndFunc ;==>Fix_Includes

Edited May 30, 2008 by Jos

[Valiante]

There are in excess of 3200 Constants used, why would you want to include all those that your script does not require? For example if your script does not use a ListView control, then why include all of the ListView constants?

Why not? What difference does it really make? I'm not being fastidious, I actually don't know!

If it's just about reducing a 9ms startup time (nine one-thousanths of a second?) then I think I could live with that!

Please don't get me wrong, I'm not criticising, I'm just trying to understand...

[GEOSoft]

Why not? What difference does it really make? I'm not being fastidious, I actually don't know!

If it's just about reducing a 9ms startup time (nine one-thousanths of a second?) then I think I could live with that!

Please don't get me wrong, I'm not criticising, I'm just trying to understand...

The more lines of code you add, including constants, the larger the file size.

In my own scripts (the ones I use, which may vary from the ones I release) I don't use constants at all. I replace them with actual values.

[monoceres]

Why not? What difference does it really make? I'm not being fastidious, I actually don't know!

If it's just about reducing a 9ms startup time (nine one-thousanths of a second?) then I think I could live with that!

Please don't get me wrong, I'm not criticising, I'm just trying to understand...

There's also filesize. Tested compiled a script with just GUIConstantsEx and one with all the constants and the fileszie grew from 262,257 bytes to 333,187 bytes, now that is a lot!

Memory usage also increased, from 5680 kB to 7116 kB.

Some stats also:

Speed difference: ~5400%

Filesize difference: ~27%

Memory difference: ~25%

Hope you got some more answers

[Valiante]

Sure - that all makes sense. I guess it just comes down to what you use AutoIt for. Me, personally, I use it to automate various tasks at work, some installations, other just admin tasks to save time. But as I'm not releasing any scripts for public use (not because I'm mean, they're just designed proprietary to our environment) I guess I'm not that worried about their efficiency or overheads.

But I get your point so I'll shut up about it now - it just bugged me that I couldn't run an old script on a newly built machine with the latest AutoIt freshly installed!