WebDriver - add function (wish)

[Erik_NJ]

I know that we can get the version of the Webdriver UDF by getting the value of "$__WDVERSION" but I believe it would be more convenient to have it as a function (just like _WD_IsLatestRelease or _WD_GetWebDriverVersion), may this be added to the next release?

Example:

Func _WD_GetUDFVersion()
    Return $__WDVERSION
EndFunc   ;==>_WD_GetUDFVersion

 

Thanks

[SOLVE-SMART]

Hi @Erik_NJ,

why do you need this? Is there a use case for or is it really only for the sake of convenience? I agree, it would be more consistent regarding the other version information functions, but I am looking for a real use case - because you already did it on your own, right (the function)?

Best regards
Sven

Edited February 25, 2024 by SOLVE-SMART

[SOLVE-SMART]

I checked wd_core.au3 (line 1122) => the function _WD_Option('version') already returns the version number of UDF library.
So your request @Erik_NJ is already built in 😀 .

Best regards
Sven

[Erik_NJ]

Well, Yes it's matter of convenience and also makes sense since my suggestion is more descriptive.

[SOLVE-SMART]

Okay, thanks for the answer @Erik_NJ.
I guess it's now a decision of the project maintainers (and/or only of the author) to consider your suggestion or not.

I personally would say, it's already there. I am with you in terms of, it would be more descriptive.
Additionally I am not a big fan of functions with several "switch case" statements, so I would separate this into a single function.
But in terms of the effort-benefit ratio it's hard to spend the time for (adjust wd_*.au3, adjust READMD.md file, possibly adjust wd_demo*.au3 and so on).

What do you mean @Danp2? Should I open an GitHub issue for it and we discuss this there or is it not worthy to open the issue?

Best regards
Sven

[Erik_NJ]

2 hours ago, Danp2 said:

Interesting discussion. At this time, I don't see the need to add this function to the UDF because

• the functionality already exists, albeit in a different format
• there's nothing preventing you from creating your own wrapper function

Interesting indeed, now, my reason for this request is like I mentioned is for convenience and also aesthetics, as I also mentioned on my first post we have _WD_IsLatestRelease and _WD_GetWebDriverVersion, it does makes sense to me to have _WD_GetUDFVersion, going for the "already exist in a different format" or creating a wrapper to me that's not a good solution, especially if some newbies are trying to learn this UDF, I know, but my OCD is bothering me 😜

Edited February 26, 2024 by Erik_NJ

[SOLVE-SMART]

Fair enough @Erik_NJ 👌 .
I will open an issue on GitHub for it. Maybe also the required pull request too, in case it's fine for @Danp2 and @mLipok ... we will see there.
If you're familiar with GitHub, you could do it on your own 🤔 , how about that?

Best regards
Sven
 

[SOLVE-SMART]

FYI: GitHub issue https://github.com/Danp2/au3WebDriver/issues/510.

Best regards
Sven

[Erik_NJ]

22 minutes ago, SOLVE-SMART said:

FYI: GitHub issue https://github.com/Danp2/au3WebDriver/issues/510.

Best regards
Sven

Thanks!

I agree with Danp2's answer, no need to remove anything, just adding that suggested function will do the trick.