[solved: typo] \ Script updates wrong array

[antai]

Hi,

I use this kind of a function to update my arrays (stripped off anything not necessary):

Func UpdateArray (ByRef $upArray, $addvariable)
        $upArray[0][0] += 1 
        $upArray[0][$upArray[0][0]] = $addvariable
EndFunc

I call this function like 1000 times to update $arrayA and $arrayB. It updates $arrayA ok then it switches to $arrayB, but then it does not switch back to $arrayA.

Things get interesting. I have split the call into this and the result is the same:

If $condition Then
    $arrayA[0][0] += 1  
    $arrayA[0][$arrayA[0][0]] = $addvariable
    MsgBox (0, "A", $addvariable)
Else
    $arrayB[0][0] += 1  
    $arrayB[0][$arrayB[0][0]] = $addvariable
    MsgBox (0, "B", $addvariable
EndIf

Msg displays correct letter BUT then the variable is in the wrong array!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! How?

Can I send the name of the variable directly to the MsgBox? I mean using the MsgBox  that would display the name of the array which we are working on.

 

Edited January 25 by antai

[ioa747]

 

you don't need it because that's what you use in the $upArray parameter when you call the UpdateArray function.
according to my knowledge what is missing is ReDim to resize the existing array.

expandcollapse popup

#include <AutoItConstants.au3>
#include <Array.au3>

Local $aArrayA[51][3]
$aArrayA[0][0] = 50
For $i = 1 To $aArrayA[0][0]
    $aArrayA[$i][0] = "Var_" & $i
Next
Local $Var = "new"
UpdateArray($aArrayA, $Var)
UpdateArray($aArrayA, "new2")
_ArrayDisplay($aArrayA, "$aArrayA")
;~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Local $aArrayB[11][5]
$aArrayB[0][0] = 10
For $i = 1 To $aArrayB[0][0]
    $aArrayB[$i][0] = "Var_" & $i
Next
Local $Var = "new"
UpdateArray($aArrayB, $Var)
_ArrayDisplay($aArrayB, "$aArrayB")
;~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
_ArrayAdd($aArrayB, "New with _ArrayAdd")
$aArrayB[0][0] += 1

_ArrayAdd($aArrayB, "another|with|_ArrayAdd")
$aArrayB[0][0] += 1

_ArrayDisplay($aArrayB, "$aArrayB")
;~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Func UpdateArray(ByRef $upArray, $addvariable, $line = @ScriptLineNumber)
    ConsoleWrite("- Call from Line Number:" & $line & @CRLF)
    Local $iRows = UBound($upArray, $UBOUND_ROWS)     ; Total number of rows.
    Local $iCols = UBound($upArray, $UBOUND_COLUMNS)  ; Total number of columns.

    ConsoleWrite("$iRows:" & $iRows & ", $iCols:" & $iCols & @CRLF)

    ReDim $upArray[$iRows + 1][$iCols]

    $upArray[0][0] = $iRows
    $upArray[$iRows][0] = $addvariable

EndFunc   ;==>UpdateArray

Edit:
You shows us the function, but nowhere how you call it

Edited January 24 by ioa747
update

[jchd]

@antai your code refers to $uArray. What's that?

[antai]

19 hours ago, jchd said:

@antai your code refers to $uArray. What's that?

sorry typo (post corrected)

[antai]

20 hours ago, ioa747 said:

 how you call it

This causes loss of data during the array update:

If $condition Then
        UpdateArray ($arrayA, $variable)
;       UpdateArray ($arrayB, $variable)
    Else
;       UpdateArray ($arrayA, $variable)
        UpdateArray ($arrayB, $variable)
    EndIf

This works fine. All the data in the arrayA:

If $condition Then
        UpdateArray ($arrayA, $variable)
;       UpdateArray ($arrayB, $variable)
    Else
        UpdateArray ($arrayA, $variable)
;       UpdateArray ($arrayB, $variable)
    EndIf

This works fine, All thedata in the arrayB:

If $condition Then
;       UpdateArray ($arrayA, $variable)
        UpdateArray ($arrayB, $variable)
    Else
;       UpdateArray ($arrayA, $variable)
        UpdateArray ($arrayB, $variable)
    EndIf

 

Edited January 25 by antai

[antai]

SOLVED: typo.

FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF AAAAAAAAAAAAAAAAAAA CK!! 15 hours of testing and sleep deprivation because of a simple typo.

Thanks guys, you really helped me.

Your questions pointed me to the right direction.

For those who care: the function is way longer and I several times update the

$upArray[0][0]

I mistyped that in one single occasion causing it to not get updated under certain conditions. No difference when throwing data only to a single array as it always goes up but more arrays caused problems due to calling a completely different variable!