BETA: SciTE v5x & lua Dynamic_include and "Smart" AutoComplete for Vars/UDFs/Abbrevs

[mLipok]

2 minutes ago, Jos said:

I do not see the required include files in the list of Files that are read according the log ...

?

2 minutes ago, Jos said:

Did you check the log for them? In which directory are they located and is that in the list?

previously (10 minutes ago) not checked as it was checked few days ago.

But I just take a look on the file I sent you and I see this:

Quote

>23:03:25 ->PerfDynUDFs ->GetCFileUDFs > Scan include 203-500 file=z:\!!!_svn_au3\udf_forum\mlipok\ADO_CONSTANTS.au3
 23:03:25 ->PerfDynUDFs ->GetCFileUDFs   + cfiFunc 3378 =>_ADO_ERROR_GetErrorInfo
>23:03:25 ->PerfDynUDFs ->GetCFileUDFs > Scan include 204-500 file=z:\!!!_svn_au3\udf_forum\mlipok\ADO.au3
 23:03:25 ->PerfDynUDFs ->GetCFileUDFs   --1> Func=>__ADO_RecordsetArray_Display        ->Skipped internal.
 23:03:25 ->PerfDynUDFs ->GetCFileUDFs   --1> Func=>__ADO_RecordsetArray_IsValid        ->Skipped internal.
 23:03:25 ->PerfDynUDFs ->GetCFileUDFs   + cfiFunc 3379 =>_ADO_Recordset_Display
 23:03:25 ->PerfDynUDFs ->GetCFileUDFs   + cfiFunc 3380 =>_ADO_Recordset_Find
 23:03:25 ->PerfDynUDFs ->GetCFileUDFs   + cfiFunc 3381 =>_ADO_Recordset_ToArray
 23:03:25 ->PerfDynUDFs ->GetCFileUDFs   + cfiFunc 3382 =>_ADO_Recordset_ToString
 23:03:25 ->PerfDynUDFs ->GetCFileUDFs   + cfiFunc 3383 =>_ADO_RecordsetArray_GetContent

 

[mLipok]

In z:\!!!_svn_au3\udf_forum\mlipok\ADO_CONSTANTS.au3

for example there are defined :

; ADCPROP_ASYNCTHREADPRIORITY_ENUM
; https://docs.microsoft.com/en-us/sql/ado/reference/ado-api/adcprop-asyncthreadpriority-enum?view=sql-server-ver15
Global Const $ADO_adPriorityLowest = 1 ;        Sets priority to the lowest possible
Global Const $ADO_adPriorityBelowNormal = 2 ;    Sets priority between lowest and normal
Global Const $ADO_adPriorityNormal = 3 ;        Sets priority to normal
Global Const $ADO_adPriorityAboveNormal = 4 ;    Sets priority between normal and highest
Global Const $ADO_adPriorityHighest = 5 ;        Sets priority to the highest possible

and none of them expanding when I start to type:  $ADO_

Edited July 8, 2022 by mLipok

[Jos]

Think you have the issue I mentioned here :

On 7/3/2022 at 7:26 PM, Jos said:

I just found out I need to revisit the Scanning of the directories in the #SciTE4AutoIt3_Include_Path= as those are only scanned for UDFs at this moment and need to add the scan of Global Const even adding more. 

Maybe I will ask for an Zip containing your setup so I can test with an test environment that contains that many UDFs and probably a lot more Global Const, but I am honestly concerned whether that will ever properly perform with that many Include files, UDFs & Global Vars like you have setup. It might be you need a slightly different apprach for that but need to think about it and play with it for a while.  For the majority of the people (like me) this setup should work quite well.  

More to follow in a couple of days....

This will be fixed in the new version.  

The log file clearly shows this issue here:

>23:03:25 ->PerfDynUDFs ->GetCFileUDFs > Scan include 203-500 file=z:\!!!_svn_au3\udf_forum\mlipok\ADO_CONSTANTS.au3
 23:03:25 ->PerfDynUDFs ->GetCFileUDFs   + cfiFunc 3378 =>_ADO_ERROR_GetErrorInfo

It only detects the UDF in the Constants file ( which is somewhat strange to have an UDF in a Constants.au3 include file, unless it is a __abc internal func    ...no?

Edited July 8, 2022 by Jos

[mLipok]

8 minutes ago, Jos said:

Maybe I will ask for an Zip containing your setup so I can test with an test environment that contains that many UDFs and probably a lot more Global Const

Working on example to test.

 

[mLipok]

I notice that dynamic calltips contains duplicated backslashes

[mLipok]

36 minutes ago, mLipok said:

Working on example to test.

Sent on email.
Hope you will find some spare time in next few days

Michał

[Jos]

Thanks @mLipok for your set of Include files. I have added them into a extra Standard include directory to he open.path= properties and now went up from:

14 extra includes and 369 extra UDFs:

!-> Get_Std_UDFs time: 0.86 GlobalConstFiles:71 GlobalConstVars:13270 STDUDFIncludeFiles:82  STDUDFs:3178  USRUDFIncludeFiles:14  USRUDFs:369  Debugging:0-0-0
--> GetCFileUDFs time:0.11 lCache:0 IncludeFiles:3    UDFs:79    ConstVars:0      Debugging:0-0-0  C:\Program Files (x86)\AutoIt3\SciTE\AutoIt3Wrapper\AutoIt3Wrapper.au3
--> GetCFileUDFs time:0.12 lCache:0 IncludeFiles:4    UDFs:192   ConstVars:39     Debugging:0-0-0  C:\Program Files (x86)\AutoIt3\SciTE\SciTE Jump\SciTE Jump.au3

to 93 extra include files and 1890 extra UDFs  plus some 1500 extra Global Const variables:

!-> Get_Std_UDFs time: 1.19 GlobalConstFiles:77 GlobalConstVars:14723 STDUDFIncludeFiles:82  STDUDFs:3178  USRUDFIncludeFiles:93  USRUDFs:1890  Debugging:0-0-0
--> GetCFileUDFs time:0.14 lCache:0 IncludeFiles:3    UDFs:79    ConstVars:0      Debugging:0-0-0  C:\Program Files (x86)\AutoIt3\SciTE\AutoIt3Wrapper\AutoIt3Wrapper.au3
--> GetCFileUDFs time:0.15 lCache:0 IncludeFiles:4    UDFs:192   ConstVars:39     Debugging:0-0-0  C:\Program Files (x86)\AutoIt3\SciTE\SciTE Jump\SciTE Jump.au3

As you can see there was only a limited initial extra time required and this is without the cache files being build yet. Subsequent starts of SciTE will go faster as only the changed include files will be queried again:

!-> Get_Std_UDFs time: 0.41 GlobalConstFiles:77 GlobalConstVars:14723 STDUDFIncludeFiles:82  STDUDFs:3178  USRUDFIncludeFiles:93  USRUDFs:1890  Debugging:0-0-0
--> GetCFileUDFs time:0.14 lCache:0 IncludeFiles:4    UDFs:192   ConstVars:39     Debugging:0-0-0  C:\Program Files (x86)\AutoIt3\SciTE\SciTE Jump\SciTE Jump.au3

Switching between files is going pretty fast for me on my 5 years old Laptop.
It is also possible to enable caching for the File UDFs & Vars, but honestly think that won't be needed unless you have really many includes just in this project which aren't in the Standard set of Include files in the open.path properties. 

Still have made a list of changes and started to cleanup of the code as things were a bit to "Cut&Paste" all over the place. need another few days but am getting there.  

Edited July 9, 2022 by Jos

[mLipok]

2 hours ago, Jos said:

I have added them into a extra Standard include directory to he open.path= properties

How to you do this?

I would like to try on my side.

Edited July 9, 2022 by mLipok

[Jos]

#> The prod extra includes path. example: openpath.$(au3)=C:\Program Files (x86)\AutoIt3\Include_prive
openpath.$(au3)=$(SciteDefaultHome)\..\Include_prive;$(SciteDefaultHome)\..\Include_test

First one is my standard user includes... the second one your test udfs. (;$(SciteDefaultHome)\..\Include_test)
Obviously you also need to do this in SciTEConfig so AutoIt3 knows about it. This does a registry update.

 

See helpfile Registry keys for details on this page: https://www.autoitscript.com/autoit3/docs/intro/installdir.htm

PS: I am not sure how this all will function when running it portable though!.

 

Edited July 10, 2022 by Jos

[Jos]

I've made changes today that the openpath properties aren't used anymore but rather read the appropriate registry key for the extra user include directories specified here:

Keyname:"HKEY_CURRENT_USER\SOFTWARE\AutoIt v3\AutoIt"   Valuename:"Include"

Making config much easier and avoids any discrepancies.
I am now going to look at making a cachefile per specified extra user include directory in stead of what I have now which is one for all, and storing that into the props["SciteUserHome"] making it also work in portable mode and when included into a Sourcefile by using the directive (I hope)  ...  needs some thinking & testing time. 

Edited July 10, 2022 by Jos

[mLipok]

@Jos I think that one improvement is required.

Dynamically adding an include should check if the desired function calling this process is already accesible or not.

I had added my "Z:\!!!_SVN_AU3\UDF_Forum\mLipok\ADO.au3" and this is my results:

#Region ; *** Dynamically added Include files ***
#include "Z:\!!!_SVN_AU3\UDF_Forum\mLipok\ADO.au3"
#include <ADO.au3>                                           ; (07/10/22 22:55:02
#EndRegion ; *** Dynamically added Include files ***

As you can see this new feature adds new include which was already added manually by myself.

Wolud it be difficult to add such checking (the same which is used when jumping to the function with CTRL+J feature) ?

EDIT:
In this scenario this feature will affect all my script.

 

Edited July 10, 2022 by mLipok

[mLipok]

Currently, I think the following functionality would be really useful as it will allow the code manager to keep track of which files have been changed.
For example, using the grepWin program.

On 7/3/2022 at 3:08 PM, mLipok said:

do you plan in the future to save the comments 

Quote

; (07/03/22 15:00:34

?

if so I propse to change them:

Quote

; automatically added by SciTE4AutoIt - 07/03/22 15:00:34

 

 

Could you reconsider adding such a change to the comment description?

[Jos]

10 hours ago, mLipok said:

As you can see this new feature adds new include which was already added manually by myself.

Well it is odd/confusing to say the least that one uses include files with the same filename from different places, but that could be done easily, but then the question arises which one to use in which situation:

1. What to do when they aren't the same and one contains something the other doesn't have? 
2. What when your manual #include "xyz" includes other include files that could also have this issue?
3. ... and there will be many more were it could go wrong.

My current version actually check for duplicate names and warns about them as I feel that really shouldn't be the case altogether!...   agree? 

by the way: did you try adding this to your example script to tell dynamic includes about this include directory?:

#SciTE4AutoIt3_Include_Path=Z:\!!!_SVN_AU3\UDF_Forum\mLipok\

 

Edited July 11, 2022 by Jos

[Jos]

10 hours ago, mLipok said:

Currently, I think the following functionality would be really useful as it will allow the code manager to keep track of which files have been changed.
For example, using the grepWin program.

 

Could you reconsider adding such a change to the comment description?

This is the second time you ask and I think I answered that ...no? 

and my answer was:

Nope...  They are inside the #region created by Dynamic Includes and they are added at the end of it with the Date/Timestamp, which I my humble opinion is enough.

[mLipok]

14 minutes ago, Jos said:

1. What to do when they aren't the same and one contains something the other doesn't have? 

If I have setup anything by myself for example:

#include "Z:\!!!_SVN_AU3\UDF_Forum\mLipok\ADO.au3"

then dynamic include for "ADO.au3" should not be added.

The user choice should always have higher piority, dynamic setup should have lower piority.

 

14 minutes ago, Jos said:

2. What when your manual #include "xyz" includes other include files that could also have this issue?

It should not happen as previous case will be the first matching rule.

14 minutes ago, Jos said:

My current version actually check for duplicate names and warns about them as I feel that really shouldn't be the case altogether!...   agree? 

Agree about warrning.
But is it just a warning or does it leave the user's choices unchanged (I mean without adding dynamicaly new include setup)?

 

Edited July 11, 2022 by mLipok

[Jos]

1 minute ago, mLipok said:

If I have setup anything by myself for example:

#include "Z:\!!!_SVN_AU3\UDF_Forum\mLipok\ADO.au3"

then dynamic include for "ADO.au3" should not be added.

Something is wrong with this logic, but please send  me the log so I can see why it was added anyways while you state is should already be in the included file. I need to complete log so I can see what was loaded at SciTE Startup and ad Add include time.

I made this addition to that answer post and am curious if that fixes it:

14 minutes ago, Jos said:

by the way: did you try adding this to your example script to tell dynamic includes about this include directory?:

#SciTE4AutoIt3_Include_Path=Z:\!!!_SVN_AU3\UDF_Forum\mLipok\

 

 

[Jos]

7 minutes ago, mLipok said:

Agree about warrning.
But is it just a warning or does it leave the user's choices unchanged?

It will only add the first found include to its selection as the logic will not handle multiple include files with the same name and I have no plans to make it even more complex than it already is. So it will actually cause issues like you have indicated.

Edited July 11, 2022 by Jos

[mLipok]

20 minutes ago, Jos said:

by the way: did you try adding this to your example script to tell dynamic includes about this include directory?:

#SciTE4AutoIt3_Include_Path=Z:\!!!_SVN_AU3\UDF_Forum\mLipok\

 

It made me realize that I forgot to add that I used a slightly older version. i.e. I tested how it works with this setting:

Quote

openpath.$(au3)=$(SciteDefaultHome)\..\include;z:\!!!_SVN_AU3\UDF_ML;z:\!!!_SVN_AU3\UDF_Forum\Other_Members;z:\!!!_SVN_AU3\UDF_Forum\mLipok

So I update to current version and check again with:

#SciTE4AutoIt3_Include_Path=Z:\!!!_SVN_AU3\UDF_Forum\mLipok\

Then I back with results in few minutes. (Hope so.)

Edited July 11, 2022 by mLipok

[mLipok]

6 minutes ago, Jos said:

So it will actually cause issues like you have indicated.

I hope not forever.

[Jos]

Don't understand the sad face response...   I think you will have to learn LUA and code it yourself as you seem to think it can easily be changed. I would be happy to put the LUA script on GitHub so you can make all the pull requests you want to make all of your changes happen yourself and share them with the world!  

...but honestly think your setup is way to complex when you have duplicate includes in different paths including the standard one.
 

So my last suggestion didn't change anything as I assumed that it might have fixed it for you....      When it doesn't then send me that logfile so I can see what is going on and don't have to guess.