AutoIt v3.3.15.5 Beta issue with _pathsplit

[erha]

This is my first post - I hope I follow all rules 😀

I have used the portable autoit version 3.3.15.4 Beta. After switching to 3.3.15.5 Beta I could run my programs from scite but the compilation crashes.

For some reasons compile uses _PathSplit. In case the parameter $sFilePath is an empty string, _PathSplit crashes.

_PathSplit uses

Local $aArray = StringRegExp($sFilePath, "^\h*((?:\\\\\?\\)*(\\\\[^\?\/\\]+|[A-Za-z]:)?(.*[\/\\]\h*)?((?:[^\.\/\\]|(?(?=\.[^\/\\]*\.)\.))*)?([^\/\\]*))$", $STR_REGEXPARRAYMATCH)

AutoIt version 3.3.15.4 returns an array with 5, AutoIt version 3.3.15.5 returns an array with 3 elements. The missing two elements are the reason for the crash.

I have used this test program:

#include "StringConstants.au3"

Local $sFilePath = ''
Local $aArray = StringRegExp($sFilePath, "^\h*((?:\\\\\?\\)*(\\\\[^\?\/\\]+|[A-Za-z]:)?(.*[\/\\]\h*)?((?:[^\.\/\\]|(?(?=\.[^\/\\]*\.)\.))*)?([^\/\\]*))$", $STR_REGEXPARRAYMATCH)
MsgBox ( 0,0, UBound($aArray)  )

As a workaround I changed _PathSplit to

Func _PathSplit($sFilePath, ByRef $sDrive, ByRef $sDir, ByRef $sFileName, ByRef $sExtension)
    Local $aArray = StringRegExp($sFilePath, "^\h*((?:\\\\\?\\)*(\\\\[^\?\/\\]+|[A-Za-z]:)?(.*[\/\\]\h*)?((?:[^\.\/\\]|(?(?=\.[^\/\\]*\.)\.))*)?([^\/\\]*))$", $STR_REGEXPARRAYMATCH)
    If @error Then ; This error should never happen.
        ReDim $aArray[5]
        $aArray[$PATH_ORIGINAL] = $sFilePath
    EndIf
    if UBound ( $aArray) < 5 Then ; ### my change
        ReDim $aArray[5]
        $aArray[$PATH_ORIGINAL] = $sFilePath
    endif
    ...

After this change I can compile my programs.

[Jos]

Could you also post an script that uses pathsplit demonstrating your issue?

 

Ps I've split it into its own topic in support.

Edited March 3, 2022 by Jos

[Nine]

@Jos  I get also the problem on non-portable.  

#include <File.au3>
#include <Array.au3>

Local $sDrive, $sDir, $sFileName, $sExtension
Local $arr = _PathSplit("", $sDrive, $sDir, $sFileName, $sExtension)
_ArrayDisplay($arr, @AutoItVersion)

Both SRE (current and beta) are identical.  It might be the fix #2696: StringRegExp non-participating groups that causes the problem.

[erha]

@Jos

Nine has posted the script i just wanted to post too. His script crashes in the new autoit version. The error message is

"D:\System\Programme\Portable\AutoIt\Current\Include\File.au3" (1012) : ==> Array variable has incorrect number of subscripts or subscript dimension range exceeded.:
$sFileName = $aArray[$PATH_FILENAME]
$sFileName = ^ ERROR

[Nine]

Crashes on :

"Test"
"Test.txt"
"\Test.txt"
"..\Test.txt"

In other words, it does not crash only when a full path is pass to the function

[Jos]

Tnx,  reopened https://www.autoitscript.com/trac/autoit/ticket/2696 so it can be checked.  

[labichea]

Same for me - The error happens almost immediately when asking for "Tools/Compile" from SCITE. It works when asking for "Tools/Build" 

......\Include\File.au3" (1012) : ==> Array variable has incorrect number of subscripts or subscript dimension range exceeded.:
$sFileName = $aArray[$PATH_FILENAME]
$sFileName = ^ ERROR

No error when compilation is outside of Scite.

Edited March 5, 2022 by labichea
additional finding

[Nine]

Still crashing in 3.3.16.0 

[Jos]

@Jon ...

Edited March 5, 2022 by Jos

[mLipok]

On 3/3/2022 at 7:35 PM, Nine said:

@Jos  I get also the problem on non-portable.  

#include <File.au3>
#include <Array.au3>

Local $sDrive, $sDir, $sFileName, $sExtension
Local $arr = _PathSplit("", $sDrive, $sDir, $sFileName, $sExtension)
_ArrayDisplay($arr, @AutoItVersion)

Both SRE (current and beta) are identical.  It might be the fix #2696: StringRegExp non-participating groups that causes the problem.

I tried your repro and after few more test I found out other issue AutoIt3.exe ended.rc:-1073741571 with this repro:

#AutoIt3Wrapper_AutoIt3Dir="z:\AutoItPortable\AutoIt_3_3_16_0_rc1"
#AutoIt3Wrapper_UseX64=n

ConsoleWrite("! " & @AutoItVersion & @CRLF)

_Example3()

Func _Example3()
    Local Const $s_RegExp = _ ; $s_RegExp comes from Func _PathSplit(
            '^\h*((?:\\\\\?\\)*(\\\\[^\?\/\\]+|[A-Za-z]:)?(.*[\/\\]\h*)?((?:[^\.\/\\]|(?(?=\.[^\/\\]*\.)\.))*)?([^\/\\]*))$'

    Local $sString = 'xxxxxxxxxx'
    For $iCounter = 1 To 11
        ConsoleWrite("- step #" & $iCounter & ' StringLen= ' & StringLen($sString) & @CRLF)
        StringRegExp($sString, $s_RegExp, 0)
        $sString &= $sString
    Next
EndFunc   ;==>_Example3

results:

Quote

! 3.3.14.5
- step #1 StringLen= 10
- step #2 StringLen= 20
- step #3 StringLen= 40
- step #4 StringLen= 80
- step #5 StringLen= 160
- step #6 StringLen= 320
- step #7 StringLen= 640
- step #8 StringLen= 1280
- step #9 StringLen= 2560
- step #10 StringLen= 5120
- step #11 StringLen= 10240
!>18:47:37 AutoIt3.exe ended.rc:-1073741571

 

Edited March 5, 2022 by mLipok

[Jon]

See, this is why I'm not blindly adding the alpha patches. It's really easy to mess up some of this codebase.

 

[mLipok]

@Jon this is old bug:

Quote

! 3.3.14.5
- step #1 StringLen= 10
- step #2 StringLen= 20
- step #3 StringLen= 40
- step #4 StringLen= 80
- step #5 StringLen= 160
- step #6 StringLen= 320
- step #7 StringLen= 640
- step #8 StringLen= 1280
- step #9 StringLen= 2560
- step #10 StringLen= 5120
- step #11 StringLen= 10240
!>18:51:24 AutoIt3.exe ended.rc:-1073741571
 

 

[mLipok]

even au3.3.10.0

Quote

! 3.3.10.0
- step #1 StringLen= 10
- step #2 StringLen= 20
- step #3 StringLen= 40
- step #4 StringLen= 80
- step #5 StringLen= 160
- step #6 StringLen= 320
- step #7 StringLen= 640
- step #8 StringLen= 1280
- step #9 StringLen= 2560
- step #10 StringLen= 5120
- step #11 StringLen= 10240
!>18:52:49 AutoIt3.exe ended.rc:-1073741571
 

 

[Jon]

Not looking at old bugs. This thing is going out the door.

Reverted the string reg exp groups change and that looks to fix the crash. Will create a new installer.

[Nine]

@Jon RC2 fixes the issue. Thanks.

[erha]

I have tested with AutoIt portable 3.3.16.0-rc3. Everything is okay. Thank you.

[jpm]

I don't undertand what happen with 3.3.16.0-rc1

What I am sure is the propose patch  to Jon was OK. I cannot reproduce any error mention above.

I agree that the support of non participating group return difference which are the right way to return

Just use https://regex101.com/ to validate your pattern.

Previously StringRegExp() was returning extra group.

In fact nobody can give me a pattern which was ok without any adaptation to _PathSplit()

The _PathSplit() has been adapted to handle these differences.

Cheers

Edited: I recheck what was included in 3.3.16.0.rc1 and I found Jon forget to update the File.au3

Edited June 17, 2022 by jpm

[argumentum]

3 hours ago, jpm said:

3.3.16.0-rc1

rc2 is the newer one ( Just in case. Don't hit me  )

[jchd]

3 hours ago, jpm said:

In fact nobody can give me a pattern which was ok without any adaptation to _PathSplit()

Indeed I've been unable to find a reasonable pattern to match every form a path can have.

expandcollapse popup

Local $a = [ _
    "fff", _
    "fff.ext", _
    "fff.more.ext", _
    "./fff.more.ext", _
    "..\fff.more.ext", _
    "..\fff. more .ext ", _
    "..\././.../fff. more .ext ", _
    "c:.../fff. more .ext ", _
    "..\fff. more .ext ", _
    "C:\Documents\Newsletters\Summer2018.pdf", _
    "\Program Files\Custom Utilities\StringFinder.exe", _
    "2018\January.xlsx", _
    "..\Publications\TravelBrochure.pdf", _
    "C:\Projects\apilibrary\apilibrary.sln", _
    "C:Projects\apilibrary\apilibrary.sln", _
    "\\system07\C$\", _
    "\\Server2\Share\Test\Foo.txt", _
    "\\.\C:\Test\Foo.txt", _
    "\\?\C:\Test\Foo.txt", _
    "\\.\Volume{b75e2c83-0000-0000-0000-602f00000000}\Test\Foo.txt", _
    "\\?\Volume{b75e2c83-0000-0000-0000-602f00000000}\Test\Foo.txt", _
    "\\.\UNC\Server\Share\Test\Foo.txt", _
    "\\?\UNC\Server\Share\Test\Foo.txt", _
    "\\?\server1\e:\utilities\\filecomparer\", _
    "c:\temp\test-file.txt", _
    "\\127.0.0.1\c$\temp\test-file.txt", _
    "\\LOCALHOST\c$\temp\test-file.txt", _
    "\\.\c:\temp\test-file.txt", _
    "\\?\c:\temp\test-file.txt", _
    "\\.\UNC\LOCALHOST\c$\temp\test-file.txt", _
    "\\127.0.0.1\c$\temp\test-file.txt", _
    "con", _
    "con:", _
    "lpt2", _
    "com4:", _
    "", _       ; invalid
    ".", _      ; invalid
    "Z꞉abc.xyz", _    ; dirty Unicode trick using "꞉" (ChrW(0x2236)) instead of ":" (ASCII column)
    "..", _
    "...", _
    "...a", _
    "....a", _
    "....a.", _
    "....a...", _
    ".a.b", _
    ".a.b.", _
    ".3", _
    "3." _
]

 

[jpm]

34 minutes ago, argumentum said:

rc2 is the newer one ( Just in case. Don't hit me  )

I just explain why rc1 was not ok.

I still have a working solution as I said