How can I add a function without it being part of GUICreate?

TalesFromTheScript · February 26, 2021

Is there a way to set the function $WS_EX_TOPMOST somewhere on its own, so it's not interfering with other functions in GUICreate?

Cheers.

dmob · February 26, 2021

See if _WinAPI_SetWindowLong might help.

Edit: WinSetOnTop?

Edited February 26, 2021 by dmob

Melba23 · February 26, 2021

TalesFromTheScript,

Your question has already been answered in the thread that was locked when you refused to believe the responses you received there. I will make one final attempt to get through to you.

$WS_EX_TOPMOST is a "style" not a "function" - so I suggest you start by reading the Setting Styles tutorial in the Wiki so that you actually understand what you are dealing with.

Next, in your attempts to use GUICreate in the other thread you were not correctly setting the parameters:

GUICreate("My GUI", 600, 400, -1, -1, Default, $nIniXPos, $nIniYPos)

Let us look at the Help file page for GUICreate:

GUICreate ( "title" [, width [, height [, left = -1 [, top = -1 [, style = -1 [, exStyle = -1 [, parent = 0]]]]]]] )

Starting from the left we get:

Parameter   Correct         Your version    Comment

The basics:

Title       string          string          Good
Width       value           value           Good
Height      value           value           Good
x pos       value           default (-1)    Good
y pos       value           default (-1)    Good

Now we come to the tricky bits:

style       various style   default         Good
            values
exstyle     various exstyle Xpos value?     Why?
            values
parent      handle of       Ypos value?     Why?
            parent GUI

So as you can (I hope) see you were placing coordinate values retrieved from your Ini file into the parameter spaces reserved for extended style and parent GUI handle values. Little wonder that it did not work!

What you need to do to add the $WS_EX_TOPMOST style to your GUI is to add the style to the default values - something like this:

GUICreate("My GUI", 600, 400, -1, -1, Default, BitOR($WS_EX_WINDOWEDGE, $WS_EX_TOPMOST))

Now you will have the $WS_EX_TOPMOST style applied to your GUI. The tutorial I linked to earlier explains why you need to use BitOR - you did read it?

Does that make the whole thing any clearer?

M23

TalesFromTheScript · February 26, 2021

Cheers Melba23 that does answer it.

I am still stuck on how to add $nIniXPos and $nIniYPos (detailed in the other thread) without those having to be part of GUICreate.

I have exactly the same functionality I had before - I still don't know how to add a function globally to the GUI without it being part of GUICreate.

A drawback I did find with those ini functions to save window position was, if another instance of the GUI is opened, it saves the X and Y coordinates as 32000 on each and you can't get the GUI on screen unless you delete the ini file, so even if I can add $nIniXPos and $nIniYPos in separately somewhere, I'm going to have that to contend with. I thought about some way to make it read only but that's not going to be possible when opening another instance of the GUI is just going to toggle the read only attribute on/off or whatever, it's still just going to write to it (or else no instance could) so it can't be done, well at least I can't do it.

I'm just not cut out for this, it would be easier learning Chinese.

Since the always on top functionality can be made to work (your way or the way I was originally doing it) I think I'll just try to find some other software altogether that can save the window position, I am past caring at this point.

Cheers.

Edited February 26, 2021 by TalesFromTheScript

Melba23 · February 26, 2021

TalesFromTheScript,

Glad I could help.

Now to the new question: It looks as if those coordinates are stored in an ini file - is that so that the GUI opens in the same position each time? And you want to store the position if the GUI is moved during run-time?

If so, then you know how to read the values using IniRead - you then need to put those values into the correct parameters of the GUICreate call (left & top). If you want to check for any changes in position during run-time then a simple way is to use IniWrite to save the current position as the script exits. You would need to do something like this:

Local $aWPos = WinGetPos($hWnd)
If IsArray($aWPos) Then
    IniWrite($sMyIniLocation, 'MAINWINPOS', 'XPOS', $aWPos[0])
    IniWrite($sMyIniLocation, 'MAINWINPOS', 'YPOS', $aWPos[1])
EndIf

Now you will have stored the correct values in the ini file to be read the next time the app is run.

All clear?

M23

Musashi · February 26, 2021

17 minutes ago, TalesFromTheScript said:

I'm just not cut out for this, it would be easier learning Chinese.

No, it definitely would not .

I suspect your brain is just trapped at the moment. Please provide a complete, meaning runnable, example script so that we have a foundation for further explanation.

TalesFromTheScript · February 26, 2021

Thanks Melba23, but now I have the X and Y values being saved in the ini, without it actually reading it when the GUI runs, it's back in the center of the screen each time it runs, with the ini changing if I move then close the GUI.

It has to almost be 100% fixed now!

; AutoIt 3.1.1

#include <GuiConstants.au3>
#include <AutoItConstants.au3>
#include <WindowsConstants.au3>

Global $sMyIniLocation = "MyFolder\WindowPosition.ini"
Global $nIniXPos = Int(IniRead($sMyIniLocation, 'MAINWINPOS', 'XPOS', Int(@DesktopWidth/2.5)))
Global $nIniYPos = Int(IniRead($sMyIniLocation, 'MAINWINPOS', 'YPOS', Int(@DesktopHeight/2.5)))

Func _myWM_MOVE($hWnd, $nMsg, $wParam, $lParam)
Local $aWPos = WinGetPos($hWnd)
    If IsArray($aWPos) Then
    IniWrite($sMyIniLocation, 'MAINWINPOS', 'XPOS', $aWPos[0])
    IniWrite($sMyIniLocation, 'MAINWINPOS', 'YPOS', $aWPos[1])
    EndIf
    Return
 EndFunc

GUIRegisterMsg(0x03, "_myWM_MOVE")
GUISetState()

;; GUICreate line I was using, it works...
;; GUICreate("My GUI", 600, 400, -1, -1, Default, $WS_EX_TOPMOST)

;; GUICreate line suggested by Melba23, same functionality...
GUICreate("My GUI", 600, 400, -1, -1, Default, BitOR($WS_EX_WINDOWEDGE, $WS_EX_TOPMOST))

;; The rest of the script is buttons etc

Edited February 26, 2021 by TalesFromTheScript

Melba23 · February 26, 2021

TalesFromTheScript,

Did you read what I wrote above?

Quote

you know how to read the values using IniRead - you then need to put those values into the correct parameters of the GUICreate call (left & top)

Now look at the code you just posted:

GUICreate("My GUI", 600, 400, -1, -1, Default, $WS_EX_TOPMOST)

I see hard-coded values of -1 in both the "left" and "top" parameters - which in AutoIt means Default and so "centre of screen" when it comes to creating GUIs. What you should have in those parameters is the saved x & y coordinates you read from your ini file.

M23

TalesFromTheScript · February 26, 2021

Sorry Melba23 I can't even work that out, it doesn't help that I have been awake for 20 minutes lol

Yes it is all working now, I opened 3 instances of the GUI and it always saves properly, wherever the last one was closed

GUICreate("MyGUI", 600, 400, $nIniXPos, $nIniYPos, Default, $WS_EX_TOPMOST)

Sorry I was being an asshat yesterday but I just don't have any patience. I'm working on it.

Melba23 let me know if there's a place I can donate $10 or something, either to you or the forum. It's not much but you have helped a great deal.

Melba23 · February 26, 2021

TalesFromTheScript,

Quote

Sorry I was being an asshat yesterday but I just don't have any patience. I'm working on it.

Apology accepted on behalf of those who responded to that thread. Patience is a great asset if you want to learn coding - keep on working at it!

There is a "Donate" on the Home page at top right - evrey little helps pay the server costs.

M23

Musashi · February 26, 2021

2 hours ago, TalesFromTheScript said:

Sorry I was being an asshat yesterday but I just don't have any patience. I'm working on it.

Apology accepted as well

TalesFromTheScript · February 27, 2021

I noticed something weird, it doesn't always happen but sometimes the GUI isn't visible on screen, when I check the ini file for the window position, it says:

[MAINWINPOS]
XPOS=-32000
YPOS=-32000

The GUI exists and can be closed from the taskbar.

I thought it seemed to be happening if I ran a game that changed the desktop resolution, but I think I got it to do it without running that game.

The solution is to just delete the ini file but I wonder why it's sometimes doing this.

A typical value that's right looks like this:

[MAINWINPOS]
XPOS=1316
YPOS=467

Nine · February 27, 2021

This is happening when you minimize a window. A minimized window will be positioned at -32000 / -32000. You need to check the state of the window before you write to the ini file.

Edited February 27, 2021 by Nine

TalesFromTheScript · February 28, 2021

I have no idea how and will just end up messing it up.

I'll just have to make sure it's not minimized whenever I close it.

I was thinking, even if by some miracle I managed to have it checking the state, isn't it only going to do the same thing if it's closed while minimized? Saving the coordinates at -32000?

Edited February 28, 2021 by TalesFromTheScript

Danp2 · February 28, 2021

This is part of your original code --

Func _myWM_MOVE($hWnd, $nMsg, $wParam, $lParam)
Local $aWPos = WinGetPos($hWnd)
    If IsArray($aWPos) Then
    IniWrite($sMyIniLocation, 'MAINWINPOS', 'XPOS', $aWPos[0])
    IniWrite($sMyIniLocation, 'MAINWINPOS', 'YPOS', $aWPos[1])
    EndIf
    Return
 EndFunc

You need to check the position before blindly writing the contents to the ini file. Alternatively, you could use WinGetState to check the window's state.

Nine · February 28, 2021

You should also check if the hWnd is indeed the handle of your GUI. If you show an _ArrayDisplay for example, it will be intercepted by your handler and you will get false coordinates.

TalesFromTheScript · February 28, 2021

Way over my head.

Melba23 · February 28, 2021

TalesFromTheScript,

Quote

You need to check the position before blindly writing the contents to the ini file

That could be as simple as checking the value is not -32000 before saving - you would use an If...EndIf structure to do this.

Quote

you could use WinGetState to check the window's state

This means checking that the window is not minimized before saving - again an If...EndIf structure but looking at the result from WinGetState.

Quote

check if the hWnd is indeed the handle of your GUI

Windows messages are sent by all the various windows and controls in the system - you need to make sure that the message you receive is indeed from your own GUI. You do this by using an If...EndIf structure (sound familiar?) checking that the value of $hWnd in your message is the same as the value returned by your GUICreate function - that way you are sure it is your GUI being resized and not any other.

Back down to head level now?

M23

TalesFromTheScript · February 28, 2021

I'll try to fix it at some point but I don't know what I'm doing.

The script uses batch files to download and process videos. It's all perfected now apart from this -32000 thing.

I got sick of using things like 4K Downloader and decided to make my own menu that does what I want

There's other menus apart from this, for converting video, audio, making your video smaller etc.

Every menu has the same problem this one has, but if I can fix it for this one I know how to fix it for the rest.

This is the complete script as it is currently:

; AutoIt 3.1.1

#include <GuiConstants.au3>
#include <AutoItConstants.au3>
#include <WindowsConstants.au3>

Global $sMyIniLocation = "----\WinPos\WinPos_DownloadVideo.ini"
;; Raising DesktopWidth moves the GUI left
;; Raising DesktopHeight moves the GUI up
Global $nIniXPos = Int(IniRead($sMyIniLocation, 'MAINWINPOS', 'XPOS', Int(@DesktopWidth/2.95)))
Global $nIniYPos = Int(IniRead($sMyIniLocation, 'MAINWINPOS', 'YPOS', Int(@DesktopHeight/3.95)))

Func _myWM_MOVE($hWnd, $nMsg, $wParam, $lParam)
Local $aWPos = WinGetPos($hWnd)
    If IsArray($aWPos) Then
    IniWrite($sMyIniLocation, 'MAINWINPOS', 'XPOS', $aWPos[0])
    IniWrite($sMyIniLocation, 'MAINWINPOS', 'YPOS', $aWPos[1])
    EndIf
    Return
 EndFunc

GUIRegisterMsg(0x03, "_myWM_MOVE")
GUISetState()

; GUI
GUICreate("Download Video", 590, 515, $nIniXPos, $nIniYPos, Default, $WS_EX_TOPMOST)
GuiSetIcon("ffmpeg.ico", 0)
; GUISetBkColor(0x990000)

; PIC
; GuiCtrlCreatePic("pic.jpg", 0, 0, 300, 700)

; BUTTONS
$button1 = GUICtrlCreateButton ("Download Video/Channel", 30,20,530,35,$BS_ICON)
GUICtrlSetFont ($button1, 13, 700, 0, "Segoe UI")
GUICtrlSetBkColor(-1, 0xffad99)
GUICtrlSetImage (-1, "Icon2.ico",-1)

$button2 = GUICtrlCreateButton ("Download Videos Before Date (Channel)", 30,60,530,35,$BS_ICON)
GUICtrlSetFont ($button2, 13, 700, 0, "Segoe UI")
GUICtrlSetBkColor(-1, 0xffad99)
GUICtrlSetImage (-1, "Icon2.ico",-1)

$button3 = GUICtrlCreateButton ("Download Videos After Date (Channel)", 30,100,530,35,$BS_ICON)
GUICtrlSetFont ($button3, 13, 700, 0, "Segoe UI")
GUICtrlSetBkColor(-1, 0xffad99)
GUICtrlSetImage (-1, "Icon2.ico",-1)

$button4 = GUICtrlCreateButton ("Download Video and Normalize Audio", 30,140,530,35,$BS_ICON)
GUICtrlSetFont ($button4, 13, 700, 0, "Segoe UI")
GUICtrlSetBkColor(-1, 0xffad99)
GUICtrlSetImage (-1, "Icon2.ico",-1)

$button5 = GUICtrlCreateButton ("Download Video/Normalize/Mono/Save as MP4", 30,180,530,35,$BS_ICON)
GUICtrlSetFont ($button5, 13, 700, 0, "Segoe UI")
GUICtrlSetBkColor(-1, 0xffcc00)
GUICtrlSetImage (-1, "Icon2.ico",-1)

$button6 = GUICtrlCreateButton ("Download Video and Save as MP3 Stereo 128k", 30,220,530,35,$BS_ICON)
GUICtrlSetFont ($button6, 13, 700, 0, "Segoe UI")
GUICtrlSetBkColor(-1, 0xffad99)
GUICtrlSetImage (-1, "Icon2.ico",-1)

$button7 = GUICtrlCreateButton ("Download Video/Normalize/Trim/Save MP3 Mono 96k", 30,260,530,35,$BS_ICON)
GUICtrlSetFont ($button7, 13, 700, 0, "Segoe UI")
GUICtrlSetBkColor(-1, 0xffb3ff)
GUICtrlSetImage (-1, "Icon2.ico",-1)

$button8 = GUICtrlCreateButton ("Download Video and Save as WAV Audio", 30,300,530,35,$BS_ICON)
GUICtrlSetFont ($button8, 13, 700, 0, "Segoe UI")
GUICtrlSetBkColor(-1, 0xffad99)
GUICtrlSetImage (-1, "Icon2.ico",-1)

$button9 = GUICtrlCreateButton ("Download Subtitles From Video/Channel", 30,340,530,35,$BS_ICON)
GUICtrlSetFont ($button9, 13, 700, 0, "Segoe UI")
GUICtrlSetBkColor(-1, 0xffad99)
GUICtrlSetImage (-1, "Icon2.ico",-1)

$button10 = GUICtrlCreateButton ("Download Subtitles Before Date (Channel)", 30,380,530,35,$BS_ICON)
GUICtrlSetFont ($button10, 13, 700, 0, "Segoe UI")
GUICtrlSetBkColor(-1, 0xffad99)
GUICtrlSetImage (-1, "Icon2.ico",-1)

$button11 = GUICtrlCreateButton ("Download Subtitles After Date (Channel)", 30,420,530,35,$BS_ICON)
GUICtrlSetFont ($button11, 13, 700, 0, "Segoe UI")
GUICtrlSetBkColor(-1, 0xffad99)
GUICtrlSetImage (-1, "Icon2.ico",-1)

$button12 = GUICtrlCreateButton ("Open NEW Folder", 30,460,530,35,$BS_ICON)
GUICtrlSetFont ($button12, 13, 700, 0, "Segoe UI")
GUICtrlSetBkColor(-1, 0xcccccc)
GUICtrlSetImage (-1, "Icon2.ico",-1)

GUISetState()

While 1
$msg = GUIGetMsg()
Select

Case $msg = $GUI_EVENT_CLOSE
Exit

Case $msg = $button1
Run("----\# Download Video (from Clipboard Link).bat")

Case $msg = $button2
Run("----\# Download Videos Before Date.bat")

Case $msg = $button3
Run("----\# Download Videos After Date.bat")

Case $MSG = $button4
Run("----\# Download Video and Normalize.bat")

Case $MSG = $button5
Run("----\# Download Video, Normalize, Mono, Save as MP4.bat")

Case $MSG = $button6
Run("----\# Download Video and Save as MP3 (Stereo, 128k).bat")

Case $MSG = $button7
Run("----\# Download Video, Normalize, Trim, Save as MP3 (Mono, 96k).bat")

Case $MSG = $button8
Run("----\# Download WAV Audio from Video (from Clipboard Link).bat")

Case $MSG = $button9
Run("----\# Download Subtitles (from Clipboard Link).bat")

Case $MSG = $button10
Run("----\# Download Subtitles Before Date.bat")

Case $MSG = $button11
Run("----\# Download Subtitles After Date.bat")

Case $MSG = $button12
Run("----\# Open NEW Folder.bat")

Case Else
;;;
EndSelect
WEnd

Edited March 2, 2021 by TalesFromTheScript

TalesFromTheScript · March 4, 2021

Does anyone know what to do with the above script to stop it saving the GUI position at -32000 (off screen), when it's closed when minimized?

I have no idea how to fix it myself.

I promise I won't ask anything else after this, because this is the only problem with the script now!

Block all input without UAC	Save/Retrieve Images to/from Text	Monitor Management (VCP commands)
Tool to search in text (au3) files	Date Range Picker	Virtual Desktop Manager
Sudoku Game 2020	Overlapped Named Pipe IPC	HotString 2.0 - Hot keys with string
x64 Bitwise Operations	Multi-keyboards HotKeySet	Recursive Array Display
Fast and simple WCD IPC	Multiple Folders Selector	Printer Manager
GIF Animation (cached)	Screen Scraping	Multi-Threading Made Easy

Block all input without UAC	Save/Retrieve Images to/from Text	Monitor Management (VCP commands)
Tool to search in text (au3) files	Date Range Picker	Virtual Desktop Manager
Sudoku Game 2020	Overlapped Named Pipe IPC	HotString 2.0 - Hot keys with string
x64 Bitwise Operations	Multi-keyboards HotKeySet	Recursive Array Display
Fast and simple WCD IPC	Multiple Folders Selector	Printer Manager
GIF Animation (cached)	Screen Scraping	Multi-Threading Made Easy

How can I add a function without it being part of GUICreate?

Recommended Posts

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Create an account or sign in to comment

Create an account

Sign in

Recently Browsing 0 members