AU3Check ended.rc:-1073740791 : many #include

[FrancoDM]

Quote

>"C:\Program Files (x86)\AutoIt3\SciTE\..\AutoIt3.exe" "C:\Program Files (x86)\AutoIt3\SciTE\AutoIt3Wrapper\AutoIt3Wrapper.au3" /Prod /AU3check /in "C:\Github\proyect\Main.au3"
+>15:27:08 Starting AutoIt3Wrapper (19.1127.1402.0} from:SciTE.exe (4.2.0.0)  Keyboard:0000080A  OS:WIN_10/  CPU:X64 OS:X64  Environment(Language:080A)  CodePage:0  utf8.auto.check:4
+>         SciTEDir => C:\Program Files (x86)\AutoIt3\SciTE   UserDir => C:\Users\fabri\AppData\Local\AutoIt v3\SciTE\AutoIt3Wrapper   SCITE_USERHOME => C:\Users\admin\AppData\Local\AutoIt v3\SciTE 
>Running AU3Check (3.3.14.5)  from:C:\Program Files (x86)\AutoIt3  input:C:\Github\proyect\Main.au3
!>15:27:17 AU3Check ended.rc:-1073740791
+>15:27:17 AutoIt3Wrapper Finished.
>Exit code: 0    Time: 9.868

Quote

Exit code -1073740791 or alternatively 0xC0000409, it is a Windows file system error. There are many possible causes.

Quote

winevt\Logs :

- <Event xmlns="http://schemas.microsoft.com/win/2004/08/events/event">
- <System>
  <Provider Name="Application Error" /> 
  <EventID Qualifiers="0">1000</EventID> 
  <Version>0</Version> 
  <Level>2</Level> 
  <Task>100</Task> 
  <Opcode>0</Opcode> 
  <Keywords>0x80000000000000</Keywords> 
  <TimeCreated SystemTime="2020-10-01T18:59:32.6848938Z" /> 
  <EventRecordID>71541104</EventRecordID> 
  <Correlation /> 
  <Execution ProcessID="0" ThreadID="0" /> 
  <Channel>Application</Channel> 
  <Security /> 
  </System>
- <EventData>
  <Data>au3check.exe</Data> 
  <Data>3.3.14.5</Data> 
  <Data>5aaa7202</Data> 
  <Data>au3check.exe</Data> 
  <Data>3.3.14.5</Data> 
  <Data>5aaa7202</Data> 
  <Data>c0000409</Data> 
  <Data>0000c26f</Data> 
  <Data>3ee8</Data> 
  <Data>01d69824fb902565</Data> 
  <Data>C:\Program Files (x86)\AutoIt3\au3check.exe</Data> 
  <Data>C:\Program Files (x86)\AutoIt3\au3check.exe</Data> 
  <Data>52692d24-6a56-4b7f-a73d-72e3b08a33d3</Data> 
  <Data /> 
  <Data /> 
  </EventData>
  </Event>

Example:

AU3Check fails.zip

[FrancoDM]

@Jos

[Jos]

Ok, So when we have more than 507 #include statements in the master script I see that au3check fails.
There will always be some limits to what utilities can do and this one is not the easiest to maintain.

so my first question would be: How realistic/real life is this number of include files usage?

Jos

[mLipok]

As an example/for comparition:

For now I have 200 include files in my projects.
And I hope to split some into separate files.

So maybe after next 2 year I will have 250.

EDIT: just as note...  I do not intend to further disturb in the finding solution of this problem, unless I am asked to assist.

Edited October 1, 2020 by mLipok

[Jos]

14 minutes ago, mLipok said:

For now I have 200 include files in my projects.

This is about using more than 500 #include statements in the master, not about the total nested included files!
In the attached example you can move block of include files from Main into one of the included files to make them nested and things will work fine.

Jos 

[Jos]

@FrancoDM,

It would be nice when you react with words and explain yourself in stead of "SAD" post reaction as there isn't much I can do with that.
When it is an easy fix, I am happy to do so, but I have honestly no clue were to start with this piece of code as I haven't developed it and my brainpower is way to limited to learn it. 
So we either tell everybody that au3check has a limit of 500 includes in the master and tell them to nest them or not to use au3check.

Jos

[mLipok]

4 minutes ago, Jos said:

So we either tell everybody that au3check has a limit of 500 includes in the master and tell them to nest them or not to use au3check.

I'm still working in background... will back to discurs.

[mLipok]

1 hour ago, Jos said:

This is about using more than 500 #include statements in the master, not about the total nested included files!
In the attached example you can move block of include files from Main into one of the included files to make them nested and things will work fine.

Jos 

If I understand you well .... you mean a situation which I attach as a Main.au3

In such case I still have:

Quote

>"Z:\AutoItPortable\App\SciTE\..\AutoIt3.exe" "Z:\AutoItPortable\App\SciTE\AutoIt3Wrapper\AutoIt3Wrapper.au3" /Prod /AU3check /in "C:\Users\agatk\Downloads\AU3Check fails\Main.au3"
+>23:56:17 Starting AutoIt3Wrapper (19.1127.1402.18) from:SciTE.exe (4.2.0.0)  Keyboard:00000415  OS:WIN_10/2004  CPU:X64 OS:X64  Environment(Language:0809)  CodePage:65001  utf8.auto.check:4
+>         SciTEDir => Z:\AutoItPortable\App\SciTE   UserDir => Z:\AutoItPortable\App\SciTE\AutoIt3Wrapper
>Running AU3Check (3.3.15.42)  params:-d -w 1 -w 2 -w 3 -w- 4 -w 5 -w 6 -w 7  from:Z:\AutoItPortable\App  input:C:\Users\agatk\Downloads\AU3Check fails\Main.au3
!>23:56:20 AU3Check ended.rc:-1073740791
+>23:56:20 AutoIt3Wrapper Finished.
>Exit code: 0    Time: 3.496

In my example the dependency look like...

REMARK:

the "INCLUCDE DEPENDENCY TREE" window is my separate project not included here in this topic .... (if somebody interested just click here.)

AU3Check fails.zip

Edited October 1, 2020 by mLipok
typo

[Jos]

@FrancoDM,

I see you simply went ahead AGAIN and posted a new bug report in TRACK https://www.autoitscript.com/trac/autoit/ticket/3785  , without first properly discussing the issue here!  ... and you call me impolite?

I also see that @jpm committed a "fix" for it, although that now maximizes the overall number of included files checked by au3check and stops reading them with a Error which means the whole Run/Compile process will stop, which doesn't seem the appropriate solution to me.....

>Running AU3Check (3.3.15.42)  from:C:\Program Files (x86)\AutoIt3\Beta  input:D:\AU3t\Main.au3
"D:\AU3t\Main.au3"(493,10) : error: too many includes.
#Include "Includes\549.au3"
~~~~~~~~~^
D:\AU3t\Main.au3 - 1 error(s), 0 warning(s)
!>12:41:08 AU3Check ended. Press F4 to jump to next error.rc:2
+>12:41:08 AutoIt3Wrapper Finished.
>Exit code: 2    Time: 2.038

EDIT: I think I tested the 500 incorrectly and it looks like it is indeed the total overall included files which is causing this issue. So I think we should end au3check with a warning saying it can't check the script due to this and make the process continue without stopping ( generating an Error).

Jos 

 

Edited October 2, 2020 by Jos

[Jos]

Ok, I spend some time to check and what actually was happening is that the Max OpenFile for windows was passed which would make it hard crash. Also the last commit was still hardcrashing.
So I have added a compile declare to the project to set this max open files to a value and then using the last commit's logic, check whether we surpass that nd lso set the max openfiles to the defined number.
In case we do get to the limit, I added an Exit(0), meaning au3check will exit with rc=0 and a warning stating:

!Reached Max Include Files (495) limit. Stop the process ending with rc=0
>Exit code: 0    Time: 0.2867

This will ensure the Run/Compile will continue.

The beta version is available here, so give it a spin. The max is now set to 1000 files.

Edited October 2, 2020 by Jos

[jpm]

Thanks Jos

I did a check with 1000 files.

I get

Quote

>"C:\Program Files (x86)\AutoIt3\SciTE\..\AutoIt3.exe" "C:\Program Files (x86)\AutoIt3\SciTE\AutoIt3Wrapper\AutoIt3Wrapper.au3" /run /beta /ErrorStdOut /in "F:\_NoSave\_Data\Jpm\Bureau\_TBD\_AutoIt\_Tickets\_Fixed\#3785 AU3check crash\Main.au3" /UserParams    
+>18:18:14 Starting AutoIt3Wrapper (19.1127.1402.18) from:SciTE.exe (4.2.0.0)  Keyboard:0000040C  OS:WIN_10/2004  CPU:X64 OS:X64  Environment(Language:040C)  CodePage:0  utf8.auto.check:4
+>         SciTEDir => C:\Program Files (x86)\AutoIt3\SciTE   UserDir => C:\Users\Jpm\AppData\Local\AutoIt v3\SciTE\AutoIt3Wrapper   SCITE_USERHOME => C:\Users\Jpm\AppData\Local\AutoIt v3\SciTE 
>Running AU3Check (3.3.15.43)  params:-q -d -w 1 -w 2 -w 3 -w- 4 -w 5 -w 6 -w 7  from:C:\Program Files (x86)\AutoIt3\Beta  input:F:\_NoSave\_Data\Jpm\Bureau\_TBD\_AutoIt\_Tickets\_Fixed\#3785 AU3check crash\Main.au3
!Reached Max Include Files (995) limit. Stop the process ending with rc=0
+>18:18:16 AU3Check ended.rc:0
>Running:(3.3.15.3):C:\Program Files (x86)\AutoIt3\Beta\autoit3.exe "F:\_NoSave\_Data\Jpm\Bureau\_TBD\_AutoIt\_Tickets\_Fixed\#3785 AU3check crash\Main.au3"    
+>Setting Hotkeys...--> Press Ctrl+Alt+Break to Restart or Ctrl+BREAK to Stop.
+>18:18:17 AutoIt3.exe ended.rc:0
+>18:18:17 AutoIt3Wrapper Finished.
>Exit code: 0    Time: 2.838
 

I think if Au3Check stop checking that mean some part o the script have not been checked so Au3check must return error

Cheers

Jpm

[Jos]

39 minutes ago, jpm said:

I think if Au3Check stop checking that mean some part o the script have not been checked so Au3check must return error

Sorry but have to disagree. I think when au3check cannot complete it's task, it should simply bail and not interfere with the rest of the process as, like in this case, the sources are correct as far as AutoIt3 is concerned.

I have kept a 5 OpenFile slots for other files like the main script so with our 1000 limit, we can have 995 include files.

Jos

Edited October 2, 2020 by Jos

[jpm]

so some part will not be checked but if they don't work the error will fired at exexution 

at least rc must be set to 1 as the doc is describing.

I am wondering if we need to introduce a -w  8 to produce a stronger error

Quote

doc info

-q : quiet (only error/warn output)
-d : as Opt("MustDeclareVars", 1)
-w 1: already included file (on)
-w 2: missing #comments-end (on)
-w 3: already declared var (off)
-w 4: local var used in global scope (off)
-w 5: local var declared but not used (off)
-w 6: warn when using Dim (off)
-w 7: warn when passing Const or expression on ByRef param(s) (on)
-I dir: additional directories for searching include files

-v 1: show include paths/files (off)
-v 2: show lexer tokens (off)
-v 3: show unreferenced UDFs and global variables (off)

Exit codes:

0: success: no errors or warnings
1: warning(s) only
2: syntax error(s)
3: usage or input error

 

[Jos]

There are no warnings as au3check was never able to do any real work (or only partial), hence I believe it should be totally discarded.

... but that is just my opinion so do we need a vote on this one as I really could care less what it is set to as I will never have this issue anyways?  

Edited October 2, 2020 by Jos

[jpm]

I don't need a vote

your feeling on au3check is the best

cheers

Jpm

[Jos]

@jpm,

I found a way to make it properly terminate lexing and finishing which means it will list any error/warning encountered till the point it hit the max open files and thus setting the return code as it would do before for the processed scriptlines.

File is uploaded.

Jos

Edited October 2, 2020 by Jos

[mLipok]

I have maybe a few or more questions.

Whether this limit (995 opened files) is native Windows limit for any windows APP ?
Whether Au3Check documentation should be suplemented ?
Whether this limit also fit to AutoIt FileOpen() function ?
Whether AutoIt documentation should be suplemented ?

Edited October 2, 2020 by mLipok

[Jos]

15 minutes ago, mLipok said:

Whether this limit (995 opened files) is native Windows limit for any windows APP ?

Windows default seems to be 512 max open files, but can be changed by means of a function call. I have set  it to 1000 for au3check for now.

16 minutes ago, mLipok said:

Whether Au3Check documentation should be suplemented ?

Feel free when anybody thinks this is of any interest ...  I remain of the opinion that this limit is bordering ridiculous .  

18 minutes ago, mLipok said:

Whether this limit also fit to AutoIt FileOpen() function ?

Didn't look whether Jon did anything with the mentioned default. which also answers your last message. 

 

[FrancoDM]

On 10/1/2020 at 5:13 PM, Jos said:

Ok, So when we have more than 507 #include statements in the master script I see that au3check fails.
There will always be some limits to what utilities can do and this one is not the easiest to maintain.

so my first question would be: How realistic/real life is this number of include files usage?

Jos

Then release the code so that those of us who really need it can do what we want with it.

PS: It is reality.

[FrancoDM]

8 hours ago, Jos said:

Ok, I spend some time to check and what actually was happening is that the Max OpenFile for windows was passed which would make it hard crash. Also the last commit was still hardcrashing.
So I have added a compile declare to the project to set this max open files to a value and then using the last commit's logic, check whether we surpass that nd lso set the max openfiles to the defined number.
In case we do get to the limit, I added an Exit(0), meaning au3check will exit with rc=0 and a warning stating:

!Reached Max Include Files (495) limit. Stop the process ending with rc=0
>Exit code: 0    Time: 0.2867

This will ensure the Run/Compile will continue.

The beta version is available here, so give it a spin. The max is now set to 1000 files.

"C:\Github\Main.au3"(26456,18) : error: Invalid Integer found larger than 9223372036854775807). Used value:9223372036854775807
While _IsPressed(01)
       

   $iCount += 1

      Sleep($DELAY)
    WEnd
 

Edited October 3, 2020 by FrancoDM