Cmd window of batch file not opening at all

[IcyCascades]

Posted a separate problem earlier but now I'm having another. One of the main purposes of the script I'm trying to create is to run a master batch file with a menu that will do various things.

I have this code in place, but it does not appear to be running the batch file or even opening a cmd window

Is there something that is being done wrong? (Yes I have installed the file)

 

[ModemJunki]

Is the batch file in a folder, or in the root of a drive?

The help for @ScriptDir says "Directory containing the running script. Only includes a trailing backslash when the script is located in the root of a drive."

[IcyCascades]

It's in the root of a drive

 

[TheXman]

First, please stop posting images of your code.  Post actual code snippets using the code tags "<>" in the editor's ribbon.  Using images makes it impossible to cut & paste text.

 

The destination of your FileInstall is :  @ScriptDir & "\" & $sFolder & "\Main.bat"

But you are trying to execute:         @ScriptDir & "\Main.bat"

Edited January 14, 2020 by TheXman

[Musashi]

1 hour ago, IcyCascades said:

I'm trying to create is to run a master batch file with a menu that will do various things.

In addition to the errors described above. Here is an example with a .cmd file (TestBatch.cmd) that contains a menu.

#include <File.au3>
Global $sFileTargetPath, $iFileInstall

$sFileTargetPath = @ScriptDir & "\TestBatch.cmd"
$iFileInstall = FileInstall ("TestBatch.cmd", $sFileTargetPath, $FC_OVERWRITE)
If $iFileInstall Then
    ConsoleWrite("+ @@DEBUG : FileInstall OK" & @CRLF) ; *** just for display
    Run(@ComSpec & ' /c "' & $sFileTargetPath & '"', "", @SW_SHOWMAXIMIZED)
Else
    ConsoleWrite("! @@DEBUG : FileInstall ERROR" & @CRLF) ; *** just for display
    Exit
EndIf

Keep in mind : "The source file must be specified using a string literal and can not be a variable, a macro, a calculation nor function call."

TestBatch.cmd

Edited January 14, 2020 by Musashi

[ModemJunki]

I forgot to post example of workaround for the @ScriptDir having backslash if root of drive.

I use this:

Global $s_LocDir = @ScriptDir
If StringRight($s_LocDir, 1) = "\" Then $s_LocDir = StringTrimRight($s_LocDir, 1) ; to assure the string never has "\" at the end

 

[Musashi]

15 minutes ago, ModemJunki said:

I use this:

To assure that there is no trailing backslash, better use  _WinAPI_PathRemoveBackslash  :

#include <WinAPIShPath.au3>
Global $g_sDir = 'C:\Temp\'
ConsoleWrite('$g_sDir 1. = ' & $g_sDir & @CRLF)
ConsoleWrite('$g_sDir 2. = ' & _WinAPI_PathRemoveBackslash($g_sDir) & @CRLF)

 

Edited January 15, 2020 by Musashi

[TheXman]

4 minutes ago, Musashi said:

To assure that there is no trailing backslash, better use  _WinAPI_PathRemoveBackslash

For the record the API used in _WINAPI_PathRemoveBackslash, PathRemoveBackslashW, has been deprecated.  PathCchRemoveBackslash or  PathCchRemoveBackslashEx, should be used in place of PathRemoveBackslashW to prevent the possibility of a buffer overrun.

[Musashi]

23 minutes ago, TheXman said:

For the record : the API used in _WINAPI_PathRemoveBackslash, PathRemoveBackslashW, has been deprecated.

Thanks for the info. The following can be found (as you have already written) in the Microsoft-Docs : "Note  This function is deprecated. We recommend the use of the PathCchRemoveBackslash or PathCchRemoveBackslashEx function in its place. "

The recent AutoIt Help, the History and the AutoIt Changelog do not mention it. Has this already been considered in the Beta ?

[Musashi]

@ModemJunki

Just to avoid confusion - there is nothing wrong with your code snippet .

As an alternative to _WinAPI_PathRemoveBackslash you could also use e.g. the following :

Global $g_sDir = "c:\Temp\SubDir\"
ConsoleWrite('Before = ' & $g_sDir & @CRLF)
ConsoleWrite('After  = ' & StringRegExpReplace($g_sDir, "\\$", "") & @CRLF)

Finally, however, these are only different solutions for the same thing.

[BrewManNH]

17 hours ago, Musashi said:

Just to avoid confusion

Having the doubled backslash in the path won't affect anything in Windows, as far as Windows is concerned C:\Temp and C:\\Temp are equivalent.

[Musashi]

17 minutes ago, BrewManNH said:

Having the doubled backslash in the path won't affect anything in Windows

The only point was to remove a backslash that might be present at the end of the path. For this purpose various (not all) options were offered in the contributions above.

 

[BrewManNH]

20 hours ago, TheXman said:

For the record the API used in _WINAPI_PathRemoveBackslash, PathRemoveBackslashW, has been deprecated.

Following the links you provided shows that the 2 substitute functions won't remove the trailing backslash if the path is the root of the directory.

Quote

This function will not remove the backslash from a root path string, such as "C:".

 

[TheXman]

1 minute ago, BrewManNH said:

Following the links you provided shows that the 2 substitute functions won't remove the trailing backslash if the path is the root of the directory.

Then take your complaint to Microsoft!

[BrewManNH]

1 minute ago, TheXman said:

Then take your complaint to Microsoft!

Where in that post did you manage to find a complaint? It was an expansion of the thread and a warning to not rely on it if the path is at the root.