Yet another ShellExecuteWait Question

[ambad4u]

Hello and Good Day to All!

I am trying to install .NET 3.5 on Windows 10 x64bit via autoit (via ShellExecuteWait + PowerShell).

If I run this line, it will runs without issues:

ShellExecuteWait('PowerShell.exe', '-executionpolicy Bypass -File "' & @ScriptDir & '\OJP83BU523.ps1' & '"')

"OJP83BU523.ps1" contains: DISM /Online /Enable-Feature /FeatureName:NetFX3 /All /Source:D:\Sources\sxs /LimitAccess

However, since I won't know in advance the drive letter of the "sources" folder, I created a script to generate a PowerShell Script to give a correct path for it.

With the modified script below, PowerShell only blinks and nothing happens

ShellExecuteWait('PowerShell.exe', '-executionpolicy Bypass -File "' & @ScriptDir & '\' & $filename & '"')

or

ShellExecuteWait('PowerShell.exe', '-executionpolicy Bypass -File "' & $filename & '"')

 

I wish I know the difference with "$filename" and "\OJP83BU523.ps1" usage, as for me, it should be the same.

Attached is my entire autoit script.

any help is appreciated!, many thanks in advance!

test.au3

[seadoggie01]

You left the handle to the file open without closing it. The easiest solution would be to ditch the FileOpen line.

FileOpen returns a handle to a file. FileWrite will put the data in the file, but it won't be able to be read until the file handle is closed with FileClose. Instead, you can directly open, write, and close the file all with FileWrite.

[ambad4u]

That makes sense, My apologies, let me check that one out.

[Subz]

Can you try

Local $hFilePath = FileOpen(@ScriptDir & "\" & $filename, 2)
    FileWrite($hFilePath, 'DISM /Online /Enable-Feature /FeatureName:NetFX3 /All /Source:' & $dDrive & 'Sources\sxs /LimitAccess')
    FileClose($hFilePath)

Or something like

RunWait(@ComSpec & ' /c DISM /Online /Enable-Feature /FeatureName:NetFX3 /All /Source:' & $dDrive & 'Sources\sxs /LimitAccess')

Or PowerShell -Command from cmd.

 

[Subz]

Also you could just use _TempFile function for creating a random file name.

[ambad4u]

@seadoggie01

Thank you for pointing out my issues with FileOpen/FileWrite..., it works now.

@Subz

Thank you for the heads-up on _TempFile

Also, I have settled with a long one liner you posted

RunWait(@ComSpec & ' /c DISM /Online /Enable-Feature /FeatureName:NetFX3 /All /Source:' & StringLeft(@ScriptDir, 3) & 'Sources\sxs /LimitAccess')