[SOLVED] A way to not end a script when "Subscript used on non-accessible variable" occurs?

[nooneclose]

Morning, I am wondering is there is a way to prevent a script from ending/crashing when a "Subscript used on non-accessible variable" error occurs? 

Here is some of my code:

$aItems = _OL_ItemFind($oOutlook, $mFolder[1], $olMail, "[UnRead]=True", "Subject", "Maintenance Request", "EntryID,Subject", "", 0)
    If @error Then
        Sleep(2000)
        LoopUnreadEmails()
        ;Exit MsgBox(48, "", "@error = " & @error & ", @extended: " & @extended & " at line: " & @ScriptLineNumber)
    EndIf

Error Msg:

(371) : ==> Subscript used on non-accessible variable.:
$aItems = _OL_ItemFind($oOutlook, $mFolder[1], $olMail, "[UnRead]=True", "Subject", "Maintenance Request", "EntryID,Subject", "", 0)
$aItems = _OL_ItemFind($oOutlook, $mFolder^ ERROR

I know that error occurs very rarely and at random. But like with most errors "in this case" I can use recursion to fix it. 

I just recall the function and it will and has fixed itself. But this "Subscript used on non-accessible variable" just ends the script.

Like I said before, is there a way to allow the script to keep running or call a function when this error occurs instead of just ending?   

Edited October 28, 2019 by nooneclose
problem solved to the best of our ability

[BrewManNH]

Do proper error checking before sending the array array to the function. Make sure that first it's an array, and second has the correct number of subscripts, then use the function with the array. Otherwise you're hiding an error that you won't know about and are just obfuscating improper error checking.

[nooneclose]

@BrewManNH Something like this?

Func ScanInvaildEmails()

    Local $mFolder = _OL_FolderAccess($oOutlook, "Inbox")
    If IsArray($mFolder) Then
        Local $iRows = UBound($mFolder, $UBOUND_ROWS)
        If $iRows >= 2 Then
            ; It worked, do nothing
        Else
            Sleep(2000)
            ScanInvaildEmails()
        EndIf
    Else
        Sleep(2000)
        ScanInvaildEmails()
    EndIf
    
EndFunc

 

Edited October 21, 2019 by nooneclose
Spacing in code bugged me

[BrewManNH]

No, you're using recursion where you shouldn't be. You can put the whole thing inside a loop and never call the same function over and over. You have no way to leave this either so it will continue to recurse until it errors out, if left running long enough. Here's the proper way to go about it without the recursion.

Func ScanInvaildEmails()
     While 1
          Local $mFolder = _OL_FolderAccess($oOutlook, "Inbox")
          If IsArray($mFolder) Then
               Local $iRows = UBound($mFolder, $UBOUND_ROWS)
               If $iRows >= 2 Then
                    ; It worked, do nothing
               Else
                    Sleep(2000)
;~                ScanInvaildEmails()
               EndIf
          Else
               Sleep(2000)
;~           ScanInvaildEmails()
          EndIf
     WEnd
EndFunc   ;==>ScanInvaildEmails

You'll just need someway to exit this loop, the same as with your script, it's an endless loop with no way to exit it.

[nooneclose]

I want it to exit if it is an array and if it does contain the correct number of subscripts. If it does not then I want it to try again because it should be.  

Func ScanInvaildEmails()
     While 1
          Local $mFolder = _OL_FolderAccess($oOutlook, "Inbox")
          If IsArray($mFolder) Then
               Local $iRows = UBound($mFolder, $UBOUND_ROWS)
               If $iRows >= 2 Then
                    ; It worked, Go to next function
                    ExitLoop 
               Else
                    Sleep(2000)
;~                ScanInvaildEmails()
               EndIf
          Else
               Sleep(2000)
;~           ScanInvaildEmails()
          EndIf
     WEnd
EndFunc   ;==>ScanInvaildEmails

This will try until its a proper Array with the correct subscripts and move on if I add Exitloop correct? 

[nooneclose]

@BrewManNH Some of my emails were processed more than once. (the same email 2-3 times)

could this code be the cause? (is it somehow adding the same email multiple times to the array?)

; Find all vaild E-mails in the inbox
    While 1
        $aItems = _OL_ItemFind($oOutlook, $mFolder[1], $olMail, "[UnRead]=True", "Subject", "Maintenance Request", "EntryID,Subject", "", 0)
        If IsArray($aItems) Then
            ; It worked, Exit loop
            ConsoleWrite(@CRLF & "Array created" & " at line: " & @ScriptLineNumber & @CRLF)
            Exitloop
        Else
            Sleep(2000)
            ConsoleWrite("Error: No Array created" & " at line: " & @ScriptLineNumber & @CRLF)
        EndIf
    WEnd

 

[genius257]

Hi @nooneclose.

You could use Execute.

Here's an example:

Global $aTest = ["a","b","c"]

MsgBox(0, "", Execute("$aTest[30]"))

 

[nooneclose]

@genius257 I do not understand what your code does or how it would help loop until an Array was successfully created. I have been using while loops they have worked very well so far. 

Edited October 28, 2019 by nooneclose
grammar

[water]

I assume you are trying to process new mails. In this case I suggest to use events. Means: A function in your script gets triggered as soon as a new mail arrives.
Please see the example scripts section in my signature.
Edit: Added an updated example fot the NewMailEx event today.

Edited October 28, 2019 by water

[genius257]

@nooneclose

Execute sets the @error flag to non zero on failure.

so:

While 1
    $value = Execute("$mFolder[1]")
    If @error <> 0 Then
        Sleep(1000)
        ContinueLoop
    EndIf
    $aItems = _OL_ItemFind($oOutlook, $mFolder[1], $olMail, "[UnRead]=True", "Subject", "Maintenance Request", "EntryID,Subject", "", 0)
WEnd

I assume you'll use @water's solution, but it's always good with options

[jchd]

Of course fixing the root cause of a potential error is much, really much better than trying to circumvent the consequences of an error.

The former is correct code, the latter is duck tape on a crack in a concrete wall.

[nooneclose]

12 hours ago, jchd said:

Of course fixing the root cause of a potential error is much, really much better than trying to circumvent the consequences of an error.

The former is correct code, the latter is duck tape on a crack in a concrete wall.

@jchd Which former code? Also, my script needs to runs 24/7. Hence the original reason why I created this thread. I needed a way to stop the script when stops on Autoit Errors. The only way I have found so far is by creating a disgusting amount of Error checking and if that does not work calling the function again (this eventually forces it to correct itself). I know that it is not a good practice to force code to work if it has problems. However, when you have to make it run 24/7 it's a bit different.      

[jchd]

"The former" refers to "fixing the root cause".

A software having to run reliably 24/7 is an imperative reason to code it robustly in the first place and catch all the potential errors and handle them gracefully.

[nooneclose]

6 minutes ago, jchd said:

"The former" refers to "fixing the root cause".

A software having to run reliably 24/7 is an imperative reason to code it robustly in the first place and catch all the potential errors and handle them gracefully.

Yes, I would love to program it that way. However, since I do not know all of Autoit syntax and functions it is harder for me to do so. Also with people who just comment without giving any real help just keep making it difficult to refine not just my code but for anyone who seeks help. I greatly appreciate the people who take time out of their day to help me. It is annoying though when some people comment for comment's sake.  Whether it was to argue or to actually help. If one wants to help but is not clear and or does not contribute to solving the problem then what's the point? I understand where you are coming from but unless you can show me examples or teach me how to do better how can I improve? 

[jchd]

34 minutes ago, nooneclose said:

how can I improve?

First by studying AutoIt syntax and functions you don't already know and master, at least the parts that relate to your goal (processing mails).
Then by following advices that were given by @BrewManNH and @water.

I was just stressing that the more important a software is in practice the more care must be devoted to its conception.

[Earthshine]

I guess you need to learn Autoit And I suggest reading the users manual for anything you “don’t know”

 

We’re not here for you to order up code from we are here to assist you with the code you’ve written

 

Giving you code isn’t helping you it’s holding you back

Edited October 30, 2019 by Earthshine