Help with if condition is not met then restart loop

[ags911]

Hi, I was wondering how I could restart a loop if a condition is not met in a script. Do I use variables for each step or what? For example I am using image search and I would like to restart the script from Step 1 if $result = 0 (1 means a matching image has been found and it can proceed). As it stands the script just closes if it cannot find the next picture. Here is my code:

expandcollapse popup

Func _TogglePause()
   ToolTip('Script has started. Press SHIFT+1 to pause or SHIFT+2 to terminate.',0,0)
   $UnPausedNormal = NOT $UnPausedNormal

While $UnPausedNormal   ; Loop 2 (Normal)

; Timing (add for each action)

;For $y = 1 To 1800 ; Completed $x loops. Loops script 10 times x the amount here which is 1800

;For $x = 1 To 10 ; Loops script 10 times (around 35-40 seconds for normal speed)

ToolTip("1 - Step 1")

;Variable shortcut

$Step1

$x1=0
$y1=0

$picture = "1 - Step 1.bmp"
   $result = _ImageSearch($picture,1,$x1,$y1,0,0)
   ;_ImageSearch($findimage, $resultPosition, ByRef $x, ByRef $y, $tolorance, $tramsparency = 0)

   ConsoleWrite($result)
If $result = 1 Then

   MouseMove($x1, $y1, 1)
   MouseClick("Left")

ElseIf $result = 0 Then
   MsgBox($MB_OK, "Error", "Button not found.")
   EndIf

If NOT $UnPausedNormal Then ExitLoop
Sleep(1000)

ToolTip("2 - Step 2")

$x1=0
$y1=0

$picture = "2 - Step 2.bmp"
   $result = _ImageSearch($picture,1,$x1,$y1,0,0)
   ;_ImageSearch($findimage, $resultPosition, ByRef $x, ByRef $y, $tolorance, $tramsparency = 0)

   ConsoleWrite($result)
If $result = 1 Then

   MouseMove($x1, $y1, 0)
   MouseClick("Left")

    ElseIf $result = 0 Then Next
   EndIf

If NOT $UnPausedNormal Then ExitLoop
Sleep(1000)

ToolTip("3 - Step 3")

$x1=0
$y1=0

$picture = "3 - Step 3.bmp"

   $result = _ImageSearch($picture,1,$x1,$y1,0,0)
   ;_ImageSearch($findimage, $resultPosition, ByRef $x, ByRef $y, $tolorance, $tramsparency = 0)

   ConsoleWrite($result)
if $result = 1 Then

   MouseMove($x1, $y1, 0)
   MouseClick("Left")

ElseIf $result = 0 Then
   EndIf

If NOT $UnPausedNormal Then ExitLoop
Sleep(1000)

ToolTip("4 - Step 4")

$x1=0
$y1=0

$picture = "4 - Step 4.bmp"
   $result = _ImageSearch($picture,1,$x1,$y1,0,0)
   ;_ImageSearch($findimage, $resultPosition, ByRef $x, ByRef $y, $tolorance, $tramsparency = 0)

   ConsoleWrite($result)
$result = 1;
If $result = 1 Then

   MouseMove($x1, $y1, 0)
   MouseClick("Left")

    ElseIf $result = 0 Then
   EndIf

If NOT $UnPausedNormal Then ExitLoop
Sleep(1000)

ToolTip("5 - Step 5")

$x1=0
$y1=0

$picture = "5 - Step 5.bmp"
   $result = _ImageSearch($picture,1,$x1,$y1,0,0)
   ;_ImageSearch($findimage, $resultPosition, ByRef $x, ByRef $y, $tolorance, $tramsparency = 0)

   ConsoleWrite($result)
$result = 1;
If $result = 1 Then

   MouseMove($x1, $y1, 0)
   MouseClick("Left")

    ElseIf $result = 0 Then
   EndIf


If NOT $UnPausedNormal Then ExitLoop

Sleep(50)

WEnd
EndFunc

 

Edited October 1, 2019 by JLogan3o13

[bailey1274]

One way to accomplish this would be recursion. Here is a small sample about how to go upon it.

Quote

Recurse()

Local $counter, $retval

Func Recurse()
    $counter = 0
    For $i=0 to 100
        $counter += 1
        $retval = MsgBox(3, 'Recurse?','Start Function over?'&@CRLF&'Counter = '&$counter)
        If $retval = 6 Then
            Recurse()
        ElseIf $retval = 7 Then
            ContinueLoop
        Else
            Exit
        EndIf
    Next
EndFunc

But be careful as you can easily create infinite loops if you don't scope variables correctly. Also using the code input tool here on the forums always helps readability. 

[ags911]

41 minutes ago, bailey1274 said:

One way to accomplish this would be recursion. Here is a small sample about how to go upon it.

But be careful as you can easily create infinite loops if you don't scope variables correctly. Also using the code input tool here on the forums always helps readability. 

Thanks for the swift reply. I am not sure what you posted, is that the solution or do I add something similar at the end of the code before or after WEnd but that looks like 2 variables? Sorry I'm a newbie lol.

[JLogan3o13]

@ags911 What are you waiting for in your $UnpausedNormal call? There are usually much easier ways to accomplish your goals rather than resorting to pixel or image searches.

 

[ags911]

9 minutes ago, JLogan3o13 said:

@ags911 What are you waiting for in your $UnpausedNormal call? There are usually much easier ways to accomplish your goals rather than resorting to pixel or image searches.

 

I'm using that call to pause the script and reference it after each step because it will stop the instant it is paused instead of going through every single step then pausing at step 5.

 

Edited October 1, 2019 by ags911

[ags911]

I am using image search because it is the easiest way for me. I cannot use ID selectors in Google Chrome as it requires a lot more work and I do not have the skill to do it unfortunately.

[dopeness]

You can use ContinueLoop in the if statement checking if it's found or not.

 

ElseIf $result = 0 Then

MsgBox($MB_OK, "Error", "Button not found.")  

;continueloophere

continueLoop

End If

[ags911]

15 hours ago, dopeness said:

You can use ContinueLoop in the if statement checking if it's found or not.

 

ElseIf $result = 0 Then

MsgBox($MB_OK, "Error", "Button not found.")  

;continueloophere

continueLoop

End If

Thanks but that didn't work. For example, I would like that it would execute step one and show that error message but then go back to a paused state after. Next, if it finds the image in step 1 then it moves on to step 2 but in step 2 if it doesn't find an image it will revert to step 1. The same actions will be taken regardless of being step 2 or step 5 so it will always go back to step 1.

[Sidley]

You could use a flag:

Local $Flag = False
Local $Something

While Not $Flag
    ;Check something
    If $Something Then          ;If you get a result
                                ;Do stuff
        $Flag = True            ;Change the flag
    ElseIf Not $Something Then  ;Otherwise
                                ;Continue in while loop
    EndIf
WEnd

 

[ags911]

3 hours ago, Sidley said:

You could use a flag:

Local $Flag = False
Local $Something

While Not $Flag
    ;Check something
    If $Something Then          ;If you get a result
                                ;Do stuff
        $Flag = True            ;Change the flag
    ElseIf Not $Something Then  ;Otherwise
                                ;Continue in while loop
    EndIf
WEnd

 

I've tried but it doesn't work. It says unable to parse line.

Edited October 2, 2019 by ags911