Syntax error when converting conditions to variables?

[plankton]

Func Termination()
$condition1 = If (PixelGetColor(362, 567) == 0xBBBBBB) and (PixelGetColor(362, 573) == 0xBBBBBB)
$condition2 = If Not IsArray(PixelSearch(366,566, 380,574, 0xFFFFFF))

If $condition1 and $condition2 == True Then
MsgBox(0, "Warning", "Closing the program", 0)
Exit 0

Endif
Endfunc

I have been trying to execute the function when 3 conditions are met, but It failed, so I try to assign them with variables, which also gives syntax error.

 

[mLipok]

Did you try this way:

Func Termination()
    Local $condition1 = (PixelGetColor(362, 567) == 0xBBBBBB and (PixelGetColor(362, 573) == 0xBBBBBB))
    Local $condition2 = ( Not IsArray(PixelSearch(366,566, 380,574, 0xFFFFFF)))

    If ($condition1 and $condition2 ) Then
        MsgBox(0, "Warning", "Closing the program", 0)
        Exit 0
    Endif
Endfunc

?

[mistersquirrle]

Hello plankton,

First, your syntax for $condition1 and $condition2 is incorrect, check out mLipoks code for the correct syntax. You cannot have an 'If' without a 'Then', and you cannot use If...Then as a variable value. If you want to use a If/Then statement directly with a variable, you could do something like this (using ternary operators )

$condition1 = PixelGetColor(362, 567) == 0xBBBBBB ? true : false

However it would be much more preferable to do it this way (in terms of readability, and avoiding mistakes):

;Method 1
If PixelGetColor(362, 567) == 0xBBBBBB Then
    $condition1 = True
Else
    $condition1 = False
EndIf

;Method 2
$condition1 = False
If PixelGetColor(362, 567) == 0xBBBBBB Then
    $condition1 = True
EndIf

 

This being said, your comparisons are not correct. You're checking if PixelGetColor is exactly equal to a hex code, which it will never be, as the return is decimal: https://www.autoitscript.com/autoit3/docs/functions/PixelGetColor.htm

For example, on my monitor right now, PixelGetColor(362, 567) == 15791353. So if I try this:

$condition1 = 'Not True or False'
If PixelGetColor(362, 567) == 15791353 Then
    $condition1 = True
Else
    $condition1 = False
EndIf
ConsoleWrite($condition1 & @CRLF) ; Outputs 'True' as PixelGetColor == 15791353

$condition1 = 'Not True or False'
If Hex(PixelGetColor(362, 567), 6) == 'F0F4F9' Then
    $condition1 = True
Else
    $condition1 = False
EndIf
ConsoleWrite($condition1 & @CRLF) ; Outputs 'True' as Hex(PixelGetColor) converts the Decimal output (15791353) to a Hex string

Ideally you probably want your statement to look something like this:

If Hex(PixelGetColor(362, 567), 6) == 'BBBBBB' And _
        Hex(PixelGetColor(362, 573, 6)) == 'BBBBBB' And _
        Not IsArray(PixelSearch(366, 566, 380, 574, 0xFFFFFF)) Then
    ;Do the thing
EndIf

 

Make sure that you're checking the functions against the correct return values.

Edited September 17, 2019 by mistersquirrle

[plankton]

On 9/17/2019 at 3:07 PM, mistersquirrle said:

Hello plankton,

First, your syntax for $condition1 and $condition2 is incorrect, check out mLipoks code for the correct syntax. You cannot have an 'If' without a 'Then', and you cannot use If...Then as a variable value. If you want to use a If/Then statement directly with a variable, you could do something like this (using ternary operators )

$condition1 = PixelGetColor(362, 567) == 0xBBBBBB ? true : false

However it would be much more preferable to do it this way (in terms of readability, and avoiding mistakes):

;Method 1
If PixelGetColor(362, 567) == 0xBBBBBB Then
    $condition1 = True
Else
    $condition1 = False
EndIf

;Method 2
$condition1 = False
If PixelGetColor(362, 567) == 0xBBBBBB Then
    $condition1 = True
EndIf

 

This being said, your comparisons are not correct. You're checking if PixelGetColor is exactly equal to a hex code, which it will never be, as the return is decimal: https://www.autoitscript.com/autoit3/docs/functions/PixelGetColor.htm

For example, on my monitor right now, PixelGetColor(362, 567) == 15791353. So if I try this:

$condition1 = 'Not True or False'
If PixelGetColor(362, 567) == 15791353 Then
    $condition1 = True
Else
    $condition1 = False
EndIf
ConsoleWrite($condition1 & @CRLF) ; Outputs 'True' as PixelGetColor == 15791353

$condition1 = 'Not True or False'
If Hex(PixelGetColor(362, 567), 6) == 'F0F4F9' Then
    $condition1 = True
Else
    $condition1 = False
EndIf
ConsoleWrite($condition1 & @CRLF) ; Outputs 'True' as Hex(PixelGetColor) converts the Decimal output (15791353) to a Hex string

Ideally you probably want your statement to look something like this:

If Hex(PixelGetColor(362, 567), 6) == 'BBBBBB' And _
        Hex(PixelGetColor(362, 573, 6)) == 'BBBBBB' And _
        Not IsArray(PixelSearch(366, 566, 380, 574, 0xFFFFFF)) Then
    ;Do the thing
EndIf

 

Make sure that you're checking the functions against the correct return values.

Thank you very much for the examples. This works 100%. as I wanted.