Script ends early

[Guest]

Hi all, my scripts have been working for the past year or two, but after some updates (windows/autoit) one of my scripts just seems to end before it actually does any work. I searched around and have tried a few things but nothing has helped.

I tried the tray debug and it didn't show anything. The script ends with exit code 0. I tried some error checks, but they didn't report anything.

Basically my script reads from my excel file, stores every cell in a variable, and then starts calling functions. Excel opens fine, but after about 10 seconds the script just exits. Any help is appreciated.

 

[Guest]

#include <Excel.au3>
#include <MsgBoxConstants.au3>

HotKeySet ("{ESC}", "Stop")
Global $1Excel = _Excel_Open()
Global $1Workbook = "\\x\Clinic-New.xlsx"
Global $2Workbook = _Excel_BookOpen($1Excel, $1Workbook)

Global $ResultCM = _Excel_RangeRead($2Workbook, Default, "A2") ;ParentCM
Global $ResultStartDate = _Excel_RangeRead($2Workbook, Default, "C2") ;Onboarding Start Date

 

[JLogan3o13]

@Xeiruz Welcome to the forum. Your script has 0 error checking. You need to check for an error at each line, so you know where it is failing. Look in the help file for each of those Excel functions; the given example includes error checking.

[Guest]

Ok, I've added it to every step and nothing it popping up, it simply ends the script.

 

#include <Excel.au3>
#include <MsgBoxConstants.au3>

HotKeySet ("{ESC}", "Stop")
Global $1Excel = _Excel_Open()
If @error Then Exit MsgBox($MB_SYSTEMMODAL, @ScriptName, "Error creating the Excel application object." & @CRLF & "@error = " & @error & ", @extended = " & @extended)

Global $1Workbook = "\\x\x\Clinic-New.xlsx"
If @error Then Exit MsgBox($MB_SYSTEMMODAL, @ScriptName, "Error connecting to spreadsheet on network." & @CRLF & "@error = " & @error & ", @extended = " & @extended)

Global $2Workbook = _Excel_BookOpen($1Excel, $1Workbook)
If @error Then Exit MsgBox($MB_SYSTEMMODAL, @ScriptName, "Error opening excel workbook2." & @CRLF & "@error = " & @error & ", @extended = " & @extended)

Global $ResultCM = _Excel_RangeRead($2Workbook, Default, "A2") ;ParentCM
If @error Then Exit MsgBox($MB_SYSTEMMODAL, @ScriptName, "Error reading A2." & @CRLF & "@error = " & @error & ", @extended = " & @extended)

 

[Guest]

When I extract the code with no functions and run it all at once, it seems to work, but once it's in the larger script it times out after reading excel.

This is the func in the main script

Func ParentCM()
Sleep (5000)
WinActivate ("CA Service")
Sleep (1000)
ControlClick ("CA Service Desk Manager", "", "Internet Explorer_Server1", "left", 2, 850, 35)

This is what I actually run

#include <Global.au3>

Call ("ParentCM")

 

[Guest]

So I keep messing with it and it really seems like it's not able to call the func, but it never gives an error??

I'm at a loss, how do you error check a function call other than just putting it in/after the function?

 

#include <Global.au3>
If @error Then Exit MsgBox($MB_SYSTEMMODAL, @ScriptName, "Error reading global file." & @CRLF & "@error = " & @error & ", @extended = " & @extended)
Call ("ParentCM")
If @error Then Exit MsgBox($MB_SYSTEMMODAL, @ScriptName, "Error calling func." & @CRLF & "@error = " & @error & ", @extended = " & @extended)

 

[careca]

Instead of "call", why not just

ParentCM()

?

Anyway, that code doesn't mean the function is not being called, i mean, it jumps to the function and only executes the next line, after it leaves the function, so put checks inside the function, because if there's a problem that crashes it, it will never get to the msgbox.

Edited October 8, 2018 by careca

[Guest]

@careca yeah I figured the error check after wouldn't help. I didn't realize you didn't need "call", so that's removed, no change though.

I had an error check as the first like in the func itself, but also added it to the first few rows, and it never gets anywhere. It doesn't focus the window or anything.

It still just ends after about 10 seconds. It opens the excel file, but nothing else.

#include <Global.au3>
If @error Then Exit MsgBox($MB_SYSTEMMODAL, @ScriptName, "Error reading global file." & @CRLF & "@error = " & @error & ", @extended = " & @extended)
ParentCM()

Func ParentCM()
If @error Then Exit MsgBox($MB_SYSTEMMODAL, @ScriptName, "Error running ParentCM." & @CRLF & "@error = " & @error & ", @extended = " & @extended)
Sleep (5000)
If @error Then Exit MsgBox($MB_SYSTEMMODAL, @ScriptName, "Error running ParentCM." & @CRLF & "@error = " & @error & ", @extended = " & @extended)
WinActivate ("CA Service")
If @error Then Exit MsgBox($MB_SYSTEMMODAL, @ScriptName, "Error running ParentCM." & @CRLF & "@error = " & @error & ", @extended = " & @extended)
Sleep (1000)
If @error Then Exit MsgBox($MB_SYSTEMMODAL, @ScriptName, "Error running ParentCM." & @CRLF & "@error = " & @error & ", @extended = " & @extended)
ControlClick ("CA Service Desk Manager", "", "Internet Explorer_Server1", "left", 2, 850, 35)
If @error Then Exit MsgBox($MB_SYSTEMMODAL, @ScriptName, "Error running ParentCM." & @CRLF & "@error = " & @error & ", @extended = " & @extended)
EndFunc

 

[careca]

What about this?

Func ParentCM()
$WW = WinWait("CA Service", '', 5)
If $WW <> 0 Then
$WA = WinActivate ("CA Service")
If $WA <> 0 Then
Sleep (1000)
ControlClick ("CA Service Desk Manager", "", "Internet Explorer_Server1", "left", 2, 850, 35)
Else
MsgBox(64, 'Fail', 'Did not activate window')
exit
EndIf
Else
MsgBox(64, 'Fail', 'Did not detect window')
exit
EndIf
EndFunc

The problem with

If @error Then Exit MsgBox($MB_SYSTEMMODAL, @ScriptName, "Error running ParentCM." & @CRLF & "@error = " & @error & ", @extended = " & @extended)

Is that, from my understanding, you exit, and then call the msgbox, well, if you exit, how is the box supposed to appear? Or am i thinking wrong about this?

[Guest]

Well that exit/msg is how it's displayed in the help file example, so I don't think that's an issue.

I tried with yours and it doesn't do anything either. Honestly, it seems like it's killing the script before it makes it to the function call.

It opens the excel, but nothing after that.

[JLogan3o13]

8 minutes ago, careca said:

Or am i thinking wrong about this?

You are

Exit MsgBox(0, "", "OMG an exit error!")

 

Edited October 8, 2018 by JLogan3o13

[BrewManNH]

Would it be possible to post a runnable script so that we can see what you're doing? These bits and pieces are doing nothing to help anyone in figuring out what's going wrong. Not to mention, your last post with code makes no sense whatsoever. None of that s even remotely close to what you're saying is happening, mainly because there's no Excel functions in it, and you're using ControlClick to click on something but we have no idea what that something is.

Make sure the script you post is complete, not a tiny portion of it that doesn't do anything that you say isn't working. Also, a sample of any files that you're accessing would be helpful as well.

 

[Guest]

Yeah sorry for the confusion.
I haven't had to ask for help before so I wasn't really sure how to present the info to someone other than myself.

You asking for the full script (about 1k lines) helped!
I found an unclosed function on the veeery last line, that wasn't throwing an error because it wasn't being called.

Took about 5 hours to find that and I feel real dumb.
Thanks for making me dig through the code!

[careca]

36 minutes ago, Xeiruz said:

I found an unclosed function on the veeery last line, that wasn't throwing an error because it wasn't being called.

? SciTe tells me right away if there's a problem like that. Yours didn't? How weird

[BrewManNH]

1 hour ago, Xeiruz said:

I found an unclosed function on the veeery last line, that wasn't throwing an error because it wasn't being called.

You should run Au3Check on all of your scripts, and that would make it easier to find these types of issues. 

[Jos]

9 hours ago, BrewManNH said:

You should run Au3Check on all of your scripts, and that would make it easier to find these types of issues. 

...which is automatically  done when you install the separate full version of SciTE4AutoIt3.

Jos

[careca]

What makes me wonder, is there a reason why the full version is not installed/included in AutoIt?

[Jos]

As it is considered not as a core item and people should be able to choose their editor of choice.

I solely maintain the SciTE4AutoIt installer and only the SciTE source is part of the shared SVN, all other sources of the compiled programs (tidy,au3stripper) aren't shared.

Jos

[Guest]

Though I've been using Autoit for years, I still don't know a lot.
I didn't even realize there was a more in-depth editor. I'll definitely be installing that today.

Thanks for being so helpful guys.