Object Collection Redim Slow

[autoitxp]

Although this function works correctly but bit slower may b bec of Redim any other way to do which is faster. 

Fetching more than 500 Schedule task in specified folder .

 

expandcollapse popup

#include <Array.au3>
Global $g_eventerror = 0 
Global $oMyError = ObjEvent("AutoIt.Error", "_MyErrFunc")
Global $err
Global $GetFP
Global $GFolder
Global $GFS
Global $GF
Global $GFL[0]
Global $strerrors = 0
Global $ObjSS

_ArrayDisplay(_STF())

Func _STF()
    $ObjSS = ObjCreate("Schedule.Service")
    $ObjSS.Connect()
    $GetFP = "\Microsoft\Windows"
    If $GetFP = "\" Then $GetFP = ""
    $GFolder = $ObjSS.GetFolder($GetFP)
    $GFS = $GFolder.GetFolders(0)
    For $GF In $GFS
        $strerrors += 1
        ReDim $GFL[$strerrors + 1]
        $GFL[$strerrors] = $GetFP & "\" & $GF.Name
    Next
    If $g_eventerror Then
        $g_eventerror = 0
        Return SetError(@error)
    EndIf
    Return $GFL
EndFunc   ;==>_STF



Func _MyErrFunc($oMyError)
    ConsoleWrite(@LF & "---------------------------------------------------------------------" & @LF & _
            " Source: " & $oMyError.source & @LF & _
            " Description: " & $oMyError.description & @LF & _
            " Windescription: " & $oMyError.windescription & @LF & _
            " Number: " & $oMyError.number & @LF & _
            " Retcode: " & $oMyError.retcode & @LF & _
            " Scriptline: " & $oMyError.scriptline & @LF & _
            " Helpfile: " & $oMyError.helpfile & @LF & _
            " Helpcontext: " & $oMyError.helpcontext & @LF & _
            " Lastdllerror: " & $oMyError.lastdllerror & @LF & _
            "---------------------------------------------------------------------" & @LF)

    $err = $oMyError.number
    If $err = 0 Then $err = -1
    $g_eventerror = $err ; to check for after this function returns
EndFunc   ;==>_MyErrFunc

 

 

Edited October 4, 2018 by autoitxp

[FrancescoDiMuro]

@autoitxp

Have you already tried _ArrayAdd() ?

[autoitxp]

_ArrayAdd()  work with object collection?  than gr8 i will try 

[BrewManNH]

_ArrayAdd uses ReDim, so not sure you'll gain anything by using it.

[BrewManNH]

Here's a way to do it using only one Redim, as long as there aren't going to be more than 10000 items added to the array, it should work the same.

expandcollapse popup

#include <Array.au3>
Global $g_eventerror = 0
Global $oMyError = ObjEvent("AutoIt.Error", "_MyErrFunc")
Global $err
Global $GetFP
Global $GFolder
Global $GFS
Global $GF
Global $GFL[10000]
Global $strerrors = 0
Global $ObjSS

_ArrayDisplay(_STF())

Func _STF()
;~     Redim $GFL[10000] ; only use this line if you don't set the size above
    $ObjSS = ObjCreate("Schedule.Service")
    $ObjSS.Connect()
    $GetFP = "\Microsoft\Windows"
    If $GetFP = "\" Then $GetFP = ""
    $GFolder = $ObjSS.GetFolder($GetFP)
    $GFS = $GFolder.GetFolders(0)
    For $GF In $GFS
;~      $strerrors += 1 ; if this is uncommented, then there will be nothing in the zero element of the array, make sure if you do uncomment it, to comment the identical line below or it will not work right.
;~      ReDim $GFL[$strerrors + 1]
        $GFL[$strerrors] = $GetFP & "\" & $GF.Name
        $strerrors += 1 ; this ensures that the zero element of the array holds the first object
    Next
    ReDim $gfl[$strerrors] ; add 1 to this redim if you use the $strerrors +=1 before adding items to the array
    If $g_eventerror Then
        $g_eventerror = 0
        Return SetError(@error)
    EndIf
    Return $GFL
EndFunc   ;==>_STF



Func _MyErrFunc($oMyError)
    ConsoleWrite(@LF & "---------------------------------------------------------------------" & @LF & _
            " Source: " & $oMyError.source & @LF & _
            " Description: " & $oMyError.description & @LF & _
            " Windescription: " & $oMyError.windescription & @LF & _
            " Number: " & $oMyError.number & @LF & _
            " Retcode: " & $oMyError.retcode & @LF & _
            " Scriptline: " & $oMyError.scriptline & @LF & _
            " Helpfile: " & $oMyError.helpfile & @LF & _
            " Helpcontext: " & $oMyError.helpcontext & @LF & _
            " Lastdllerror: " & $oMyError.lastdllerror & @LF & _
            "---------------------------------------------------------------------" & @LF)

    $err = $oMyError.number
    If $err = 0 Then $err = -1
    $g_eventerror = $err ; to check for after this function returns
EndFunc   ;==>_MyErrFunc

 

[mLipok]

quick look here

https://docs.microsoft.com/en-us/windows/desktop/taskschd/taskfolder-getfolders
https://docs.microsoft.com/en-us/windows/desktop/taskschd/taskfoldercollection
https://docs.microsoft.com/en-us/windows/desktop/taskschd/taskfoldercollection-count
https://docs.microsoft.com/en-us/windows/desktop/taskschd/taskfoldercollection-item

and you can try to use this not tested concept:

 

Local $GFS = $GFolder.GetFolders(0)
ReDim $GFL[$GFS.count]
For $iItem_idx =0 To $GFS.count
; For $iItem_idx =0 To $GFS.count -1 ; I'm not sure
    $GFL[$iItem_idx] $GFS.Item($iItem_idx)
Next

 

Edited October 4, 2018 by mLipok

[autoitxp]

im getting error array variable has incorrect number of subscripts .....

Func _STF()
    $ObjSS = ObjCreate("Schedule.Service")
    $ObjSS.Connect()
    $GetFP = "\Microsoft\Windows"
    If $GetFP = "\" Then $GetFP = ""
    $GFolder = $ObjSS.GetFolder($GetFP)
    $GFS = $GFolder.GetFolders(0)
    ReDim $GFL[$GFS.Count]
    For $GF In $GFS
        $GFL[$strerrors] = $GetFP & "\" & $GF.Name
        $strerrors += 1
    Next
    If $g_eventerror Then
        $g_eventerror = 0
        Return SetError(@error)
    EndIf
    Return $GFL
EndFunc   ;==>_STF

on other hand im not getting  $GFS.Name getting unknown name error  ?

Func _STF()

$ObjSS = ObjCreate("Schedule.Service")
    $ObjSS.Connect()
    $GetFP = "\Microsoft\Windows"
    If $GetFP = "\" Then $GetFP = ""
    $GFolder = $ObjSS.GetFolder($GetFP)
    $GFS = $GFolder.GetFolders(0)
    ReDim $GFL[$GFS.Count]
    For $i = 0 To $GFS.Count - 1
        $GFL[$i] = $GetFP & "\" & $GFS.Name
    Next
    If $g_eventerror Then
        $g_eventerror = 0
        Return SetError(@error)
    EndIf
    Return $GFL

EndFunc  ;==>_STF

 

Edited October 5, 2018 by autoitxp

[autoitxp]

@BrewManNH i'm getting error after compiling trace back line For $GF In $GFS But when run as normal in Scite works fine after compiling getting below error 

Error:Array variable has incorrect number of subscripts or subscript dimension range exceeded.

 

Global $GFL[10000]

Func _STF()
    $ObjSS = ObjCreate("Schedule.Service")
    $ObjSS.Connect()
    $GetFP = "\Microsoft\Windows"
    If $GetFP = "\" Then $GetFP = ""
    $GFolder = $ObjSS.GetFolder($GetFP)
    $GFS = $GFolder.GetFolders(0)
    For $GF In $GFS
        $strerrors += 1
        $GFL[$strerrors] = $GetFP & "\" & $GF.Name
    Next
    ReDim $GFL[$strerrors + 1]
    If $g_eventerror Then
        $g_eventerror = 0
        Return SetError(@error)
    EndIf
    Return $GFL
EndFunc   ;==>_STF

 

 

Edited October 5, 2018 by autoitxp

[BrewManNH]

Try to see what $seterrors value is when it errors out. If you run this function numerous times, you should reset $seterrors to zero when exiting the function, or make it a local variable inside the function.

Also, if you're not using the array $GFL anywhere other than in this function, make that a local variable also.

[autoitxp]

@BrewManNH thanks resting $strerrors= 0 works