Increment line for file reading problem

[LHCompter]

Any idea why it does not read next line on EGL.LIST file ? :/ 


Ex : 

 

#include <file.au3>

;Local For Looper Increment Function
$lineset = 1
$n = 1

;Locals for email list
$LEGL = "EGL.LIST" ;EGL ( EMAIL GENERATOR LIST | LEGL LOCATION EMAIL GENERATOR LIST)
;Open File And Read It
Local $hLEGL = FileOpen ($LEGL, $FO_READ) ;hLEGL variable to setup external file reading
;Read File
Local $EGLL = FileReadLine($hLEGL,$lineset)

Call("increment")
 

func increment()
   While $n = 1
   $lineset = $lineset + 1
;Debuger
MsgBox($MB_SYSTEMMODAL, "", "EGL LINE : " & @CRLF & $EGLL) ; EGL1 EMAIL GENERATOR LIST LINE
MsgBox($MB_SYSTEMMODAL, "", "Line: "  & @CRLF & $lineset) ; Line Set = value of line reader
WEnd

Edited August 21, 2018 by LHCompter

[careca]

You dont have the line that reads in the loop..

#include <file.au3>
;Local For Looper Increment Function
$lineset = 1
$n = 1
;Locals for email list
$LEGL = "EGL.LIST" ;EGL ( EMAIL GENERATOR LIST | LEGL LOCATION EMAIL GENERATOR LIST)
;Open File And Read It
Local $hLEGL = FileOpen ($LEGL, $FO_READ) ;hLEGL variable to setup external file reading
;Read File
Local $EGLL = FileReadLine($hLEGL,$lineset)

Call("increment")

func increment()
While $n = 1
$lineset = $lineset + 1
;Debuger
$EGLL = FileReadLine($hLEGL,$lineset) ;<<<<<<<<<<<<<<
MsgBox($MB_SYSTEMMODAL, "", "EGL LINE : " & @CRLF & $EGLL) ; EGL1 EMAIL GENERATOR LIST LINE
MsgBox($MB_SYSTEMMODAL, "", "Line: "  & @CRLF & $lineset) ; Line Set = value of line reader
WEnd
EndFunc

A better way to do this would be to count the lines and do a "for" loop to the count number.

[LHCompter]

God damn,thanks bro,you just saved my life 

Edited August 21, 2018 by LHCompter

[careca]

In case u're interested in what i meant:

 

#include <file.au3>

;Local For Looper Increment Function
$lineset = 1
$n = 1
;Locals for email list
$LEGL = "EGL.LIST" ;EGL ( EMAIL GENERATOR LIST | LEGL LOCATION EMAIL GENERATOR LIST)
;Open File And Read It
Local $hLEGL = FileOpen ($LEGL, $FO_READ) ;hLEGL variable to setup external file reading
;Read File
Global $Count = _FileCountLines($LEGL)

ReadLines()

Func ReadLines()
For $n=1 To $Count
$EGLL = FileReadLine($hLEGL,$n)
ConsoleWrite($EGLL &@CRLF)
;MsgBox($MB_SYSTEMMODAL, "", "EGL LINE : " & @CRLF & $EGLL) ; EGL1 EMAIL GENERATOR LIST LINE
;MsgBox($MB_SYSTEMMODAL, "", "Line: "  & @CRLF & $lineset) ; Line Set = value of line reader
Next
EndFunc

 

[LHCompter]

Yes I am,thanks again,now it's a faster way to see all the lines from that file

[BrewManNH]

If you're going to read the file sequentially, this way is much faster.

#include <file.au3>

;Locals for email list
$LEGL = "EGL.LIST" ;EGL ( EMAIL GENERATOR LIST | LEGL LOCATION EMAIL GENERATOR LIST)
;Open File And Read It
Global $hLEGL = FileOpen($LEGL, $FO_READ) ;hLEGL variable to setup external file reading
;Read File
;~ Global $Count = _FileCountLines($LEGL)

ReadLines()

Func ReadLines()
    While 1
        $EGLL = FileReadLine($hLEGL)
        If @error <> 0 Then ExitLoop
        ConsoleWrite($EGLL & @CRLF)
        ;MsgBox($MB_SYSTEMMODAL, "", "EGL LINE : " & @CRLF & $EGLL) ; EGL1 EMAIL GENERATOR LIST LINE
        ;MsgBox($MB_SYSTEMMODAL, "", "Line: "  & @CRLF & $lineset) ; Line Set = value of line reader
    WEnd
EndFunc   ;==>ReadLines

 

[LHCompter]

Aweomse methods but is there any way to call the value from that read line ?

For example to call first line and after it finishes his job with that line to autoincrement and call the next line from the same file

[careca]

Not sure i got the question right.

Do you really mean increment, or maybe it's concatenate?

 

[LHCompter]

Well for example I want that the program make this thing

first he reads the line so in values that will be 

$line1
$file = "file.txt"

after he reads that line I want that he make a msgbox  and say "hi the line 1 : this is line one"

after that  I want he ingrese the lines so that will be 

$line1 = $line + 1
$file = "file.txt"

msgbox ( "hi this is line 2 : this is line two)

and I want that he loops this procese :/ 

[LHCompter]

I am such noob...nevermind guys thanks for your methods I found I way to do what I want using your code lines,thanks again

[jchd]

@careca It's dramatically inefficient to first invoke _FileCountLines() then have a For loop using that count with a FileReadLine($h, $n) to read $n-th line!

With this you are doing all of the following block N+1 times if the files has N lines:

• open the file,
• read the file,
• split the file in lines,
• close the file.

Better use @BrewManNH code or FileReadToArray() and read in the array.

[careca]

I thought it was, if anything, at least as efficient.

Never timed it to know for sure.