Variable must be of type "Object" in For Loop

[xiantez]

This script used to work on an older version of AutoIT. Currently I am running AutoIT v3.3.14.5 and it's failing.

Func PublicIP() ;Post public facing IP address
    Local $url = 'https://www.google.com/search?client=opera&q=what+is+my+ip&sourceid=opera&ie=UTF-8&oe=UTF-8'
    Local $getIPaddress = BinaryToString(InetRead($url))
    Local $sStart = 'clamp:2">'
    Local $sEnd = '</div>'
    Local $ipaddress = _StringBetween($getIPaddress, $sStart, $sEnd
    
    For $i In $ipaddress
        MsgBox(0, 'External IP', "Your public IP address is " & $i)
    Next
EndFunc   ;==>PublicIP

The console output shows:

"C:\Users\user\Documents\AutoIT\Scripts\WSI Tools.au3" (197) : ==> Variable must be of type "Object".:
For $i In $ipaddress
For $i In $ipaddress^ ERROR
->14:12:16 AutoIt3.exe ended.rc:1
+>14:12:16 AutoIt3Wrapper Finished.
>Exit code: 1    Time: 9.811

Edited August 14, 2018 by xiantez
privacy

[JLogan3o13]

You need to make sure that $ipaddress has the information that you expect it to. If you output to the console right before you for loop, is $ipaddress what you would expect it to be?

[xiantez]

It appears to return an array

[jchd]

Post the actual code you use. The one posted above can't be real as it won't run until there.

[xiantez]

The rest of the code is irrelevant. I have isolated that piece of code into a standalone script and the problem still occurs

 

;==============================================================================================================================
;INCLUDE ALL LIBRARIES
;==============================================================================================================================
#include <IE.au3>
#include <Inet.au3>
#include <String.au3>
#include <Array.au3>


Local $url = 'https://www.google.com/search?client=opera&q=what+is+my+ip&sourceid=opera&ie=UTF-8&oe=UTF-8'
Local $getIPaddress = BinaryToString(InetRead($url))
Local $sStart = 'clamp:2">'
Local $sEnd = '</div>'
Local $ipaddress = _StringBetween($getIPaddress, $sStart, $sEnd)
MsgBox("", "", $ipaddress)

For $i In $ipaddress
Next
MsgBox(0, 'External IP', "Your public IP address is " & $i)

 

Edited August 14, 2018 by xiantez

[jchd]

At least now the missing closing parenthesis at end of "Local $ipaddress = ..." is fixed!

But as you noted, there is still a slight error:

Local $url = 'https://www.google.com/search?client=opera&q=what+is+my+ip&sourceid=opera&ie=UTF-8&oe=UTF-8'
Local $getIPaddress = BinaryToString(InetRead($url))
Local $sStart = 'clamp:2">'
Local $sEnd = '</div>'
Local $ipaddress = _StringBetween($getIPaddress, $sStart, $sEnd)
MsgBox("", "",  "Error = " & @error & @LF & "Result type = " & VarGetType($ipaddress))
If IsArray($ipaddress) Then
    For $i In $ipaddress
    Next
    MsgBox(0, 'External IP', "Your public IP address is " & $i)
EndIf

 

[xiantez]

Ran the code above...

[JLogan3o13]

14 hours ago, xiantez said:

It appears to return an array

And what does an _ArrayDisplay on $ipaddress look like?

[LisHawj]

Your script is not working because your $getIPaddress variable does not contain the value you are searching for in your _StringBetween line.  See my example below where I search for $sStart and it errors out.  Examine the value of $getIPaddress carefully and it should tell you what is wrong or what to change to make it work.

 

;==============================================================================================================================
;INCLUDE ALL LIBRARIES
;==============================================================================================================================
#include <IE.au3>
#include <Inet.au3>
#include <String.au3>
#include <Array.au3>


Local $url = 'https://www.google.com/search?client=opera&q=what+is+my+ip&sourceid=opera&ie=UTF-8&oe=UTF-8'
Local $getIPaddress = BinaryToString(InetRead($url))
Local $sStart = 'clamp:2">'
Local $sEnd = '</div>'
Local $ipaddress = _StringBetween($getIPaddress, $sStart, $sEnd)

If StringInStr($getIPaddress, $sStart) = 0 Then MsgBox(0,"", "String is not found.")

MsgBox("", "", $ipaddress)

For $i In $ipaddress
Next
MsgBox(0, 'External IP', "Your public IP address is " & $i)

 

[JLogan3o13]

Wow, it is almost like someone suggested that very course of action above! 

[xiantez]

Yeah you both are correct, now I am just trying to figure out "why" $getIPaddress does not have the string value i expect it to have =P

 

Thanks for all your help guys, appreciate it

[JLogan3o13]

You'll have to work your way backward up the logic chain. Is $getIPAddress returning what you would expect?

[xiantez]

No, sure isn't. It's not returning anything when I pipe it to a msgbox, just blank... Looking into this code to make sure it still behaves the same way I think it should behave...

 

$url = 'https://www.whatismyip.com/'
 $getIPaddress = BinaryToString(InetRead($url))

 

[jchd]

Just test for error(s):

$url = 'https://www.whatismyip.com/'
$result = InetRead($url)
ConsoleWrite(@error & @LF)

From this point on, no bet holds.

[xiantez]

Welp... This worked flawlessly and only 4 lines of code lol... I guess ill just stick with it

 

#include <Inet.au3>
#include <MsgBoxConstants.au3>

Local $sPublicIP = _GetIP()
MsgBox($MB_SYSTEMMODAL, "", "Your external IP address is: " & $sPublicIP)

 

[mLipok]

When it comes to get Public IP try this: