iiSkLz_ Posted June 12, 2018 Share Posted June 12, 2018 Hello guys, I'm some kind of a beginner in AutoIt, and I googled a lot without finding any idea to do, I wrote 41 scripts and all are above 1200 letter length, and I want some idea that will help me learn AutoIt and take a lot of time if possible. The longest script is attached and it is clear that I'm beginner from my syntax, and it is using arabic language. Waiting for you guys, and also give me notices and T.I.Ps about my syntax. Thanks in advance rakmanaReader.au3 Link to comment Share on other sites More sharing options...
aa2zz6 Posted June 12, 2018 Share Posted June 12, 2018 I often revisit old project scripts for work and I think to myself "how I could make this better, smaller, and more efficient." It often requires me going into the help file and reading. Link to comment Share on other sites More sharing options...
iiSkLz_ Posted June 12, 2018 Author Share Posted June 12, 2018 5 minutes ago, aa2zz6 said: I often revisit old project scripts for work and I think to myself "how I could make this better, smaller, and more efficient." It often requires me going into the help file and reading. Ok, I'll try, thanks Link to comment Share on other sites More sharing options...
iiSkLz_ Posted June 12, 2018 Author Share Posted June 12, 2018 another one plz ? Link to comment Share on other sites More sharing options...
Developers Jos Posted June 12, 2018 Developers Share Posted June 12, 2018 (edited) 27 minutes ago, iiSkLz_ said: another one plz ? Is there any fire anywhere since it seems you are seeking attention preferably NOW ? Please be patient and wait for people to walk in and feel the urge to look assist although it might be they have no idea what you really want. Jos Edited June 12, 2018 by Jos iiSkLz_ 1 SciTE4AutoIt3 Full installer Download page - Beta files Read before posting How to post scriptsource Forum etiquette Forum Rules Live for the present, Dream of the future, Learn from the past. Link to comment Share on other sites More sharing options...
Earthshine Posted June 12, 2018 Share Posted June 12, 2018 (edited) look up the term Modular Programming and put that into practice. also format the code properly. the full scite editor comes with Tidy to format Edited June 12, 2018 by Earthshine iiSkLz_ 1 My resources are limited. You must ask the right questions Link to comment Share on other sites More sharing options...
junkew Posted June 13, 2018 Share Posted June 13, 2018 read the help file examples https://www.autoitscript.com/wiki/AutoIt_Snippets Looking at your code Use indentation/style formatting (as referred to Tidy can help in formatting layout) Learn to make functions Put comments in your code to see what you functionally want Do not use cryptic variables $enDowns is probably better written as englishDownloadFolder Probably this is much easier to use/at least its shorter local $myFolder=getDownloadFolder() $filePath = FileOpenDialog("إختر ملف الرقمنة", $myFolder, "ملف نقاط (*.men)", 1) func getDownloadFolder() local $downloadFolders[]=[@UserProfileDir & "\Downloads", _ @UserProfileDir & "\Téléchargement", _ @DesktopDir] For $i = 0 To UBound($downloadFolders) - 1 If (FileExists($downloadFolders[$i])) Then return $downloadFolders[$i] Next EndFunc and after that I am lost in what your code is doing. It seems a mem file that has multiple sections you try to split with some cryptic naming of variables like $I $II $III Earthshine and iiSkLz_ 2 FAQ 31 How to click some elements, FAQ 40 Test automation with AutoIt, Multithreading CLR .NET Powershell CMDLets Link to comment Share on other sites More sharing options...
iiSkLz_ Posted June 15, 2018 Author Share Posted June 15, 2018 On ١٣/٦/٢٠١٨ at 8:54 PM, junkew said: read the help file examples https://www.autoitscript.com/wiki/AutoIt_Snippets Looking at your code Use indentation/style formatting (as referred to Tidy can help in formatting layout) Learn to make functions Put comments in your code to see what you functionally want Do not use cryptic variables $enDowns is probably better written as englishDownloadFolder Probably this is much easier to use/at least its shorter local $myFolder=getDownloadFolder() $filePath = FileOpenDialog("إختر ملف الرقمنة", $myFolder, "ملف نقاط (*.men)", 1) func getDownloadFolder() local $downloadFolders[]=[@UserProfileDir & "\Downloads", _ @UserProfileDir & "\Téléchargement", _ @DesktopDir] For $i = 0 To UBound($downloadFolders) - 1 If (FileExists($downloadFolders[$i])) Then return $downloadFolders[$i] Next EndFunc and after that I am lost in what your code is doing. It seems a mem file that has multiple sections you try to split with some cryptic naming of variables like $I $II $III That's very helpful, thanks. I'm doing your notices ... Link to comment Share on other sites More sharing options...
iiSkLz_ Posted June 15, 2018 Author Share Posted June 15, 2018 (edited) And that's it the men file i'm speaking about ( attached ). ( Note : This file is generated by another program, that program is customized chormium that read and change marks and save them is downloads folder so it's the default folder, that file is written with HTML & JS so i maked that code to seperate it and get the numbers. I know that's very ranomized but the numbers also are changed : 1st Time : Supervisor mark 2nd Time : 1st Exam Mark 3rd Time : 2nd Exam Mark 4th Time : Supervisor mark ... etc and that's repeating for all students of a class. 4م1 تربية مدنية.men Edited June 15, 2018 by iiSkLz_ Link to comment Share on other sites More sharing options...
iiSkLz_ Posted June 15, 2018 Author Share Posted June 15, 2018 (edited) Well guys, I updated the file above ( rakmanaReader ) and it's attached. Also, another file attached witch is a very simple GUI application with MetroGUI UDF. Thanks For Help. rakmanaReader.au3 MMMM.rar Edited June 15, 2018 by iiSkLz_ Link to comment Share on other sites More sharing options...
Bert Posted June 15, 2018 Share Posted June 15, 2018 if you want something fun to work on - Look at the Vollatran project and see if you can contribute to it. Things you could do: Add language support for your language and other languages like French, Spanish, and so forth. Add Windows 8 and Windows 10 support Add uninstall app support Make the GUI tool to edit INI files that Vollatran uses. Link is in my signature. iiSkLz_ 1 The Vollatran project My blog: http://www.vollysinterestingshit.com/ Link to comment Share on other sites More sharing options...
iiSkLz_ Posted June 16, 2018 Author Share Posted June 16, 2018 18 hours ago, Bert said: if you want something fun to work on - Look at the Vollatran project and see if you can contribute to it. Things you could do: Add language support for your language and other languages like French, Spanish, and so forth. Add Windows 8 and Windows 10 support Add uninstall app support Make the GUI tool to edit INI files that Vollatran uses. Link is in my signature. Well, I'll try doing the first, the third and maybe the forth. Link to comment Share on other sites More sharing options...
Recommended Posts
Create an account or sign in to comment
You need to be a member in order to leave a comment
Create an account
Sign up for a new account in our community. It's easy!
Register a new accountSign in
Already have an account? Sign in here.
Sign In Now