Automate C legacy GUI - ControlCommand & ControlClick not working

[Skysnake]

I need to automate a specific GUI from a legacy system written in C.

The spy tool gives me this

I use this code

Local $swintit = WinGetTitle("[active]")
    ConsoleWrite("active Window " & $swintit & @CRLF)

    If $swintit = "FILES NOTES" Then ; If $swintit = "FILES NOTES" Then
        ; got Window, now atomate
        ConsoleWrite("got Window " & @CRLF)

        ; now focus, then click :)

        ;EditPaste
        ;ControlCommand("FILES NOTES", "", 404, $acno) ; paste acno
        GUICtrlSetState(404, $GUI_Focus)
        ControlCommand("FILES NOTES", "", 404, $acno) ; paste acno
        GUICtrlSetState(401, $GUI_Focus)
        ControlClick("FILES NOTES", "", 401, $acno) ; click okay

    EndIf ; If $swintit = "FILES NOTES" Then

The idea is to paste the acno value into the edit box, then click an Okay button.

I get a console write that the active Window is as expected, but my loop completes without ever writing anything into the GUI.

I also tried the control ID as text "404" - same result

What am I missing?

Skysnake

 

[Danp2]

Not sure that you can use the ID number from AU3Info like that. Instead I would use the info under advanced mode, Also, there seems to be some syntax issues in your code.

Have you tried either of these methods? --

ControlSetText("FILES NOTES", "", "[CLASS:Edit, INSTANCE:1]", $acno)

or

ControlFocus("FILES NOTES", "", "[CLASS:Edit, INSTANCE:1]")
ControlCommand("FILES NOTES", "", "[CLASS:Edit, INSTANCE:1]", "EditPaste", $acno) ; paste acno

 

[Skysnake]

Thx.

Same result. Copied your code directly into my script, still does nothing. 

Please just point me in some direction? What can I use? I have never done this and feel a bit lost. 

Based on the overwhelming responses I am guessing this is not a common activity

Thanks again.

Skysnake

[Danp2]

Add some error checking. Each of these commands should return a value indicating either success or failure.

You could also try using ControlSend.

[Danyfirex]

Hello. try to show more information of AutoIt v3 Window Info to be sure what kind of control you're trying to handle.

 

Saludos

[Earthshine]

you have no logging or debug messages in msgbox form even in the area you want to test. does it find your dialog form even?

[Skysnake]

Am I making some kind logic error?

I am running Win10 64 bit.

 

The legacy software was designed for Windows XP and is 32 bit. (It still works on the Win 10 64 bit box)

 

Modified code

expandcollapse popup

Local $retunValue = 0, $returnedError

    ConsoleWrite("got $acno " & $acno & @CRLF)

    Local $swintit = WinGetTitle("[active]")
    ConsoleWrite("active Window [" & $swintit & "]" & @CRLF)
    Local $hWin = WinGetHandle("[active]")
    WinActivate($hWin)

    ;active Window [FILE NOTES]
    If $swintit = "FILE NOTES" Then ; If $swintit = "FILES NOTES" Then
        ; got Window, now atomate
        ConsoleWrite("got Window " & @CRLF)

        ; now focus, then click :)

        ;EditPaste
        ;ControlCommand("FILES NOTES", "", 404, $acno) ; paste acno
        $retunValue = ControlFocus("FILE NOTES", "", "[CLASS:Edit, INSTANCE:1]")
        ConsoleWrite("10 $retunValue " & $retunValue & @CRLF)
        $returnedError = @error
        ConsoleWrite("10 @error " & $returnedError & @CRLF)
        $retunValue = ControlCommand("FILE NOTES", "", "[CLASS:Edit, INSTANCE:1]", "EditPaste", $acno) ; paste acno
        ConsoleWrite("20 $retunValue " & $retunValue & @CRLF)
        $returnedError = @error
        ConsoleWrite("20 @error " & $returnedError & @CRLF)
        Sleep(250)
        $retunValue = ControlFocus("FILE NOTES", "", "[CLASS:Edit, INSTANCE:1]")
        ConsoleWrite("30 $retunValue " & $retunValue & @CRLF)
        $returnedError = @error
        ConsoleWrite("30 @error " & $returnedError & @CRLF)
        $retunValue = ControlClick("FILE NOTES", "", "[CLASS:Edit, INSTANCE:1]")
        ConsoleWrite("40 $retunValue " & $retunValue & @CRLF)
        $returnedError = @error
        ConsoleWrite("40 @error " & $returnedError & @CRLF)
        Sleep(1000)

    EndIf ; If $swintit = "FILE NOTES" Then

 

Console Output
got $acno AP0050
active Window [FILE NOTES]
got Window 
10 $retunValue0
10 @error 0
20 $retunValue0
20 @error 0
30 $retunValue0
30 @error 0
40 $retunValue0
40 @error 0

 

Edited April 9, 2018 by Skysnake

[Skysnake]

Here is the spy shot for the button

What else could be relevant?  Where can I look?

[Danyfirex]

get the @error value before consolewrite.

 

 

Saludos

[Danyfirex]

Also Run your Script with admin rights.

 

 

Saludos

[Skysnake]

Changes made as suggested. 

Still no usable result

updated code, with #RequireAdmin at the top

expandcollapse popup

Local $returnValue = 0, $returnedError

    ConsoleWrite("got $acno " & $acno & @CRLF)

    Local $swintit = WinGetTitle("[active]")
    ConsoleWrite("active Window [" & $swintit & "]" & @CRLF)
    Local $hWin = WinGetHandle("[active]")
    WinActivate($hWin)

    ;active Window [FILE NOTES]
    If $swintit = "FILE NOTES" Then ; If $swintit = "FILES NOTES" Then
        ; got Window, now atomate
        ConsoleWrite("got Window " & @CRLF)

        ; now focus, then click :)

        ;EditPaste
        ;ControlCommand("FILES NOTES", "", 404, $acno) ; paste acno
        $returnValue = ControlFocus("FILE NOTES", "", "[CLASS:Edit, INSTANCE:1]")
        $returnedError = @error
        ConsoleWrite("110 @error " & $returnedError & @CRLF)
        ConsoleWrite("110 $returnValue " & $returnValue & @CRLF)

;~      $returnValue = ControlCommand("FILE NOTES", "", "[CLASS:Edit, INSTANCE:1]", "EditPaste", $acno) ; paste acno
;~      ConsoleWrite("20 $returnValue " & $returnValue & @CRLF)
;~      $returnedError = @error
;~      ConsoleWrite("20 @error " & $returnedError & @CRLF)

        $returnValue = ControlClick("FILE NOTES", "", "[CLASS:Edit, INSTANCE:1]", "", Default, 21, 9) ; paste acno
        $returnedError = @error
        ConsoleWrite("210 @error " & $returnedError & @CRLF)
        ConsoleWrite("210 $returnValue ControlClick " & $returnValue & @CRLF)

        $returnValue = ControlSetText("FILE NOTES", "", "[CLASS:Edit, INSTANCE:1]", $acno) ; paste acno
        $returnedError = @error
        ConsoleWrite("220 @error " & $returnedError & @CRLF)
        ConsoleWrite("220 $returnValue ControlSetText " & $returnValue & @CRLF)

        Sleep(250)
        $returnValue = ControlFocus("FILE NOTES", "", "[CLASS:Edit, INSTANCE:1]")
        $returnedError = @error
        ConsoleWrite("230 @error " & $returnedError & @CRLF)
        ConsoleWrite("230 $returnValue " & $returnValue & @CRLF)
        $returnValue = ControlClick("FILE NOTES", "", "[CLASS:Edit, INSTANCE:1]")
        $returnedError = @error
        ConsoleWrite("240 @error " & $returnedError & @CRLF)
        ConsoleWrite("240 $returnValue " & $returnValue & @CRLF)
        Sleep(1000)

    EndIf ; If $swintit = "FILE NOTES" Then

Console output

55 IsAdmin Admin rights are detected
_clickGui 09-Apr-18 4:48:30 PM
got $acno ACNO
active Window [FILE NOTES]
got Window 
110 @error 0
110 $returnValue 0
210 @error 0
210 $returnValue ControlClick 0
220 @error 0
220 $returnValue ControlSetText 0
230 @error 0
230 $returnValue 0
240 @error 0
240 $returnValue 0

 

Edited April 9, 2018 by Skysnake

[Earthshine]

LOL. ok. Back up for a minute. You look for your text, then do something, however, what if there are other windows present while running? you are not looping through the processes. Your method of getting your window needs lots of work and can be done with a run, or runwait command probably, then a simple controlclick

what is the name of the process you run? we can go from there. Your code is really not up to the task as is.

Edited April 9, 2018 by Earthshine

[Skysnake]

Can't find the hysterical smiley

But, THIS works...

_ClipBoard_SetData($acno)
_ClipBoard_GetData()
Send("^V")
Send("!O")

So, after all the focusing on the controls, I copy my data to the Clipboard and then simply paste it.  This is giving me what I want.  

 

[InnI]

2 hours ago, Skysnake said:

$returnValue = ControlSetText("FILE NOTES", "", "[CLASS:Edit, INSTANCE:1]", $acno) ; paste acno

To separate the properties you need to use ";" but not ","

$returnValue = ControlSetText("FILE NOTES", "", "[CLASS:Edit;INSTANCE:1]", $acno) ; paste acno

Or simply

$returnValue = ControlSetText("FILE NOTES", "", "Edit1", $acno) ; paste acno

 

[Skysnake]

20 hours ago, InnI said:

To separate the properties you need to use ";" but not ","

Hmm. thx. will try. The devil is always in the detail.