Can _WM_COMMAND check for a dynamic amount of ListBoxes?

[Guy_]

This is not a working example -- I'm asking about the principle...

Here we have the often seen code to detect a double-click on an item in one ListBox (ID in $idListBox is of course created by other code).
To catch that ListBox item, I have only added $sBookmark to it. This could be a pick list application.

$idListBox = 0x004A0FB0

GUIRegisterMsg($WM_COMMAND, "_WM_COMMAND")

Func _WM_COMMAND($hWnd, $iMsg, $wParam, $lParam)

    #forceref $hWnd, $iMsg
    Local   $hWndFrom, $iIDFrom, $iCode, $hWndListBox, _
            $sBookmark

    If Not IsHWnd($idListBox) Then $hWndListBox = GUICtrlGetHandle($idListBox)
    
    $hWndFrom   = $lParam
    $iIDFrom    = BitAND($wParam, 0xFFFF)                                       ; Low Word
    $iCode      = BitShift($wParam, 16)                                         ; Hi Word

    Switch $hWndFrom

        Case $idListBox, $hWndListBox

                $sBookmark = _GUICtrlListBox_GetText( $hWndFrom, _GUICtrlListBox_GetCurSel($hWndFrom) )

                Switch $iCode

                    Case $LBN_DBLCLK

                        ConsoleWrite("you double-clicked " & $sBookmark & @CRLF)

                EndSwitch
    EndSwitch

    Return $GUI_RUNDEFMSG

EndFunc

 

Now, my question is: can one modify the _WM_COMMAND function to allow for a dynamic number of ListBoxes? (meaning, user-defined -- the amount of ListBoxes/pick lists can change at any time).

Let's assume I dynamically obtained an array with ListBox ID's for (in this case) 5 pick lists:

One part of the solution seems to work with the For... Next loop I added below, but I'm wondering if that is the ultimate? (knowing this Func has to be as fast as possible)

The part where I can't find anything that works for a dynamic amount of ListBox ID's is in the Case check...

I tried _ArrayToTxt($aIdListBox, ", ", 1), messed with Eval(), and trying Case $aIdListBox[start] To $aIdListBox[end]

 

Func _WM_COMMAND($hWnd, $iMsg, $wParam, $lParam)

    #forceref $hWnd, $iMsg
    Local   $hWndFrom, $iIDFrom, $iCode, $hWndListBox, _
            $sBookmark

    For $i = 1 To UBound($aIdListBox) - 1                       ; is this solution fast enough? (it seems to work well)
        If Not IsHWnd($aIdListBox[$i]) Then
            $hWndListBox = GUICtrlGetHandle($aIdListBox[$i])
            ExitLoop                                            ; cause there can only be one hit(?)
        EndIf
    Next

    $hWndFrom   = $lParam
    $iIDFrom    = BitAND($wParam, 0xFFFF)                       ; Low Word
    $iCode      = BitShift($wParam, 16)                         ; Hi Word

    Switch $hWndFrom

            Case [WHAT TO PUT HERE if nr of ListBoxes is dynamic?], $hWndListBox    ; <=  MAIN question

                $sBookmark = _GUICtrlListBox_GetText( $hWndFrom, _GUICtrlListBox_GetCurSel($hWndFrom) )

                Switch $iCode

                    Case $LBN_DBLCLK

                        ConsoleWrite("you double-clicked " & $sBookmark & @CRLF)
    EndSwitch

    Return $GUI_RUNDEFMSG

EndFunc

- - -

As a workaround, I can probably add the maximum number of allowed ListBoxes to the Case check, seperated by commas, but only display the number of ListBoxes needed. But I'm hoping it can be made truly dynamical...?

Thank You : )

 

Edited April 28, 2017 by Guy_

[LarsJ]

You can make it really dynamic by using a dictionary object to store the lisbox handles instead of an array:

; Create dictionary object
$oListboxDict = ObjCreate( "Scripting.Dictionary" )

; Add listboxes to $oListboxDict
$oListboxDict( $ListboxHandle11 ) = 1
$oListboxDict( $ListboxHandle12 ) = 1
$oListboxDict( $ListboxHandle13 ) = 1
$oListboxDict( $ListboxHandle14 ) = 1
$oListboxDict( $ListboxHandle15 ) = 1

; In _WM_COMMAND use an If ... EndIf instead of a Switch ... EndSwitch
If $oListboxDict.Exists( $hWndFrom ) Then
    ...
    ...
    ...
EndIf

Here you do not need a loop in _WM_COMMAND function.

[Guy_]

Awesome!  Thanks a bunch, Larsj

Objects in AutoIt are new to me, but at first sight it seemed easy enough. Yet, after double-clicking an item, I'm getting a crash on ...

If $oListboxDict.Exists( $hWndFrom )

What I have done in preparation (simplified) (I'm using $aIdListbox for other purposes too) ... :

Global $oListboxDict, $aIdListbox

Func _CreateListboxes()

    $oListboxDict = ObjCreate("Scripting.Dictionary")

    For $i = 1 To $NrOfLists
        $aIdListbox[$i] = _GUICtrlListBox_Create( ... )
        $oListboxDict( $aIdListbox[$i] ) = 1                    ; add Listbox ID's to dictionary
    Next
    ; (more creation code)
EndFunc

I'm not sure how to replace the For...Next loop, but I hoped I at least placed the If... condition like you suggested...?

Func _WM_COMMAND($hWnd, $iMsg, $wParam, $lParam)
    
    #forceref $hWnd, $iMsg
    Local   $hWndFrom, $iIDFrom, $iCode, $hWndListBox, _
            $_bookmark

    For $i = 1 To UBound($aIdListbox) - 1                                       ; loop ok, or replace how?
        If Not IsHWnd($aIdListbox) Then
            $hWndListBox = GUICtrlGetHandle($aIdListbox)
            ExitLoop
        EndIf
    Next

    $hWndFrom   = $lParam
    $iIDFrom    = BitAND($wParam, 0xFFFF)
    $iCode      = BitShift($wParam, 16)

    If $oListboxDict.Exists( $hWndFrom ) And $hWndListBox Then                  ; CRASHES on $oListboxDict.Exists

        $_bookmark = _GUICtrlListBox_GetText( $hWndFrom, _GUICtrlListBox_GetCurSel($hWndFrom) )

        Switch $iCode
            Case $LBN_DBLCLK
                ConsoleWrite("you double-clicked " & $_bookmark & @CRLF)
        EndSwitch
    EndIf

    Return $GUI_RUNDEFMSG

EndFunc

 

[LarsJ]

Please show some executable code that works when the GUIRegisterMsg command is commented out, and I'll look into the problem.

[kylomas]

Guy_,

Note the use of "number" and "hwnd"...

expandcollapse popup

#include <GUIConstantsEx.au3>
#include <WindowsConstants.au3>
#include <GuiListBox.au3>
#include <array.au3>

Local $NumListBoxes = 5
$oLBH = ObjCreate("Scripting.Dictionary")

Local $gui010 = GUICreate('LB Dictionary Example', 600, 200)

For $1 = 0 To $NumListBoxes - 1
    $oLBH.add(Number(_GUICtrlListBox_Create($gui010, '', $1 * 105 + 40, 10, 100, 100)), $1)
    $akeys = $oLBH.keys
    ;_arraydisplay($akeys)
    For $2 = 1 To $NumListBoxes
        _GUICtrlListBox_AddString(HWnd($akeys[$1]), $1 & '-' & $2)
    Next
Next

GUISetState()

GUIRegisterMsg($WM_COMMAND, "WM_COMMAND")

While 1
    $msg = GUIGetMsg()
    Switch $msg
        Case $GUI_EVENT_CLOSE
            Exit
    EndSwitch
WEnd

Func WM_COMMAND($hWnd, $iMsg, $wParam, $lParam)

    If $oLBH.exists(Number($lParam)) And _WinAPI_HiWord($wParam) = $lbn_selchange Then _
            ConsoleWrite('listbox #' & $oLBH.item(Number($lParam)) & ' actioned' & ' Value = ' & _GUICtrlListBox_GetText($lParam, _GUICtrlListBox_GetCurSel($lParam)) & @CRLF)

    Return $GUI_RUNDEFMSG
EndFunc   ;==>WM_COMMAND

kylomas

[Guy_]

18 hours ago, LarsJ said:

Please show some executable code that works when the GUIRegisterMsg command is commented out, and I'll look into the problem.

Not sure what you mean, but seems I would have to make an almost working example? That would take quite some time and luckily I got it working now using Kylomas contribution   But I thoroughly appreciate your help in the past and future

14 hours ago, kylomas said:

Note the use of "number" and "hwnd"...

I had to burn some grey matter here, but I got it working in the end. It's a thing of beauty    Thanks so much!

- - - - - - -

I have 2 final questions related to this ...

(1) If I want to include modifier key detection, can I use the (working) code below, or do I need something more professional for this type of function?
IIRC, it  turns out I can not put these detections in the targetted _findBookmark() function, because then WM_COMMAND behaves differently.

Func WM_COMMAND($hWnd, $iMsg, $wParam, $lParam)

    $_modKey = ""

    If _IsPressed("11") And _IsPressed("10") Then
        $_modKey = "Ctrl+Shift"
    ElseIf _IsPressed("11") Then
        $_modKey = "Ctrl"
    ElseIf _IsPressed("10") Then
        $_modKey = "Shift"
    EndIf   

    If $oLBH.exists(Number($lParam)) And _WinAPI_HiWord($wParam) = $LBN_DBLCLK Then
    
        $_Bookmark  = _GUICtrlListBox_GetText($lParam, _GUICtrlListBox_GetCurSel($lParam))
        $_ListboxNr = $oLBH.item( Number($lParam) )
        
        _findBookmark($_Bookmark, $_modKey, $_ListboxNr)    
    EndIf

    Return $GUI_RUNDEFMSG

EndFunc   ;==>WM_COMMAND

(2) And to be 100% sure... Am I right that, similar to MouseUp, a KeyUp kinda thing does not exist? (and therefore you see the _IsPressed loops instead?)

An example would be if I would use the Alt key and would arrive in a WordPad file. The Alt_down puts WordPad in a specific mode and crashes my program, so I'm not using Alt (or I could put a loop in _findBookmark() till it's up again). A KeyUp function could solve this easier or earlier 

Thank You both again! 

Edited April 29, 2017 by Guy_