(If else) Do until - Not working

[AlexFing17]

Hello, i am creating  a program that 

1. it will check if the computer is connected to the internet 
2. will display a message if it is connected 
3.if not connected then it will continue to check until the computer connects to the internet then it runs the function which would have been executed if the computer was connected to the internet.

what i tried.

i connected my computer to the internet and run the code. Which displayed the msgbox that am connected

i later turn my internet off and run the cold , i saw it running in process list.. i waited for 5 minutes and it was still waiting for internet connection (running), but when i turned the internet on and got internet connectivity, the app just close without displaying the msg that am connected.

Please need help where i went wrong. or if anything should be added.

 

this is the code

#AutoIt3Wrapper_icon=1.ico
$ping = Ping("www.google.com")
If Not @error Then
    MsgBox("", "AlexFing", "You are connect")
Else
    Do
        $ping = Ping("www.google.com")
    Until Not @error
EndIf

 

[water]

Wouldn't this work as well?

#AutoIt3Wrapper_icon=1.ico
Do
    $ping = Ping("www.google.com")
Until Not @error
MsgBox("", "AlexFing", "You are connect")

 

[AlexFing17]

7 minutes ago, water said:

Wouldn't this work as well?

#AutoIt3Wrapper_icon=1.ico
Do
    $ping = Ping("www.google.com")
Until Not @error
MsgBox("", "AlexFing", "You are connect")

 

Thanks Very it worked. thanks

you have been of help

[water]

[Subz]

Another option using _WinAPI_IsInternetConnected() function:

#AutoIt3Wrapper_icon=1.ico
#include <WinAPIDiag.au3>
Local $bMsgBox = False
While 1
    If _WinAPI_IsInternetConnected() Then
        If $bMsgBox = False Then
            MsgBox("", "AlexFing", "You are connect")
            $bMsgBox = True
        EndIf
    Else
        $bMsgBox = False
    EndIf
    Sleep(1000) ;~ Sleep 1 Second
WEnd

 

[water]

I assume - according to the OPs requirements in the OP - that the loop should be exited on successful ping.

Quote

3.if not connected then it will continue to check until the computer connects to the internet then it runs the function which would have been executed if the computer was connected to the internet.

So an ExitLoop should be added

#AutoIt3Wrapper_icon=1.ico
#include <WinAPIDiag.au3>
While 1
    If _WinAPI_IsInternetConnected() Then
        MsgBox("", "AlexFing", "You are connect")
        ExitLoop
    EndIf
    Sleep(1000) ;~ Sleep 1 Second
WEnd

 

[water]

BTW: The wiki holds a code snippet that allows to check internet connectivity without having to run Ping (here external ping is blocked by the FW):

https://www.autoitscript.com/wiki/AutoIt_Snippets#IsInternetConnected

[Subz]

@water Wasn't 100% sure with regards Alex wanted it running continuous or not, so I assumed the opposite

It looks like the snippet is the same code as _WinAPI_IsInternetConnected or have I missed something?

[water]

That's correct. I didn't check the WinAPIDiag UDF but now it seems the snippet in the wiki is obsolete.

[AlexFing17]

Thanks Guys. I made corrections with the help from both codes. and everything works as expected.

Thank you once again