_GDIPlus_BitmapCreateFromMemory dispose???[SOLVED]

[nend]

Hi All,

 

In the help file at "_GDIPlus_BitmapCreateFromMemory" there are a contradictory with the dispose of this data.

At the remarks it said After you are done with the object, call _GDIPlus_ImageDispose() to release the object resources.

And in the example below it said:

 Local $hBitmap = _GDIPlus_BitmapCreateFromMemory(BinGIFImage()) 

 

  _GDIPlus_BitmapDispose($hBitmap)

So wich is the right one the image dispose or the bitmap dispose or are both right?

Edited December 31, 2016 by nend

[InunoTaishou]

To my understanding an image (the class) has a bitmap member. I'm guessing when you call the ImageDispose there is an overloaded function in the dll taking a bitmap object that will dispose of the bitmap properly.

https://msdn.microsoft.com/en-us/library/windows/desktop/ms534462(v=vs.85).aspx

Edited December 30, 2016 by InunoTaishou

[nend]

Ok thanks for the reply, if I understand it correct the Bitmapdispose is the right one?

[InunoTaishou]

It's the proper one to use. This should be submitted to the bug tracker and have the help file altered to

" After you are done with the object, call _GDIPlus_BitmapDispose() to release the object resources. " to avoid confusion like this.

[BrewManNH]

Either one can be used, the two functions are identical. The only difference is in the descriptions for them, in the BitmapDispose function the help file refers to the parameter as the handle to the bitmap, and in ImageDispose it calls it the handle to the image. Other than the wording, they're identical.

[InunoTaishou]

Ah I see, Brew is right. From the GDIPlus.au3

Func _GDIPlus_ImageDispose($hImage)
    Local $aResult = DllCall($__g_hGDIPDll, "int", "GdipDisposeImage", "handle", $hImage)
    If @error Then Return SetError(@error, @extended, False)
    If $aResult[0] Then Return SetError(10, $aResult[0], False)

    Return True
EndFunc   ;==>_GDIPlus_ImageDispose

Func _GDIPlus_BitmapDispose($hBitmap)
    Local $aResult = DllCall($__g_hGDIPDll, "int", "GdipDisposeImage", "handle", $hBitmap)
    If @error Then Return SetError(@error, @extended, False)
    If $aResult[0] Then Return SetError(10, $aResult[0], False)

    Return True
EndFunc   ;==>_GDIPlus_BitmapDispose

I'd still argue to use BitmapDispose and have the help file altered. If not replacing with BitmapDispose then changing to " call _GDIPlus_BitmapDispose() or _GDIPlus_ImageDispose() to release..."

I'd still argue to use BitmapDispose, to avoid confusion (for those of us who didn't know that the functions are exactly the same) and keep the code consistent. Keeping code consistent and logical is very important.

[UEZ]

Pay attention when you use

Local $hBitmap = _GDIPlus_BitmapCreateFromMemory(BinGIFImage(), True)

The returned handle is not a GDIPlus (GDI+) handle but a GDI handle. Thus you must use 

_WinAPI_DeleteObject($hBitmap)

to release the resource!

[BrewManNH]

I personally would get rid of the BitmapDispose function and tell everyone to use the ImageDispose function exclusively. After all, the function you're calling is called GdipDisposeImage and not GdipDisposeBitmap. Just reword the helpfile to reflect what you need to pass the function when used.

[nend]

I'm still confused your are all autoit expert but UEZ (GDI wizard) says to use _winapi_deleteobject BrewManNH said to use GDIdisposeImage.

Are they both ok to use?

Edit:

Ok I see what UEZ meant I'ts all clear, thanks guys for you help

Edited December 31, 2016 by nend