Jump to content

Difficulty copying 2DArray, returned from WinList()

cappy2112

By cappy2112,
in AutoIt General Help and Support

 Share

Recommended Posts

cappy2112 Prodigy

cappy2112

Posted
Posted (edited)

Hi,

 

It's been a while since I've used AutoIt, but I'm having fun with it again.

I'm running on Windows 7 Pro, 64_bit. with AutoIt 3.3.14.2+ 

 

In my program, I've called Winlist(), so that I can get a list of all windows on the system.

I then iterate through the titles, and attempt to copy the title & handle of Windows I'm specifically interested in.

While this seems to be a very easy task, I'm having a strange problem copying the title & handle of the two windows that I'm interested in.

In the For loop: 

For $i = 1 To $AllWindowsCount

ConsoleWrite() displays the expected Title & handle, from the WindowsDupe array, so it appears that the copy from the $AllWindows array

works as expected.

However, when 

_ArrayDisplay($WindowsDupe)

is called after the for loop, $WindowsDupe is empty.

 

I wasn't able to find any functions in the help file, for copying entire arrays or certain elements, so I thought I would just copy them manually, as seen in the for loop.

What am I doing wrong with the WindowsDupe array?

 

Thanks

 

Thanks

 

My code is attached.

ListWindows2.au3

Edited by cappy2112
Added AutoIt version number, for clarity
Link to comment
Share on other sites
JohnOne Universalist

JohnOne

Posted
Posted 
#Region ;**** Directives created by AutoIt3Wrapper_GUI ****
#AutoIt3Wrapper_Run_Tidy=y
#EndRegion ;**** Directives created by AutoIt3Wrapper_GUI ****
#include <MsgBoxConstants.au3>
#include <AutoItConstants.au3>
#include <Array.au3>

_Main()

; ******************************
; GLOBAL SETTINGS
;
AutoItSetOption("WinTitleMatchMode", 2) ; match ANY substring in the title
Break($BREAK_ENABLE)
;
; ******************************


Func FindAllWindows($titlematch)

    Local $NonHIWindowCount = 0
    Local $AllWindowsCount = 0
    Local $AllWindows
    Local $i
    Local $WindowsDupe[10][2] ; arbitrary size, will ReDim later
    Local $TitleMatchCount = 0
    Local $temp

    $AllWindows = WinList()


    $AllWindowsCount = $AllWindows[0][0]
    MsgBox($MB_OK, "WINDOW COUNT", "There are " & $AllWindowsCount & " Windows")

    ReDim $WindowsDupe[(UBound($AllWindows)) - 1][2]
    ;_ArrayColInsert($WindowsDupe, 1) ; add the second dimension
    ;$count = 0
    $TitleMatchCount = 0
    For $i = 0 To $AllWindowsCount

        If StringInStr($AllWindows[$i][0], $titlematch) Then

            $WindowsDupe[$TitleMatchCount][0] = $AllWindows[$i][0] ; copy this HI window's title
            $WindowsDupe[$TitleMatchCount][1] = $AllWindows[$i][1] ; copy this HI window's handle

            ConsoleWrite("Idx = " & $i & "  Title: " & $WindowsDupe[$i][0] & "Hndl: " & $WindowsDupe[$i][1] & @CRLF)
            $TitleMatchCount += 1

        EndIf
    Next
    ReDim $WindowsDupe[$TitleMatchCount][2]
    ;$WindowsDupe[0][0] = $TitleMatchCount
    ;_ArrayDisplay($WindowsDupe, $TitleMatchCount + 1)

    Return $WindowsDupe ; return a list of all windows

EndFunc   ;==>FindAllWindows


Func _Main()


    Local $wHnd
    Local $hiWindowList
    Local $WindowCount
    Local $WindowList

    $WindowList = FindAllWindows("Untitled - Notepad")
    _ArrayDisplay($WindowList)

    MsgBox($MB_OK, "AFTER RETURN", "RETURNED FROM FINDALLWINDOWS()")


EndFunc   ;==>_Main

 

AutoIt Absolute Beginners    Require a serial    Pause Script    Video Tutorials by Morthawt   ipify 

Monkey's are, like, natures humans.

Link to comment
Share on other sites
  • Moderators
Melba23 Universalist

Melba23

Posted
  • Moderators
Posted (edited)

cappy2112,

The information is there, but because you make the Dupe array as big as the WinList return, the found data is hidden somewhere within it. Best to do something like this: 

#Region ;**** Directives created by AutoIt3Wrapper_GUI ****
    #AutoIt3Wrapper_Run_Tidy=y
#EndRegion ;**** Directives created by AutoIt3Wrapper_GUI ****
#include <MsgBoxConstants.au3>
#include <AutoItConstants.au3>
#include <Array.au3>

_Main()

; ******************************
; GLOBAL SETTINGS
;
AutoItSetOption("WinTitleMatchMode", 2) ; match ANY substring in the title
Break($BREAK_ENABLE)
;
; ******************************


Func FindAllWindows($titlematch)

    Local $NonHIWindowCount = 0
    Local $AllWindowsCount = 0
    Local $AllWindows
    Local $i
    Local $WindowsDupe[1][2] = [[0]]
    Local $TitleMatchCount = 0
    Local $temp

    $AllWindows = WinList()

    _ArrayDisplay(WinList)

    $AllWindowsCount = $AllWindows[0][0]
    MsgBox($MB_OK, "WINDOW COUNT", "There are " & $AllWindowsCount & " Windows")

    $TitleMatchCount = 0
    For $i = 1 To $AllWindowsCount

        If StringInStr($AllWindows[$i][0], $titlematch) <> 0 Then
            $TitleMatchCount += 1
            ReDim $WindowsDupe[$TitleMatchCount + 1][2]
            $WindowsDupe[$TitleMatchCount][0] = $AllWindows[$i][0] ; copy this HI window's title
            $WindowsDupe[$TitleMatchCount][1] = $AllWindows[$i][1] ; copy this HI window's handle
        EndIf
    Next

    ;$WindowsDupe[0][0] = $TitleMatchCount
    _ArrayDisplay($WindowsDupe, "Dupe array", Default, 8)

    Return $WindowsDupe ; return a list of all windows

EndFunc   ;==>FindAllWindows


Func _Main()


    Local $wHnd
    Local $hiWindowList
    Local $WindowCount
    Local $WindowList

    $WindowList = FindAllWindows("Untitled - Notepad")
    _ArrayDisplay($WindowList, "Returned", Default, 8)

    MsgBox($MB_OK, "AFTER RETURN", "RETURNED FROM FINDALLWINDOWS()")


EndFunc   ;==>_Main

Now the Dupe array is only as large as it needs to be.

M23

Edit: I see JohnOne had the same idea.

Edited by Melba23

Public_Domain.png.2d871819fcb9957cf44f4514551a2935.png Any of my own code posted anywhere on the forum is available for use by others without any restriction of any kind

Open spoiler to see my UDFs:

Spoiler

ArrayMultiColSort ---- Sort arrays on multiple columns
ChooseFileFolder ---- Single and multiple selections from specified path treeview listing
Date_Time_Convert -- Easily convert date/time formats, including the language used
ExtMsgBox --------- A highly customisable replacement for MsgBox
GUIExtender -------- Extend and retract multiple sections within a GUI
GUIFrame ---------- Subdivide GUIs into many adjustable frames
GUIListViewEx ------- Insert, delete, move, drag, sort, edit and colour ListView items
GUITreeViewEx ------ Check/clear parent and child checkboxes in a TreeView
Marquee ----------- Scrolling tickertape GUIs
NoFocusLines ------- Remove the dotted focus lines from buttons, sliders, radios and checkboxes
Notify ------------- Small notifications on the edge of the display
Scrollbars ----------Automatically sized scrollbars with a single command
StringSize ---------- Automatically size controls to fit text
Toast -------------- Small GUIs which pop out of the notification area

 

Link to comment
Share on other sites
cappy2112 Prodigy

cappy2112

Posted
  • Author
Posted
11 minutes ago, JohnOne said: 
#Region ;**** Directives created by AutoIt3Wrapper_GUI ****
#AutoIt3Wrapper_Run_Tidy=y
#EndRegion ;**** Directives created by AutoIt3Wrapper_GUI ****
#include <MsgBoxConstants.au3>
#include <AutoItConstants.au3>
#include <Array.au3>

_Main()

; ******************************
; GLOBAL SETTINGS
;
AutoItSetOption("WinTitleMatchMode", 2) ; match ANY substring in the title
Break($BREAK_ENABLE)
;
; ******************************


Func FindAllWindows($titlematch)

    Local $NonHIWindowCount = 0
    Local $AllWindowsCount = 0
    Local $AllWindows
    Local $i
    Local $WindowsDupe[10][2] ; arbitrary size, will ReDim later
    Local $TitleMatchCount = 0
    Local $temp

    $AllWindows = WinList()


    $AllWindowsCount = $AllWindows[0][0]
    MsgBox($MB_OK, "WINDOW COUNT", "There are " & $AllWindowsCount & " Windows")

    ReDim $WindowsDupe[(UBound($AllWindows)) - 1][2]
    ;_ArrayColInsert($WindowsDupe, 1) ; add the second dimension
    ;$count = 0
    $TitleMatchCount = 0
    For $i = 0 To $AllWindowsCount

        If StringInStr($AllWindows[$i][0], $titlematch) Then

            $WindowsDupe[$TitleMatchCount][0] = $AllWindows[$i][0] ; copy this HI window's title
            $WindowsDupe[$TitleMatchCount][1] = $AllWindows[$i][1] ; copy this HI window's handle

            ConsoleWrite("Idx = " & $i & "  Title: " & $WindowsDupe[$i][0] & "Hndl: " & $WindowsDupe[$i][1] & @CRLF)
            $TitleMatchCount += 1

        EndIf
    Next
    ReDim $WindowsDupe[$TitleMatchCount][2]
    ;$WindowsDupe[0][0] = $TitleMatchCount
    ;_ArrayDisplay($WindowsDupe, $TitleMatchCount + 1)

    Return $WindowsDupe ; return a list of all windows

EndFunc   ;==>FindAllWindows


Func _Main()


    Local $wHnd
    Local $hiWindowList
    Local $WindowCount
    Local $WindowList

    $WindowList = FindAllWindows("Untitled - Notepad")
    _ArrayDisplay($WindowList)

    MsgBox($MB_OK, "AFTER RETURN", "RETURNED FROM FINDALLWINDOWS()")


EndFunc   ;==>_Main

 

  

ReDim $WindowsDupe[(UBound($AllWindows))  -1][2]

Why? All of the examples I've seen- including in the help file,
always show UBound(Array) +1.

Isn't dimension [2] out of bounds, for a 2D array??

 
 ReDim $WindowsDupe[$TitleMatchCount + 1][2]
 Please explain dimension [2], since this is a 2D array. Do array indices start at 0 or 1, in AutoIT?


     
     

 

 

Link to comment
Share on other sites
JohnOne Universalist

JohnOne

Posted
Posted (edited)

in its creation you are saying it has 2 columns, 0 and 1

 

if you reference 2, you're out of bounds.

and ubound -1 is the actual amount of elements, ubound is the highest element

Edited by JohnOne

AutoIt Absolute Beginners    Require a serial    Pause Script    Video Tutorials by Morthawt   ipify 

Monkey's are, like, natures humans.

Link to comment
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
 Share
Go to topic listing
×
×
  • Create New...