Issue with returning a variable

[Champak]

What I expect in the following example is the voltage to be returned with ONE asterisk beside it no matter how many times this is called. However an asterisk is added every time it is called. So by the third time what's returned is "12.4***" instead of "12.4*". Am I using the return incorrectly or expecting the wrong thing?

Func _OBDII_BatteryVoltage($sBatteryVoltage)

    If StringMid($sBatteryVoltage, 4, 2) = "0D" Then
        Return $BattVoltage & "*"
    EndIf
    
    ;blah blah
    
endfunc

The $BattVoltage variable is a global variable that's populated in another function. That's why it's not declared here or given a value here.

 

[mLipok]

where $BattVoltage is declared ?

EDIT:
You are here almost so long like me.
You should know how to post working example.

Plesase post working example code, which show how you are using them.

Edited June 16, 2016 by mLipok

[Jos]

40 minutes ago, Champak said:

The $BattVoltage variable is a global variable

That is fine , but in this Func you defined it as Local scope due to the fact you put it on the Func statement as parameter.
So how are you calling this Func since you are returning the proper value?

Jos

[mLipok]

 

1 hour ago, Champak said:

The $BattVoltage variable is a global variable

I overlooked it

30 minutes ago, Jos said:

That is fine , but in this Func you defined it as Local scope due to the fact you put it on the Func statement as parameter.

@Jos I think you also overlooked something
This snippet is little strange, as the parameter has different variable name.
Param: $sBatteryVoltage
Returned value: $BattVoltage

So this can be writen (conceptualy) like this:

Func _OBDII_BatteryVoltage($bTest)

    If $bTest Then
        Return $__g_vBattVoltage & "*"
    EndIf
    
    ;blah blah
    
endfunc

 

As to @Champak question I propose such solution:

Func _OBDII_BatteryVoltage($bTest)

    If $bTest Then
        If StringRight($__g_vBattVoltage,1) <> "*" Then $__g_vBattVoltage &= "*"
        Return $__g_vBattVoltage
    EndIf
    
    ;blah blah
    
EndFunc

 

Edited June 16, 2016 by mLipok

[Jos]

True...  guess it is too confusing in te way it is setup.
To exchange values you either use Byref or Return xxxx and really should avoid using Global for that.

Jos

[AutoBert]

What i not understand in this example, why returning a Global var? The var is always available, assigning is just enough, returning not needed.

[mLipok]

9 minutes ago, AutoBert said:

What i not understand in this example, why returning a Global var? The var is always available, assigning is just enough, returning not needed.

As I said:

20 minutes ago, mLipok said:

This snippet is little strange,

Lets wait what @Champak would say.

 

[Champak]

Sorry, It's not explained more clearly. When I post my issues sometimes it's as clear as day to me because I'm experiencing it, I thought this was in its form.

expandcollapse popup

Global $BattVoltage = 0


Func _OBDII_BatteryVoltage($sBatteryVoltage)


    If StringMid($sBatteryVoltage, 4, 2) = "0D" Then
        _ConsoleWrite(" No Voltage 1 detected, return previous")
        Return $BattVoltage & "*"
    EndIf



    $sBatteryVoltage = StringTrimRight(StringStripCR($sBatteryVoltage), 1)
    If StringIsAlNum(StringLeft($sBatteryVoltage, 2)) Then
        $BattVoltage = $sBatteryVoltage
        Return $BattVoltage
    Else
        _ConsoleWrite(" No Voltage 2 detected, return previous")
        Return $BattVoltage & "*"
    EndIf


EndFunc




While 1

    $NavS = WinGetState($AppTitle_Settings2, "Vdc")
    If TimerDiff($ITIMER_BATTERY_V) > 5000 And BitAND($NavS, 2) Then

        $SendString2 = _CommSendString("AT RV" & @CR, 1)
        Sleep(100)
        $BattVoltage = _OBDII_BatteryVoltage(_CommGetString())
        ;ControlSetText($AppTitle_Settings2, "", Int($NAV_OPTIONS_ARRAY[39][1]), $BattVoltage & "*")
        _MailSlotWrite($hMailSlotFromNav, $BattVoltage, 2, "04");===send obd battery voltage to print. If we ctrlset text it wont print properly

        $ITIMER_BATTERY_V = TimerInit()

    EndIf
            
WEnd

 

[mikell]

You might use this in the Return

$bv = "12.4"  ; "12.4*******" 

Msgbox(0,"", StringRegExpReplace($bv & "*", '\*+', "*") )

 

[BrewManNH]

Instead of returning a value, just reset the value of $Batteryvoltage inside the function if needed. Maybe something like this.

Func _OBDII_BatteryVoltage($sBatteryVoltage)
    If StringMid($sBatteryVoltage, 4, 2) = "0D" Then
        _ConsoleWrite(" No Voltage 1 detected, return previous")
        $BattVoltage = $sBatteryVoltage & "*"
    EndIf
    $sBatteryVoltage = StringTrimRight(StringStripCR($sBatteryVoltage), 1)
    If StringIsAlNum(StringLeft($sBatteryVoltage, 2)) Then
        $BattVoltage = $sBatteryVoltage & "*"
    Else
        _ConsoleWrite(" No Voltage 2 detected, return previous")
        $BattVoltage = $sBatteryVoltage & "*"
    EndIf
EndFunc   ;==>_OBDII_BatteryVoltage

 

[Champak]

 

@mikell That's a solution, however I need one asterisk to remain if I went that route.

 

@BrewManNH so what your saying is because the return is inside the IF condition this is happening (not saying your solution isnt cleaner to follow)? I'll try it later to see if it works.

 

Still dont understand WHY it's happening like that though.

[Danyfirex]

The problem is that  programatically you say this.

MyvariableGlobal is = MyvariableGlobal(if is global will keep the previous values  if is not set to clean) & "*"

because the function return value to itself.

So Basically you're doing this.

$Variable = ($Variable & "*")  every time you call your function.

 

Saludos

 

Edited June 17, 2016 by Danyfirex
typo

[mikell]

7 hours ago, Danyfirex said:

$Variable = ($Variable & "*")  every time you call your function.

That's why in this case I suggested this

$Variable = StringRegExpReplace($Variable & "*", '\*+', "*") )

which returns $Variable & "*" with one star only even when there are several calls

[Danyfirex]

@mikell I just answer his last question about why it was happening() and I know nothing about regexp lol). something else, use global that way is not correct.

 

Saludos