error in returning valeus

[FMS]

Hello,

I'm rather new at Autoit (picked it up again afther a couple of years) but i dont know what I'm doing wrong here.
I hope somebody can help me making this script "better readeble" and explain what I'm doing wrong here.
The thing that i want to do here is making a tool that helps me whit doing mine work.
Also want to do the "ping" command in the background whit only a msgbox if ok or not.
In the code I'm writing now I'm using Send commands but know that there is a better way for this.

At this point there is a error also whish i do not udnerstand where it is comming from.
the error i get is:

MsgBox($MB_SYSTEMMODAL, "Error", " Error no IP or name is filled in")
MsgBox(^ ERROR

Could somebody help me whit looking at this code?
 

expandcollapse popup

#include <ButtonConstants.au3>
#include <EditConstants.au3>
#include <GUIConstantsEx.au3>
#include <WindowsConstants.au3>


$Form1 = GUICreate("Form1", 385, 112, 192, 124)
$iIP = GUICtrlCreateInput("", 80, 16, 209, 21)
$btn_ping = GUICtrlCreateButton("Ping", 24, 56, 89, 25)
$btn_vnc = GUICtrlCreateButton("VNC", 136, 56, 89, 25)
$btn_evr = GUICtrlCreateButton("Eventvieuwer", 248, 56, 89, 25)
GUISetState(@SW_SHOW)

Func check_input()
   If GUICtrlRead($iIP) = "" Then
        Return False
    Else
        Return True
    Endif
 EndFunc

While 1
    $nMsg = GUIGetMsg()
    Switch $nMsg
        Case $GUI_EVENT_CLOSE
            Exit
         Case $btn_ping
            $check = check_input()
            If ($check = False) Then
               Run ("cmd.exe")
               WinWaitActive("C:\WINDOWS\system32\cmd.exe")
               Send ("ping " & GUICtrlRead($iIP) & "{ENTER}")
               WinClose ("C:\WINDOWS\system32\cmd.exe")
               ;if ping OK then msgbox OK else NOK
            Else
               MsgBox($MB_SYSTEMMODAL, "Error", " Error no IP or name is filled in")
            EndIf
         Case $btn_vnc
            $check = check_input()
            If ($check = False) Then
               Run ("cmd.exe")
               WinWaitActive("C:\WINDOWS\system32\cmd.exe")
               Send ("eventvwr.exe " & GUICtrlRead($iIP) & "{ENTER}")
               WinClose ("C:\WINDOWS\system32\cmd.exe")
            Else
               MsgBox($MB_SYSTEMMODAL, "Error", " Error no IP or name is filled in")
            EndIf
         Case $btn_evr
            $check = check_input()
            If ($check = False) Then
               Run ("cmd.exe")
               WinWaitActive("C:\WINDOWS\system32\cmd.exe")
               Send ("vncviewer " & GUICtrlRead($iIP) & "{ENTER}")
               WinClose ("C:\WINDOWS\system32\cmd.exe")
            Else
               MsgBox($MB_SYSTEMMODAL, "Error", " Error no IP or name is filled in")
            EndIf
    EndSwitch
 WEnd

 

[water]

You need to add

#include <MsgBoxConstants.au3>

at the top of your script.

[FMS]

thanks - added
Do you also know how to ping in the background and iff result is good a massagebox apears?

thanks in advanced

[water]

AutoIt offers a Ping function. So there is no need to run CMD.

[FMS]

thanks this helps a lot...
The thing is :
the ping command is very usefull for the 1st button.
for the other buttons (VNC and eventviewer) I want to run like a batch script and I only know to do it whit "in screen"  commands like "Send" ,
Could u help me whit this? :

VNC button:

set /p ipadres=Wwhat is the IP of machine?
:LOOP
ping %ipadres% -w 1 > nul
IF ERRORLEVEL 1 GOTO :DEAD
IF ERRORLEVEL 0 GOTO :ALIVE
:DEAD
Echo Time-Out on %ipadres%...
GOTO :LOOP
:ALIVE
ECHO The machine is online and VNC wil be started
cd\
cd "C:\Program Files\Realvnc\vnc4"
vncviewer %ipadres%

cls

 

EVENTVIEWER button:

set /p ipadres=What is the IP of the machine?
net use z: /DELETE /Y
net use z: \\%ipadres%\C$ /user:username password
CLS
ECHO Event Viewer will be started...
c:\WINDOWS\system32\eventvwr.exe %ipadres%
CLS
ECHO Event Viewer wordt gestart...
ping -n 20 127.0.0.1 > nul
net use z: /DELETE /Y

 

[water]

Should be quite easy:

$sIP = InputBox("Prompt", "What is the IP of the machine?")
If Ping($sIP) > 0 Then
    Run("C:\Program Files\Realvnc\vnc4\vncviewer.exe " & $sIP)
Else
    MsgBox($MB_ICONERROR, "Error", $sIP & " is dead. @error = " & @error)
EndIf

 

[FMS]

who knows,....
this will make mine code a lot simpler and shorter!
Many thanks

[water]