GUIListViewEx Integration

[error471]

@Melba23:

Hmm, found an error while implementing to my project. If I load a file which has columns added with the new function, it crashes:

 

"C:\Program Files (x86)\AutoIt3\Include\GUIListViewEx_Colour_Col.au3" (2587) : ==> Array variable has incorrect number of subscripts or subscript dimension range exceeded.:
If StringInStr(($aGLVEx_Data[0][13])[$iItem + 1][$iSubItem], ";") Then
If StringInStr(($aGLVEx_Data[0][13]^ ERROR

 

[AutoBert]

I think this is a typo, Remove the ")" at the pos

[error471]

2 minutes ago, AutoBert said:

I think this is a typo, Remove the ")" at the pos

Syntax is ok. It seems to be more difficult.

[AutoBert]

Syntax for StringInStr isn't ok, there are minimum 2 Parameters needed. When remove the ")" the syntax for StrinInStr is ok.

Edited January 27, 2016 by AutoBert

[Melba23]

AutoBert,

The syntax is fine - when you access an element in an array which is inside another array you need to contain the base array in parentheses:

If StringInStr(  ($aGLVEx_Data[0][13]) [$iItem + 1][$iSubItem] , ";") Then
;                 Base array inside    indices of element        Second param
;                  another array

error471,

I can reproduce the crash - looking into it.

M23

Edit: I know the proximate cause of the crash - now to find out why the error occurs in the first place.

Edit 2: Found it - stupid error while polishing code. I will fix it after dinner.

Edited January 27, 2016 by Melba23

[mLipok]

some other error :

Quote

>"C:\Program Files (x86)\AutoIt3\SciTE\..\AutoIt3.exe" "C:\Program Files (x86)\AutoIt3\SciTE\AutoIt3Wrapper\AutoIt3Wrapper.au3" /run /prod /ErrorStdOut /in "C:\Users\user\Downloads\Colour ListView Col.au3" /UserParams    
+>20:02:34 Starting AutoIt3Wrapper v.15.920.938.4 SciTE v.3.6.2.0   Keyboard:00000415  OS:WIN_7/Service Pack 1  CPU:X64 OS:X64  Environment(Language:0415)  CodePage:65001  utf8.auto.check:4    # detect ascii high characters and if none found set default encoding to UTF8 and do not add BOM
+>         SciTEDir => C:\Program Files (x86)\AutoIt3\SciTE   UserDir => C:\Users\user\AppData\Local\AutoIt v3\SciTE\AutoIt3Wrapper   SCITE_USERHOME => C:\Users\user\AppData\Local\AutoIt v3\SciTE 
>Running AU3Check (3.3.15.1)  from:C:\Program Files (x86)\AutoIt3  input:C:\Users\user\Downloads\Colour ListView Col.au3
+>20:02:34 AU3Check ended.rc:0
>Running:(3.3.14.2):C:\Program Files (x86)\AutoIt3\autoit3.exe "C:\Users\user\Downloads\Colour ListView Col.au3"    
--> Press Ctrl+F11 to Restart or Ctrl+Break -or- F11 to Stop
"C:\Program Files (x86)\AutoIt3\Include\Array.au3" (437) : ==> Array variable has incorrect number of subscripts or subscript dimension range exceeded.:
$aArray[$vRange[$i]][0] = ChrW(0xFAB1)
^ ERROR
->20:04:46 AutoIt3.exe ended.rc:1
+>20:04:46 AutoIt3Wrapper Finished.
>Exit code: 1    Time: 133.2
 

 

HOWTO:

Click SAVE
Click LOAD
Click HeaderCol=0 in RightLV
6*Click "Delete Col"

 

btw.

Very nice project and progress

.... as always from @Melba23 

 

Edited January 27, 2016 by mLipok

[kylomas]

M23,

Thank you, I've always stayed away from arrays within an array because I didn't know they could be accessed directly...

#include <array.au3>

local $at1[3]
local $ai1 = [01,02,03]
local $ai2 = [11,12,13]
local $ai3 = [21,22,23]

$at1[0] = $ai1
$at1[1] = $ai2
$at1[2] = $ai3

for $i = 0 to ubound($at1) - 1
    ConsoleWrite('! Array at offset = ' & $i & @CRLF)
    for $j = 0 to ubound( ($at1[$i]) ) - 1
        ConsoleWrite( ($at1[$i])[$j] & @CRLF)
    Next
next

kylomas

[Melba23]

error471 & mLipok,

I think I have fixed both of those bugs - try this:

 

Any more reports will have to wait until I find time - I am off flying tomorrow!

M23

Edited June 2, 2016 by Melba23
Beta code removed

[mLipok]

I confirm "my bug" as fixed.

[error471]

On 25.1.2016 at 8:11 PM, Melba23 said:

" editable column headers "

Go and read the function header for _GUIListViewEx_Init - that functionality is already incorporated in the UDF.

 

 

I confirm too, works now. One last question about _GUIListViewEx_Init. I looked at the description it says  "+ 8   - Headers editable by Ctrl-click (only if ListView editable)".

I am initializing with this line:

 

$iLVIndex_1 = _GUIListViewEx_Init($cLV_1, $aLVArray_1, 1, 0, True, 2 + 8 + 16 + 32, "*")

But the column headers are not editable though.

In case you are not online anymore: Have a nice journey.

[mLipok]

I hope @Melba23 will be back online as soon as possible .

 

[Melba23]

error471,

I was not going on a journey.  One of my other hobbies is teaching young people how to fly - I had three of them today and I am now passably tired after spending all day briefing, flying and debriefing. But now I have a nice glass of red wine to hand and can return to my "bad-weather" hobby of AutoIt.

When I initialise the ListView I can certainly edit the headers - are you using Ctrl-Click (that is the Ctrl key pressed while left-clicking on the header with the mouse)?

M23

[error471]

@Melba23:

I apologize. I have not read carefully. It works of course.

[Melba23]

error471,

No problem - it is a complex UDF and needs a bit of careful reading to get the best out of it. Please keep testing the code I posted - I am doing the same when I have the time (I have a round of golf booked for tomorrow morning!) - and let me know if you find anything else.

M23

[error471]

@Melba23:

I tested your code with more than 300 columns and random data, save/load: I had no crash. Does your script have an artificial or natural limit (integer etc.)?

 

Actually I am working on a function that duplicates the last -for example- 7 cells of a specific row or an entire column at the right end of the ListView. This function ist intended to simplify or obsolete the manual input for intervals that repeat over and over, which I will have in my project.

Edited January 28, 2016 by error471

[Melba23]

error471,

The only limitations should be those imposed by the Windows ListView control itself (alas notoriously flaky), the normal AutoIt limits of array size, and the memory limitations of the machine on which it is being run. And in my experience, the larger the ListView content, the more likely you are to run into problems.

I followed the discussion in your earlier thread and while I appreciate the push you gave me to improve the UDF,  I must say I agree with those who suggested that a database of some sort was the way to go with your project.  I will of course continue to provide support as far as I can in making the UDF work correctly, but I am far from convinced that a pure AutoIt solution is the best manner to approach this. However, I would be very happy to be proved wrong, so please accept my best wishes: Good luck!

M23

[error471]

Case $cGo
            ; Get colour array
            $aColArray = _GUIListViewEx_ReturnArray($iLVIndex_1, 2)
            ; Loop through array
            For $i = 0 To UBound($aColArray) - 1
                $sItems = "Row " & $i & " = "
                For $j = 1 To UBound($aColArray, 2) - 1
                    ; Is this cell yellow text on red field?
                    If $aColArray[$i][$j] = "0xFFFF00;0xFF0000" Then
                        $sItems &= $aLVArray_1[$i+1][$j] & "+"
                    EndIf
                Next
                ConsoleWrite(StringTrimRight($sItems, 1) & @CRLF)

I tried to implement the upper part into my code, but it crashes. I am not quite sure, but I think $aColArray is not correctly read in my case. If there is no item as searched in the ListView it does not crash (and also not find the content). If it should find the searched cells, it crashes. Can you give me a notice?

[Melba23]

error471,

That code works when I run it on some of my data - please save the ListView when filled with the data you are using and post the file so we are working on the same content. I would also like to see the GUICtrlCreateListView & _GUIListViewEx_Init lines you are using to create the ListView in the first place.

M23

[error471]

The error is: Subscript used on non-accessible variable.

This line:

 $sItems = $aLVArray_1[$i+1][$j] & "+"

Looking for these (orange/yellow) colours (of first row):

"0xFF9900;0xFFFF00"

*.lvs- see attachment.

2016_28_01_19_58_34_colors.lvs

[Melba23]

error471,

I have no problem with that file at all - as long as I read the data at the same time I read the colours:

expandcollapse popup

#include <GUIConstantsEx.au3>
#include <WindowsConstants.au3>
#include <AutoItConstants.au3>
#include <File.au3>
#include <String.au3>
#include <Array.au3>

#include "GUIListViewEx_Colour_Col.au3"

$hGUI = GUICreate("Test", 1000, 500)

$cLV_1 = GUICtrlCreateListView("", 10, 10, 480, 300, $LVS_SINGLESEL)
_GUICtrlListView_SetExtendedListViewStyle($cLV_1, $LVS_EX_FULLROWSELECT)

; Initiate ListView
$iLVIndex_1 = _GUIListViewEx_Init($cLV_1, "", 1, 0, True, 2 + 16 + 32) ; Empty ListView so no array passed

; Create buttons
$cGo = GUICtrlCreateButton("Go!", 10, 450, 80, 30)

_GUIListViewEx_LoadListView($iLVIndex_1, "colors.lvs")
ConsoleWrite(@error & @CRLF)

_GUIListViewEx_MsgRegister()

GUISetState()

While 1

    $iMsg = GUIGetMsg()
    Switch $iMsg
        Case $GUI_EVENT_CLOSE
            Exit

        Case $cGo
            ; Get data array
            $aLVArray =  _GUIListViewEx_ReturnArray($iLVIndex_1
            ; Get colour array
            $aColArray = _GUIListViewEx_ReturnArray($iLVIndex_1, 2)
            ; Loop through array
            For $i = 0 To UBound($aColArray) - 1
                $sItems = "Row " & $i & " = "
                For $j = 1 To UBound($aColArray, 2) - 1
                    ; Is this cell yellow text on red field?
                    If $aColArray[$i][$j] = "0xFF0000;0xFFFF00" Then
                        ; Read equivalent element from the data array
                        $sItems &= $aLVArray[$i+1][$j] & "+"
                    EndIf
                Next
                ConsoleWrite(StringTrimRight($sItems, 1) & @CRLF)
            Next
    EndSwitch

    ; Allow edit on double click
    $aRet = _GUIListViewEx_EditOnClick()

WEnd

And I get:

Row 0 =
Row 1 =
Row 2 = SubItem 2-2
Row 3 =
Row 4 =

which matches the colours.

You need to make sure that the 2 arrays match - had you amended the original content?

M23