Hosts File Editing Script not working

[EvoBora]

Hello Everyone, I'm running into an issue with the below hosts file script originally posted by Chewy.  Has the Author as Matt Majewski back in 2009.  Not sure if it was edited from the original creation date.  The problem I'm running into is that it is not editing the hosts file it is just appending the line to the hosts file over and over again.  It seems like it can't find the name when it searches the array.  Does someone have a working script that allows you to edit an ip if it exists or add it if it doesn't?  I have tried this on multiple computers all running Win7 Pro 64bit.  Any help would greatly be appreciated.  I'm sure I'm just missing something, but I can't seem to see it.

Thank You

expandcollapse popup

Func HostUpdate()

;EDIT IP TO THE IP ADDRESS OF YOUR SERVER YOU WANT MACHINES TO IMPORT TO
$CitrixIP = "10.99.1.1"
;HOSTS file path
$sFile = @WindowsDir & "\system32\Drivers\etc\hosts"
;used to define the index in the array when citrix.mydomain.com was found
Dim $CitrixFind
;the array used to import the HOSTS file to
Dim $aRecords


;Open the HOSTS file for reading into the array
;If Not _FileReadToArray(@SystemDir & "\Drivers\etc\hosts",$aRecords) Then
If Not _FileReadToArray($sFile, $aRecords) Then

   MsgBox(4096,"Error", " Error reading log to Array     error:" & @error)
   ;MsgBox(4096,"Error", $sFile)

   Exit
EndIf


;searches the imported array to find the word "citrix.mydomain.com"
;then set the arrayindex it found it into $CitrixFind
;$CitrixFind = _ArraySearch ($aRecords, "citrix.mydomain.com", 0 , 0, 0, True)
$CitrixFind = _ArraySearch ($aRecords, "citrix.mydomain.com")


;IF it found citrix.mydomain.com
IF ($CitrixFind <> -1)  Then

;change the array to include the new ip Number
;it changes the specific array index based on the earlier search
    $aRecords[$CitrixFind] = $CitrixIP & "     citrix.mydomain.com"


;open the host file for editing
;the 2 parameter will erase the contents of the file
    $hFile = FileOpen($sFile, 2); 2 = erase
;write the array to the open File
    _FileWriteFromArray($hfile, $aRecords, 1)
;close the HOSTS file that was opened
    FileClose($hFile)

; did not find citrix.mydomain.com
Else

;open the host file for editing
;the 1 parameter will append to the end of the file
    $hFile = FileOpen($sFile, 1); 1 = append
;write the new zen ip to the end of the file
    FileWriteLine($hFile, $CitrixIP & "     citrix.mydomain.com")
;close the HOSTS file that was opened
    Fileclose($hFile)

;END IF found citrix.mydomain.com of not
EndIf

EndFunc

 

[BrewManNH]

Try changing your _ArraySearch line to this:

$CitrixFind = _ArraySearch($aRecords, "citrix.mydomain.com", 0, 0, 0, 1)

You're trying to do a partial string search without specifying to the function you are.

[guinness]

By the way there is a regular expression for HOSTS parsing. Search my username and HOSTS on the forum.

[EvoBora]

Thank you for your replys... 

Try changing your _ArraySearch line to this:

$CitrixFind = _ArraySearch($aRecords, "citrix.mydomain.com", 0, 0, 0, 1)

You're trying to do a partial string search without specifying to the function you are.

I added that line in and same results.  I did try that and commented out but had a True instead of a 1 so I'm glad I understand that piece now.  Still not sure why it isn't searching the array correctly.

By the way there is a regular expression for HOSTS parsing. Search my username and HOSTS on the forum.

I did a search and came up with 22 results.  Did read them all but they are well over my head.  I've been using Autoit for over a year and I think I've only tapped into 1% of its potential.  Any other suggestions would be great.