new _filewritetoline func wonky in latest version?

[JohnOne]

Not sure is serious.

But yes, of course...

;If Not (IsBool($bOverWrite) Or $bOverWrite = 0 Or $bOverWrite = 1) Then Return SetError(5, 0, 0) ; For old versions.

 

[iamtheky]

hilarious.   But seriously, does that say 'if Not (1 or 0 or 0 or 1)?'

[JohnOne]

Actually, it's me who's ridiculous, haha.

It just looked like something else to me, when it really checks if the parameter is either a bool, a 1 , or a 0.

My apologies to the author.

$bOverWrite = 0
If Not (IsBool($bOverWrite) Or $bOverWrite = 0 Or $bOverWrite = 1) Then MsgBox(0,0,"Returning error")

$bOverWrite = 1
If Not (IsBool($bOverWrite) Or $bOverWrite = 0 Or $bOverWrite = 1) Then MsgBox(0,0,"Returning error")

$bOverWrite = False
If Not (IsBool($bOverWrite) Or $bOverWrite = 0 Or $bOverWrite = 1) Then MsgBox(0,0,"Returning error")

$bOverWrite = True
If Not (IsBool($bOverWrite) Or $bOverWrite = 0 Or $bOverWrite = 1) Then MsgBox(0,0,"Returning error")

$bOverWrite = "1"
If Not (IsBool($bOverWrite) Or $bOverWrite = 0 Or $bOverWrite = 1) Then MsgBox(0,0,"Returning error")

$bOverWrite = "0"
If Not (IsBool($bOverWrite) Or $bOverWrite = 0 Or $bOverWrite = 1) Then MsgBox(0,0,"Returning error")

$bOverWrite = HWnd(0x43456)
If Not (IsBool($bOverWrite) Or $bOverWrite = 0 Or $bOverWrite = 1) Then MsgBox(0,0,"Returning error")

$bOverWrite = "sausage"
If Not (IsBool($bOverWrite) Or $bOverWrite = 0 Or $bOverWrite = 1) Then MsgBox(0,0,"Returning error")

MsgBox(0,$bOverWrite, (IsBool($bOverWrite) Or $bOverWrite = 0 Or $bOverWrite = 1))

I don't know, it just looks weird.

[jchd]

Definitely. I don't understand why most UDFs try hard to check for specific datatypes in certain parameters (way too many) instead of relying on AutoIt internal automatic conversions.

Take the variable here and treat it as a boolean. It's the caller's responsability to provide a meaningful parameter. Type checks are only necessary when such conversion is unable to produce the needed (not "expected") datatype. Of course you're not going to invoke an object's method or property if the argument passed isn't the correct object. But such cases are rare.

[guinness]

I AM THE AUTHOR

[JohnOne]

I AM THE AUTHOR

CONGRATULATIONS.

[BrewManNH]

The line is problematic because anything will evaluate as correct. There's nothing that will ever cause the function to return an error of 5 in that line.

[guinness]

Are you sure? Please provide a reproducer which shows you're right.

[jchd]

I take it the other way:

Local $a[3]
Local $aCauses = [ _
    $a, _
    "42US$", _
    Default, _
    Null, _
    3.1415926, _
    MsgBox, _
    Binary("abc"), _
    ObjCreate("Scripting.Dictionary"), _
    Ptr(1234567890), _
    WinGetHandle(@ScriptFullPath) _
]

For $bOverWrite In $aCauses
    If Not (IsBool($bOverWrite) Or $bOverWrite = 0 Or $bOverWrite = 1) Then
        ConsoleWrite("Error 5 caused by " & VarGetType($bOverWrite) & @LF)
    EndIf
Next

 

[jpm]

Nice Jchd,

You just miss that empty string is OK for False ...

[guinness]

= should be == in that case.

[BrewManNH]

Are you sure? Please provide a reproducer which shows you're right.

I just double-checked myself. It will return an error on any number that's not 1 or 0, but will not fail on a string being sent to it if the string doesn't start with a number. I stand corrected. Mea culpa.

[guinness]

I just double-checked myself. It will return an error on any number that's not 1 or 0, but will not fail on a string being sent to it if the string doesn't start with a number. I stand corrected. Mea culpa.

Or not boolean