Unexpected value returned from function call

[kylomas]

This is one of those 2:30AM questions.

I am expecting this code to return 'Yes' but it is returning 0.

local $var1 = ''

ConsoleWrite(test1() & @CRLF)

func test1()
    ConsoleWrite('At top of function' & @CRLF)
    if $var1 = '' Then
        $var1 = 'yes'
        ConsoleWrite('at = condition... $var1 = ' & $var1 & @CRLF)
        test1()
    Else
        ConsoleWrite('returning from else... $var1 = ' & $var1 & @CRLF)
        return $var1
    EndIf

endfunc

When I run it like this it works...

local $var1 = ''

ConsoleWrite(test1() & @CRLF)

func test1()
    ConsoleWrite('At top of function' & @CRLF)
    if $var1 = '' Then
        $var1 = 'yes'
        ConsoleWrite('at = condition... $var1 = ' & $var1 & @CRLF)
        return test1()
    Else
        ConsoleWrite('returning from else... $var1 = ' & $var1 & @CRLF)
        return $var1
    EndIf

endfunc

The only difference is that I added a return to the recursive call to the function.  My original thought was that I was not getting the value of $var1 for the recursive call but I don't see how as this is a global variable.

Hmmm...now 3:04AM

kylomas 

 

[JohnOne]

Return from test1() else condition is only returning to test1() if condition, which is returning nothing.

local $var1 = ''

ConsoleWrite(test1() & @CRLF)

func test1()
    ConsoleWrite('At top of function' & @CRLF)
    if $var1 = '' Then
        $var1 = 'yes'
        ConsoleWrite('at = condition... $var1 = ' & $var1 & @CRLF)
        test1()
    Else
        ConsoleWrite('returning from else... $var1 = ' & $var1 & @CRLF)
        return $var1
    EndIf
    return $var1
endfunc

 

[kylomas]

J1,

Gonna have a beer and go to bed.  Maybe I'll understand your reply tomorrow.

kylomas

[JohnOne]

lol best advice anyone can ever give themselves.

local $var1 = ''

ConsoleWrite(test1() & @CRLF)

func test1()
    ConsoleWrite('At top of function' & @CRLF)
    if $var1 = '' Then
        $var1 = 'yes'
        ConsoleWrite('at = condition... $var1 = ' & $var1 & @CRLF)
        test1() ; this is a recursive call, that leads to the function getting to the else condition, then it returns here and goes to end of function which returns nothing
    Else
        ConsoleWrite('returning from else... $var1 = ' & $var1 & @CRLF)
        return $var1
    EndIf
    ;returning nothing
endfunc

 

[kylomas]

OK, I think, but why does the second pass through test1() return 0 when $var1 = 'Yes' as shown in the consolewrite?

Apparently the sleep did nothing to clear the confusion...

kylomas

[JohnOne]

This is the "first pass" to test1()...

ConsoleWrite(test1() & @CRLF)

It enters the If condition because $var1 = ""

Now in that If condition test1() is called a second time recursively "second pass"

But now $var1 = "yes", so this time it enters the Else condition which returns $var1 (which = "yes"

But it has only returned that value to the point from which it was called in the "first pass" If condition, and that is the end of "second pass"

Now the first pass can continue, since it's done its job in the If condition it has nothing left to do except reach EndFunc, where it returns nothing to its caller...

ConsoleWrite(test1() & @CRLF)

Phew.

Edited August 2, 2015 by JohnOne

[jaberwacky]

The only explanation I can think of is that $var1 is not written to in the global scope until the function returns.

[kylomas]

J1, jaberwacky,

But it has only returned that value to the point from which it was called

 finally cleared my mental fugue...

I blame my recently deceased Rubik's Cube.

Again, thank you for your patience.

kylomas

Edited August 2, 2015 by kylomas
spelling

[guinness]

One point to add for clarity, use the Global keyword if the variable is going to be globally accessible. In this instance the variable is only "local" to the "global (AutoIt) scope"*. It makes things a little easier to read. Anyway, the less global variables, the better I say.

* I would argue it's not really global scope.

Edited August 2, 2015 by guinness

[JohnOne]

The only explanation I can think of is that $var1 is not written to in the global scope until the function returns.

But it is though, here "$var1 = 'yes'" it's the first and only thing the function does.besides a couple of ConsoleWrite.

kylomas you should really try to understand this, I can see how it might confuse you, but it is very basic requirement to understand the flow of your code.

EDIT: let me try again.

func test1()
    ConsoleWrite('At top of function' & @CRLF)
    if $var1 = '' Then
        $var1 = 'yes'
        ConsoleWrite('at = condition... $var1 = ' & $var1 & @CRLF)
        $return = test1() ; 
    Else
        ConsoleWrite('returning from else... $var1 = ' & $var1 & @CRLF)
        return $var1 ; This return only returns to $return variable.
    EndIf
    ; the return to Consolewrite comes from here
    ;as you should see, it returns nothing
endfunc

 

Edited August 2, 2015 by JohnOne

[Danyfirex]

To avoid the global variable.  you could use Static variables.

 

Saludos

[JohnOne]

The variable being global is beside the point, the value being printed is a return from a function that returns nothing.

[JohnOne]

Am I being trolled here?

[jchd]

Looks like, J1!

Also a Static for handling recursion is a joke.

[jaberwacky]

I'd still say that maybe a local copy of $var1 is made and stays local until the func returns?

 

Edit: for the record, I'm not trolling.

Edited August 2, 2015 by jaberwacky

[JohnOne]

The global variable " Local $var1 = ''" is set to 'yes', it's just never used anywhere outside of the function.

[kylomas]

J1,

I get it, see post #8...

[JohnOne]

Ok, my apologies I never seen your edit.

[kylomas]

No apology necessary, thanks for taking the time to help clear the fog...

[guinness]

Also a Static for handling recursion is a joke.

Why you say that?