How heavy would such script be on system resources?

[micechal]

Hi. A couple of minutes ago I came up with this really simple script to solve my annoyance with Avira Free:

While True
   local $popup = WinWait("c:\program files\avira\antivir desktop\ipmGui.exe")
   WinClose($popup)
WEnd

But I've got some doubts as to how much would it impact the system if I left it running forever.

Do you think it's alright to add such script to autostart and let it run at all times, or should I introduce some changes, maybe inserting a lengthy Sleep after the third line would make it better?

Generally I don't care if the popup gets closed in 200 ms or 5 seconds, so if it's possible to decrease the polling rate, I could use that too.

I've also got to ask about the variable. It being local, does it mean it gets cleared whenever new loop iteration begins, or does it stay in the memory all the time?

[BrewManNH]

You should insert a short sleep in the loop, to prevent overworking your CPU, usually 10-100ms is more than enough.

As to the variable, you don't need to declare it inside the loop, but using Local in the loop has no effect. Variables in AutoIt have 2 scopes, local variables used inside functions, and global. Any variable declared outside of a function is by design a Global variable, so it doesn't matter in the least if you use Local or Global in those cases, they'll both be considered Global. Variables declared Local inside loops will be Global if declared outside of a function, and Local if inside a function but not local to the loop.

[Jos]

Which polling rate?

WinWait() should wait until the window pops-up.

Jos

[BrewManNH]

Ooops, totally missed that myself.

[micechal]

Thank you for replying guys.

So considering the reply of BrewManNH, is this one better?

While True
   $popup = WinWait("c:\program files\avira\antivir desktop\ipmGui.exe")
   WinClose($popup)
   Sleep(500)
WEnd

Jos, see the "Remarks" section here: https://www.autoitscript.com/autoit3/docs/functions/WinWait.htm

Edited November 6, 2014 by micechal

[Melba23]

micechal,

The WinWait function internally polls "every 250 milliseconds or so", but the overall script remains paused until it returns.

M23

[micechal]

I examined this code further and came to conclusion that I don't really need the variable at all because I can do this:

While True
   WinClose(WinWait("c:\program files\avira\antivir desktop\ipmGui.exe"))
   Sleep(500)
WEnd

Do you think it's a good idea to do so?

[czardas]

It should hardly make any difference. It is generally a good idea to use the minimum recources to achieve a task. In this case you can pass the handle directly and do not need to create a variable. Sometimes you might want to declare a variable simply to make the code easier to understand.

Edited November 6, 2014 by czardas

[jdelaney]

Like mentioned above, since there is already an internal 'sleep' in the winwait, there is no need for your added sleep.

While True
   WinClose(WinWait("c:\program files\avira\antivir desktop\ipmGui.exe"))
WEnd

[guinness]

Declaring inside a loop foes affect the overall execution, as AutoIt has to internally re-check the scope of the variable.

[czardas]

Declaring variables inside a loop is plain bad. I also think that declaring variables inside conditional statements is somewhat dubious. Assigning values to variables can occur anywhere in the script (within reason).

Edited November 7, 2014 by czardas

[guinness]

If the variable is only used/seen within that if statement, then it's good practice according to all the articles I have read.

[SmOke_N]

If the variable is only used/seen within that if statement, then it's good practice according to all the articles I have read.

 

It depends on the language I would assume more so than anything.

With interpretation, if the variables are created regardless of a condition, then it is unnecessary and using more resources to create within a condition/loop.  That would be bad practice IMHO.

Most languages only create the variable and use the resource within a condition if the condition is true, then they go out of scope once the condition is done with, so those languages, I would agree, creating the variable is ok even suggested within those languages.

[czardas]

I certainly do see the logic in not declaring a variable that you don't intend to use. For me it's more a question of personal coding style. The occasional unnecessary local declaration causes no significant degradation in performance. I therefore prefer consistancy of style in this instance - declaring variables outside conditionals and only assigning values when needed.

I think the point where this might become a problem is past the point where a helper function really ought to be used, in most cases. This is what I generally do instead of using conditional declarations - which are apparently quite common. I also think it's a matter of perspective: if the function is using declarations in an abnormal way, then whatever effect that has will need taking into consideration. I'm not sure if there's really a right or wrong answer.

;

Func Whatever()
    Local $vFoo ; Has very little impact.
    If @HOUR > 1 Then
        $vFoo = "megabytes" ; Now we need to use some memory.
    EndIf
    $vFoo = 0
    
    ; Carry on...
EndFunc

;

But I would most likely do this:

Func Whatever()
    If @HOUR > 1 Then HelperFunction()

    ; Carry on...
EndFunc

Func HelperFunction()
    Local $vFoo = "megabytes"
EndFunc

Edited November 7, 2014 by czardas

[guinness]

 

But I would most likely do this:

Func Whatever()
    If @HOUR > 1 Then HelperFunction()

    ; Carry on...
EndFunc

Func HelperFunction()
    Local $vFoo = "megabytes"
EndFunc

In C#, the variable foo would out of scope if it were to be used outside of the condition. Unfortunately this same logic doesn't happen in AutoIt, though it;s still best to conform to the practice of declare variables in their lowest scope possible.

Func Whatever()
    If @HOUR > 1 Then
        Local $vFoo = "megabytes" ; Now we need to use some memory.
    EndIf

    ; Carry on...
EndFunc

By the way in C# and Java, the whole don't declare variables in a loop problem, doesn't apply to those languages.

Edited November 9, 2014 by guinness

[czardas]

Good information, thanks! These subtleties do make a difference. I don't think it's so bad to make declarations according to a condition. I've never come accross a situation where I needed to do this in AutoIt, and I don't believe I ever will because of the alternatives already mentioned.

Edited November 9, 2014 by czardas