ReplaceStringInFile Suggestion

[uncommon]

expandcollapse popup

Func __ReplaceStringInFile($szFileName, $szSearchString, $szReplaceString, $fCaseness = 0, $fOccurance = 1)
    Local $iRetVal = 0
    Local $nCount, $sEndsWith
    ; Check if file is readonly ..
    If StringInStr(FileGetAttrib($szFileName), "R") Then Return SetError(6, 0, -1)
    ;===============================================================================
    ;== Read the file into an array
    ;===============================================================================
    Local $hFile = FileOpen($szFileName, $FO_READ)
    If $hFile = -1 Then Return SetError(1, 0, -1)
    Local $s_TotFile = FileRead($hFile, FileGetSize($szFileName))
    If StringRight($s_TotFile, 2) = @CRLF Then
        $sEndsWith = @CRLF
    ElseIf StringRight($s_TotFile, 1) = @CR Then
        $sEndsWith = @CR
    ElseIf StringRight($s_TotFile, 1) = @LF Then
        $sEndsWith = @LF
    Else
        $sEndsWith = ""
    EndIf
    Local $aFileLines = StringSplit(StringStripCR($s_TotFile), @LF)
    FileClose($hFile)
    ;===============================================================================
    ;== Open the output file in write mode
    ;===============================================================================
    Local $iEncoding = FileGetEncoding($szFileName)
    Local $hWriteHandle = FileOpen($szFileName, $iEncoding + $FO_OVERWRITE)
    If $hWriteHandle = -1 Then Return SetError(2, 0, -1)
    ;===============================================================================
    ;== Loop through the array and search for $szSearchString
    ;===============================================================================
    For $nCount = 1 To $aFileLines[0]
        If StringInStr($aFileLines[$nCount], $szSearchString, $fCaseness) Then
            $iRetVal = $iRetVal + 1
            If $fOccurance = $iRetVal Then
                $aFileLines[$nCount] = StringReplace($aFileLines[$nCount], $szSearchString, $szReplaceString, 1 - $fOccurance, $fCaseness)
                ExitLoop
            EndIf
        EndIf
    Next
    ;===============================================================================
    ;== Write the lines back to original file.
    ;===============================================================================
    FileClose($hWriteHandle)
    Local $Tempfile = _TempFile()
    FileWrite($Tempfile, _ArrayToString($aFileLines, @LF, 1))
    FileMove($Tempfile, $szFileName, 1)
    Return $iRetVal
EndFunc   ;==>__ReplaceStringInFile

Yes, I know guinness improved the ReplaceStringInFile function in terms of speed and  efficiency but hear me out. I made some changes to the original myself that increased the speed of the writing and more importantly for me change the occurrence option so the function would only replace that specific occurrence of string.

I not saying use my code. What I am suggesting is to add extra functionally to the ReplaceStringInFile so there is a option to replace a specific occurrence.

I could not think of a way to do this with the new one guinness made so above is just an example of how I did it with the old one.

I have also attached the file.au3 file.

File.au3

[JScript]

Every change is for the better, is welcome!

Thank you,

JS

[guinness]

Looking at the the code you assume every line ends with the same EOL character and then when you come to write the data to the file you just use a linefeed character. As for adding your suggestion, I don't feel it appeals to the wider audience. Thanks.