New SciTE4AutoIt3 available with SciTE v3.4.1

[mLipok]

Have you copied the updated common.lua as well?

 

bingo

I do not know how this could happen

Most important now that it seems that everything is in order

 

Cheers

mLipok

[FaridAgl]

Running Tidy on the following snippet:

#cs
    [Methods]
    Add = Adds a key and item pair to a Dictionary object.
    object.Add (key, item)

    Exists = Returns true if a specified key exists in the Dictionary object, false if it does not.
    object.Exists(key)
#ce

Will insert a TAB on line 5, and all other empty lines within the comment block.

[FaridAgl]

Also when the last line of the scipt is #ce, Tidy will add an empty line after that (Even when NewLine option is set to 0).

[Jos]

This was actually reported earlier this week via email by somebody else and is fixed in my current unpublished version of Tidy.

Thanks,

Jos

[mLipok]

Today I had a busy day.
Many times, someone interrupted me, the process of writing the program.

The result was a piece of code that was not correct.

Interestingly AU3Check (3.3.10.2) does not detect this error.
After a brief analysis, it can be concluded that AU3Check not always well analyzed lines of code in which there is only one word. The significance of this line of code lies in the fact that this is the keyword / name of the function.

HOWTO: for example in script, please simply enter the MsgBox and try to see the script with AU3Check

example REPRO below:

Local $i = 1
MsgBox
Local $j = 2

At first glance, it seems that this problem is easy to diagnose.
After a moment's thought is, it turns out that if such a mistake will be included somewhere in the depths of an extensive code, finding that the error is only possible thanks to a happy coincidence, or by an error during the execution of the program.

Is it possible to improve AU3Check in this regard?

 

mLipok

edit:

On reflection, I think it probably was not the right thread?
Sorry.

Edited May 15, 2014 by mLipok

[Melba23]

mLipok,

This problem arises because functions are now first class objects and so the following syntax is valid:

$sMsgBox = MsgBox

I have no idea if Jos can adjust Au3Check to only permit function names without parentheses when they are assigned - or even if that is the solution required.

M23

[mLipok]

At first I wanted to admit you're right.
Then I wondered, and prepared a new example:
EXAMPLE1:

$sMsgBox = MsgBox
$sMsgBox
MsgBox

 
The first line is assigning the function to a variable.
The second line is a call to the above function by first assigning.
The third line is simply a single word
* Because it is not assigned a function to a variable - because no $ sign
* Because it is not a function call, because this would in such a case MsgBox (     -    I mean it must have a parenthesis
 
 
EXAMPLE2:

MsgBox
Testing

The first line is a keyword (function name), but as such can be considered only if it is used in an assignment to a variable, or if it is used with the bracket. Use only as one parenthesis cause analysis that keyword as a function.
For this reason should be treated the same as the second line, which is completely ordinary word.
 
 
EXAMPLE3:
best to let them speak a language known to all of us RegExp
below the "faulty code" example:

$sMsgBox = MsgBox
$sMsgBox
MsgBox
Testing
Testing_1

 
and the method of its verification, written by SRE:

; for multi line string
StringRegExp($sTestString, '(?<=\r)\s*[0-9a-z_A-Z]+\s*(?=\R)',3)
; for single line string
StringRegExp($sTestString, '\A\s*[0-9a-z_A-Z]+\s*\z',0)

 
Of course, I consider that I could be wrong, something does not know and does not perceive. But now I have this opinion.
Please continue further discussion with taking into account my little language skills.

mLipok

[Jos]

I have no idea if Jos can adjust Au3Check to only permit function names without parentheses when they are assigned - or even if that is the solution required.

Very unlikely that I look that sourcecode any time soon.

Maybe JP has some time to kill and an idea how to implement all of this.

Jos

[mLipok]

So I understand that my reasoning is correct?
If so, I am aware that my concept not necessarily be realized, at least not quickly.

[Jos]

So I understand that my reasoning is correct?

If so, I am aware that my concept not necessarily be realized, at least not quickly.

I have not looked at the details of your issue and only commented about trying to fix anything in au3check.

Never really enjoyed looked at that code and trying to figure out the FLEX&YACC stuff in it.

Jos

[mLipok]

Ok.

Thanks for clarification.

mLipok

[Jos]

Uploaded Tidy beta v 2.4.1.0 which has some major internal changes to be able to communicate better with SciTE:

- Changed the logic to restore the Folds, Bookmarks, initial line displayed and caret position to make it
      work on multiple instances of SciTE and better restore the original layout.
    - Fixed bug when using more than 200 include files.
    - Fixed writing Indent characters in Commentblocks for empty lines.
    - Fixed writing ending CRLF in case End_With_NewLine=0
    - Several minor fixes.

This version requires also an update in au3.properties.

[Melba23]

Jos,

 

Fixed bug when using more than 200 include files

200+ includes?

M23

[Jos]

Jos,

 

200+ includes?

M23

Yep...  there was a report of an issue with au3stripper which was caused by using more than 200 include files. Tidy had he same issue as the base code is partially the same.

Jos

[mLipok]

I see there is also new AutoIt3Wrapper.exe.

[Jos]

I see there is also new AutoIt3Wrapper.exe.

 

>yes

Jos

[FaridAgl]

Thanks for the updates, I have downloaded & replaced all of them right now.

I want to report 3 things:

1. You have fixed the problem regarding adding an empty line to the end of script when its #ce, but the same problem is there when the last line is a one line comment:

;

2. In the following script:

Global $aoArrayOfObjects[2]
$aoArrayOfObjects[0] = ObjCreate("Scripting.Dictionary")
$aoArrayOfObjects[1] = ObjCreate("Scripting.Dictionary")

$aoArrayOfObjects[0].Add("FirstName", "Farid")

ConsoleWrite($aoArrayOfObjects[0].Item("FirstName") & @CRLF)
ConsoleWrite($aoArrayOfObjects[1].Count & @CRLF)

Running Tidy will add an space after all . characters in line 5, 7 and 8.

Global $aoArrayOfObjects[2]
$aoArrayOfObjects[0] = ObjCreate("Scripting.Dictionary")
$aoArrayOfObjects[1] = ObjCreate("Scripting.Dictionary")

$aoArrayOfObjects[0] .Add("FirstName", "Farid")

ConsoleWrite($aoArrayOfObjects[0] .Item("FirstName") & @CRLF)
ConsoleWrite($aoArrayOfObjects[1] .Count & @CRLF)

3. In the following script:

Global $afArrayOfFunctions[2]
$afArrayOfFunctions[0] = Foo
$afArrayOfFunctions[1] = Bar

$afArrayOfFunctions[0]()
$afArrayOfFunctions[1]()

Func Foo()
    ConsoleWrite("Foo" & @CRLF)
EndFunc

Func Bar()
    ConsoleWrite("Bar" & @CRLF)
EndFunc

Running Tidy will add an space before () on line 5 and 6:

Global $afArrayOfFunctions[2]
$afArrayOfFunctions[0] = Foo
$afArrayOfFunctions[1] = Bar

$afArrayOfFunctions[0] ()
$afArrayOfFunctions[1] ()

Func Foo()
    ConsoleWrite("Foo" & @CRLF)
EndFunc

Func Bar()
    ConsoleWrite("Bar" & @CRLF)
EndFunc

Thanks Jos, I don't know what would happen if you weren't here   

[Jos]

Uploaded Tidy beta v2.4.1.1 which should fix the above reported issues.

Cheers

Jos

[FaridAgl]

Confirm as fixed.

Thanks.

[jaberwacky]

I noticed that skip_commentblock can be set via command line parameter.  When I set it through tidy.ini it doesn't seem to work.  This particular parameter isn't documented as far as I could tell.  Am I using the right thing? Or am I completely in the wrong?