Help with If/Then

[brian75]

Hello all,

I'm writing a script that will perform various tasks based on the model number of the machine on which it is run.  I am dealing with three different models CF-53AU, CF-53AS, and CF-53SU.  The script works for the AU and AS models (they run only the part they need to run) but the SU runs the AS/AU part of the script in addition to what it should run.  They are all reading the model number correctly.  Anyone see what I am doing wrong?

expandcollapse popup

#include <FileConstants.au3>

$wbemFlagReturnImmediately = 0x10
$wbemFlagForwardOnly = 0x20
$colItems = ""
$strComputer = "localhost"

$objWMIService = ObjGet("winmgmts:\\" & $strComputer & "\")
$colItems = $objWMIService.ExecQuery("SELECT * FROM Win32_ComputerSystem", "WQL", _
                                          $wbemFlagReturnImmediately + $wbemFlagForwardOnly)

For $objItem In $colItems

$model = $objItem.Model

Next


$first7char = StringMid ($model, 1, 7)
$CF53SU = "CF-53SU"
$CF53AS = "CF-53AS"
$CF53AU = "CF-53AU"


Func _CF53AU_AS()
    SplashTextOn ("Please Wait", "I'm a CF-53AU or CF-53AS", 300, 200, 1, 1, "", 9, 20)
    Sleep (5000)
    SplashOff()
EndFunc

Func _CF53SU()
    SplashTextOn ("Please Wait", "I'm a CF-53SU", 300, 200, 1, 1, "", 9, 20)
    Sleep (5000)
    SplashOff()
EndFunc

If $first7char = $CF53AU Or $CF53AS Then _CF53AU_AS()
If $first7char = $CF53SU Then _CF53SU()

[BrewManNH]

This:

If $first7char = $CF53AU Or $CF53AS Then _CF53AU_AS()

Needs to be like this:

If $first7char = $CF53AU Or $first7char = $CF53AS Then _CF53AU_AS()

[tanahara]

If $first7char = $CF53AU Or $first7char = $CF53AS Then 
    _CF53AU_AS()
ElseIf $first7char = $CF53SU Then
    _CF53SU()
endif

The second comparison in the or has nothing to compare $CF53AS against. Correct me if im wrong autoit gurus. I always fully qualify my second condition. Try that.

Edit: By seconds lol Gj BreManNH

Edited March 14, 2014 by tanahara

[brian75]

Awesome, thanks to both of you!  Looks like both solutions would have worked.