This is my script, it seems not perfect, can you help me write a more perfect example of it?

[i2i8]

This is my script, it seems not perfect, can you help me write a more perfect example of it?

#include <File.au3>
Local $setFiles[13]
$setFiles[0] = @ScriptDir & "\idsdk.dll"
$setFiles[1] = @ScriptDir & "\sdk.dll"
$setFiles[2] = @ScriptDir & "\ProcSafe.exe"
$setFiles[3] = @ScriptDir & "\Safe.dll"
$setFiles[4] = @ScriptDir & "\BHOEx.dll"
$setFiles[5] = @ScriptDir & "\CServer.dll"
$setFiles[6] = @ScriptDir & "\vDiskBus.inf"
$setFiles[7] = @ScriptDir & "\vDiskBus.sys"
$setFiles[8] = @ScriptDir & "\nti.exe"
$setFiles[9] = @ScriptDir & "\GdiPlus.dll"
$setFiles[10] = @ScriptDir & "\data\ClientBrand.ini"
$setFiles[11] = @ScriptDir & "\data\GameSearchCfg.ini"
$setFiles[12] = @ScriptDir & "\processSafe\ProcessSafe.ini"
For $i = 0 To UBound($setFiles) -1
    If FileExists($setFiles[$i]) Then
    FileDelete($setFiles[$i])
ElseIf Not FileExists($setFiles[$i]) Then
    _FileCreate($setFiles[$i])
    Sleep(200)
    FileSetAttrib($setFiles[$i],"+RSH")
EndIf
Next
Local $SetACL_Set = "SetACL -on ",$copy_permissions = ' -ot file -actn setprot -op "dacl:p_c;sacl:p_c"',$remove_permissions = ' -ot file -actn clear -clr "dacl,sacl"',$iRead_ex = ' -ot file -actn ace -ace "n:Everyone;p:read_ex"'
For $i = 0 To UBound($setFiles) -1
    If FileExists($setFiles[$i]) Then
    RunWait(@ComSpec & " /c " & $SetACL_Set & $setFiles[$i] & $copy_permissions,"",@SW_HIDE)
    RunWait(@ComSpec & " /c " & $SetACL_Set & $setFiles[$i] & $remove_permissions,"",@SW_HIDE)
    RunWait(@ComSpec & " /c " & $SetACL_Set & $setFiles[$i] & $iRead_ex,"",@SW_HIDE)
    EndIf
Next
MsgBox(0,"Waiting......","Waiting......",3)

Run this script there is a problem, the first run, does not create an empty file with the same name, run it again, it can create $ setFiles function definitions for all files.Why?

Edited February 6, 2014 by i2i8

[FireFox]

Hi,

In your first For loop :

If FileExists Then
    DeleteFile << The file exists and is deleted
ElseIf Not FileExists Then
    FileCreate << The file does NOT exist and is created
EndIf

The code cannot pass from an If to another one, so either the file exists or it does not.

expandcollapse popup

#include <File.au3>
#include <Constants.au3>
 
Local $setFiles[13] = [ _
        "idsdk.dll", _
        "sdk.dll", _
        "ProcSafe.exe", _
        "Safe.dll", _
        "BHOEx.dll", _
        "CServer.dll", _
        "vDiskBus.inf", _
        "vDiskBus.sys", _
        "nti.exe", _
        "GdiPlus.dll", _
        "data\ClientBrand.ini", _
        "data\GameSearchCfg.ini", _
        "processSafe\ProcessSafe.ini"]
 
For $i = 0 To UBound($setFiles) - 1
    If FileExists(@ScriptDir & "\" & $setFiles[$i]) Then
        FileDelete(@ScriptDir & "\" & $setFiles[$i])
    EndIf
 
    ;the file is necessarily deleted
    _FileCreate(@ScriptDir & "\" & $setFiles[$i])
    ;Sleep(200) ;Why??
    FileSetAttrib(@ScriptDir & "\" & $setFiles[$i], "+RSH")
Next
 
Local $SetACL_Set = "SetACL -on"
Local $copy_permissions = '-ot file -actn setprot -op "dacl:p_c;sacl:p_c"'
Local $remove_permissions = '-ot file -actn clear -clr "dacl,sacl"'
Local $iRead_ex = '-ot file -actn ace -ace "n:Everyone;p:read_ex"'
 
For $i = 0 To UBound($setFiles) - 1
    If FileExists(@ScriptDir & "\" & $setFiles[$i]) Then ;this may be useless as the file is created before
        RunWait(@ComSpec & " /c " & $SetACL_Set & " " & @ScriptDir & "\" & $setFiles[$i] & " " & $copy_permissions, "", @SW_HIDE)
        RunWait(@ComSpec & " /c " & $SetACL_Set & " " & @ScriptDir & "\" & $setFiles[$i] & " " & $remove_permissions, "", @SW_HIDE)
        RunWait(@ComSpec & " /c " & $SetACL_Set & " " & @ScriptDir & "\" & $setFiles[$i] & " " & $iRead_ex, "", @SW_HIDE)
    EndIf
Next
 
MsgBox($MB_SYSTEMMODAL, "Waiting......", "Waiting......", 3)

Br, FireFox.

[i2i8]

Thank you very much FireFox, I will now try your script.

[water]

i2i8,

you have already a thread for this issue. Why don't you stick with that?

title="View Topic">Function definition files can be deleted, but can not create the same file?

[i2i8]

Sorry,Water.