string concantenation not working

[garysr59]

hello

For some odd reason, string concantenation in the script I am working on, does not work.

In a loop I am trying to add to a string with this command

$t &= $Array[$j]

$Array[$j] changes its value as the index is incremented, however $t never changes. It picks up the value at the first index and never changes as the loop is processed.

[DatMCEyeBall]

Show all your code perhaps you made a mistake somewhere else that causes this.

[Melba23]

garysr59,

That is no use at all - please post the whole script or at least the loop section. And please use Code tags when you do - see here how to do it.

M23

[garysr59]

do

; read into array from host
 $Array[$j] = StdoutRead($pID)

 

; cleanup the data
 $Array[$j] =StringReplace($Array[$j], "-", "")
 $Array[$j] =StringReplace($Array[$j], "Press any key to continue (Q to quit)", "" & @CR)
 $Array[$j] = StringStripWS($Array[$j], 4)
 $Array[$j] = StringReplace($Array[$j], "OK", "OK" & @CR)

 

;store into a variable
 $t &= $Array[$j]

 

;send - to the host to get next screen
 StdinWrite($pID, "-" & @CRLF)
 Sleep(300)
 $j = $j + 1

Until $j = 4

Edited January 7, 2014 by garysr59

[l3ill]

$t &= $Array[$j]
 ___^__________

Is this & intentional ?

[guinness]

garysr59,

Declare $t before the loop and see how that works out for you.

Edited January 7, 2014 by guinness

[garysr59]

Yes. Thought was the syntax for adding to the variable $t what is in the array

[garysr59]

$t is declared before the loop

Edited January 7, 2014 by garysr59

[iamtheky]

declare all else before the loop as well and add some debug:

#include <Array.au3>
Global $Array[4]  ;declare the array
$j = 0            ; set $j to the first element before you start the do loop
$t = ""           ; set $t before you start appending strings to nothing

do

; set data to array
 $Array[$j] = @HOUR & @MIN & @SEC & @MSEC

;do whatever
;then maybe see what it looks like
 _ArrayDisplay($Array)

;store into a variable
 $t &= $Array[$j] & @LF
;then maybe take a look at that
msgbox (0, '' , $t)

;then do whatever and sleep and increment
 Sleep(500)
 $j = $j + 1

Until $j = 4

Edited January 7, 2014 by boththose

[l3ill]

It seems to me that to concatenate $t with your var $t has to be holding something but it is an empty variable at this point.

Or am I missing the boat?

[garysr59]

Array.au3 is included, $Array[4],  $j = 0 and $t = "" have been declared previously

Adding a message box shown here

do

; read into array from host
 $Array[$j] = StdoutRead($pID)

 ; cleanup the data
 $Array[$j] =StringReplace($Array[$j], "-", "")
 $Array[$j] =StringReplace($Array[$j], "Press any key to continue (Q to quit)", "" & @CR)
 $Array[$j] = StringStripWS($Array[$j], 4)
 $Array[$j] = StringReplace($Array[$j], "OK", "OK" & @CR)
MsgBox(1, "value of array at " & $j, $Array[$j])  

;store into a variable
 $t &= $Array[$j]
MsgBox(1, "value of t ", $t)
 

;send - to the host to get next screen
 StdinWrite($pID, "-" & @CRLF)
 Sleep(300)
 $j = $j + 1

Until $j = 4

 

Array[$j] value first time is

"1.1 HPDD VDISK 300 GB OK"

"1.2 HPDD VDISK 300 GB OK"

 

$t value first time is

"1.1 HPDD VDISK 300 GB OK"

"1.2 HPDD VDISK 300 GB OK

Array[$j] value 2nd time is

"1.3 HPDD VDISK 300 GB OK"

"1.4 HPDD VDISK 300 GB OK"

 

$t value 2nd time is still

"1.1 HPDD VDISK 300 GB OK"

"1.2 HPDD VDISK 300 GB OK

 

The loop continues 2 more times. Everytime Array[$j] changes, but $t never does. I don't get it, $t should change

[KaFu]

How about something like this?

Local $i_timeout_timer

Do

    $i_timeout_timer = TimerInit()
    While Sleep(10)
        $Array[$j] &= StdoutRead($pID)
        If @error Then ExitLoop
        If TimerDiff($i_timeout_timer) > 10000 Then
            MsgBox(16, "Error", "StdoutRead timed out...")
            StdioClose($pID)
            ExitLoop 2
        EndIf
    WEnd

    ; cleanup the data
    $Array[$j] = StringReplace($Array[$j], "-", "")
    $Array[$j] = StringReplace($Array[$j], "Press any key to continue (Q to quit)", "" & @CR)
    $Array[$j] = StringStripWS($Array[$j], 4)
    $Array[$j] = StringReplace($Array[$j], "OK", "OK" & @CR)
    ; MsgBox(1, "value of array at " & $j, $Array[$j])

    ;store into a variable
    $t &= $Array[$j]
    ; MsgBox(1, "value of t ", $t)

    ;send - to the host to get next screen
    StdinWrite($pID, "-" & @CRLF)
    ; Sleep(300)
    $j = $j + 1

Until $j = 4

StdioClose($pID)

[garysr59]

That's nice but $t still doesn't add the array values

[Melba23]

garysr59,

Firstly, I have lifted you "New Member" posting restriction - so keep on posting.

Now, here is your script with a preset array and for me the concatenation works perfectly - I presume it will for you too:

expandcollapse popup

Local $i_timeout_timer

Global $Array[4] = ["A", "B", "C", "D"], $j = 0, $t = ""

Do

#cs
    $i_timeout_timer = TimerInit()
    While Sleep(10)
        $Array[$j] &= StdoutRead($pID)
        If @error Then ExitLoop
        If TimerDiff($i_timeout_timer) > 10000 Then
            MsgBox(16, "Error", "StdoutRead timed out...")
            StdioClose($pID)
            ExitLoop 2
        EndIf
    WEnd
#ce
    ; cleanup the data
    ;$Array[$j] = StringReplace($Array[$j], "-", "")
    ;$Array[$j] = StringReplace($Array[$j], "Press any key to continue (Q to quit)", "" & @CR)
    ;$Array[$j] = StringStripWS($Array[$j], 4)
    ;$Array[$j] = StringReplace($Array[$j], "OK", "OK" & @CR)
    ; MsgBox(1, "value of array at " & $j, $Array[$j])

    ;store into a variable
    $t &= $Array[$j]
    ; MsgBox(1, "value of t ", $t)

    ;send - to the host to get next screen
    ;StdinWrite($pID, "-" & @CRLF)
    ; Sleep(300)
    $j = $j + 1

Until $j = 4

ConsoleWrite($t & @CRLF)

;StdioClose($pID)

So I suggest the problem is that you are ending up with an empty string after you have read and cleaned the StdoutRead. Have you tried a ConsoleWrite or MsgBox to see what you are actually trying to concatenate?

M23

[iamtheky]

msgbox(0, '' , StdoutRead($pID))  first.  if there are no contents expect blanks.

 

*or add a seperator and have a visual

$t &= $Array[$j] & ":"

 

if you see three colons in a row they were blanks

Edited January 7, 2014 by boththose

[garysr59]

Yes I can do the same with a prefilled array. Concatenation works. However it doesn't work with an array picking up its values from a StdoutRead. Going back to my code, msgbox right after the read shows

 $Array[$j] = StdoutRead($pID)
MsgBox(1, "value of array at " & $j, $Array[$j]) 

 

Array[$j] value first time is

"1.1 HPDD VDISK 300 GB OK"

"1.2 HPDD VDISK 300 GB OK"

Array[$j] value 2nd time is

"1.3 HPDD VDISK 300 GB OK"

"1.4 HPDD VDISK 300 GB OK"

this works as expected thru the loop. It is the concatenation of the array contents to a single variable that doesn't work

$t &= $Array[$j]
MsgBox(1, "value of t ", $t)

$t value all time thru the loop remains at

"1.1 HPDD VDISK 300 GB OK"

"1.2 HPDD VDISK 300 GB OK

 

[Gianni]

maybe there is a chr(0) in the string $t after the second OK

"300 GB 1.1 HPDD VDISK OK"

"300 GB 1.2 HPDD VDISK OK <- here maybe there is a chr(0)

to test try to use this (flag 8 instead of 4):

$Array[$j] = StringStripWS($Array[$j], 8)

edit:

or also try to add another one cleanup statement after the others like this:

$Array[$j] = StringReplace($Array[$j], chr(0), "")

Edited January 8, 2014 by PincoPanco

[garysr59]

Adding a seperator did the trick. Though I could swear I tried that 

Cheerio and thanks for all your help  

[Gianni]

Adding a seperator did the trick. Though I could swear I tried that 

Cheerio and thanks for all your help  

 

therefore, I would be interested to know what was the cause of the problem please

for what reason the strings were not concatenated?