Quote problem

[JerichoJones]

I have a function that I have created but when I pass the string below it seems to think there are 4 args instead of three. This has worked for every app so far except this one.

InstallApp("NO", "WLSetup-all.exe", "/q /NOToolbarCEIP /NOhomepage /Nolaunch /nosearch /AppSelect:Photo,MovieMaker,Writer", 9)

It seems to think it is this:

InstallApp("NO", "WLSetup-all.exe", "/q /NOToolbarCEIP /NOhomepage /Nolaunch /nosearch", " /AppSelect:Photo,MovieMaker,Writer", 9)

What am I missing?

[jdelaney]

We don't have access to your function, so can't comment on how the variables passed in are combined and executed.

[JerichoJones]

We don't have access to your function, so can't comment on how the variables passed in are combined and executed.

 

Why do you need that? It doesn't even get there. It complains during compile that it is getting 4 args when only three are supported. I can add the code. I just don't see the need.

[Jos]

The first line has 4 parameters and the second has 5 parameters.

Show an example that demo's the issue.

Jos

Edited December 24, 2013 by Jos

[jdelaney]

Well there you go.  If you had posted that to begin with, we would have had a better jumping off point:

Why do you need that? It doesn't even get there. It complains during compile that it is getting 4 args when only three are supported. I can add the code. I just don't see the need.

 

You can't call functions with more parameters than present.

You can't call functions with less parameters than required (exceptions when they have default assignments)

Post the function (at least the first line of it, where the variables are decalred)

I don't know what you are expecting with the fourth param, but you already answered your question by passing in three.

Edited December 24, 2013 by jdelaney

[JerichoJones]

The first line has 3 parameters and the second has 4.

Show an example that demo's the issue.

Jos

InstallApp("NO", "WLSetup-all.exe", "/q /NOToolbarCEIP /NOhomepage /Nolaunch /nosearch /AppSelect:Photo,MovieMaker,Writer", 9)

Func InstallApp($IsMSI, $Installer, $Switches)
    If $IsMSI = "YES" Then
        ConsoleWrite("Installing " & $Installer & @CRLF)
        Local $Install = RunWait("MsiExec.exe /i " & Chr(34) & $Installer & Chr(34) & " " & $Switches & " /qn /Log C:\Temp\" & $Installer & ".log")
        If $Install = 0 Or $Install = 3010 Then
            WriteLog($Install, $Installer & @TAB & "Success")
            ConsoleWrite("Installation Successful" & @CRLF)
        Else
            WriteLog($Install, $Installer & @TAB & "Failed")
            ConsoleWrite("Installation Failed" & @CRLF)
        EndIf
    Else
        ConsoleWrite("Installing " & $Installer & @CRLF)
        Local $Install = RunWait(@ScriptDir & "\" & $Installer & " " & $Switches)
        If $Install = 0 Or $Install = 3010 Then
            WriteLog($Install, $Installer & @TAB & "Success")
            ConsoleWrite("Installation Successful" & @CRLF)
        Else
            WriteLog($Install, $Installer & @TAB & "Failed")
            ConsoleWrite("Installation Failed" & @CRLF)
        EndIf
    EndIf
EndFunc   ;==>InstallApp

I get this error on compile:

E:InstallWE.au3(27,47) : ERROR: InstallApp() called by a previous line with 4 arg(s). Max = 3. First previous line calling this Func is 19.

[jdelaney]

What are you expecting the fourth param to do.  You'll need to add some additional parameter to your function, or remove it from the call to the function.

[JerichoJones]

What are you expecting the fourth param to do.  You'll need to add some additional parameter to your function, or remove it from the call to the function.

It should be three. For some reason it thinks it is four. The first line is the one that should work. There are only three args.

[jdelaney]

From post #6:

InstallApp("NO", "WLSetup-all.exe", "/q /NOToolbarCEIP /NOhomepage /Nolaunch /nosearch /AppSelect:Photo,MovieMaker,Writer", 9)
 

change to:

InstallApp("NO", "WLSetup-all.exe", "/q /NOToolbarCEIP /NOhomepage /Nolaunch /nosearch /AppSelect:Photo,MovieMaker,Writer")
 

[BrewManNH]

There are 4 arguments in your call to it

"NO"

"WLSetup-all.exe"

"/q /NOToolbarCEIP /NOhomepage /Nolaunch /nosearch /AppSelect:Photo,MovieMaker,Writer"

9

One of those has to go, or you need to quote something.

[JerichoJones]

DOH!!!!

Typo. Now I see why the code was needed.