I have a strange problem in my code ..

[Guest]

Hello,

I wrote a function that handles a array variable with duplicates ..

this is the example code:

expandcollapse popup

#include <Array.au3>


Local $aTest[5+1]
$aTest[1] = "aaa"
$aTest[2] = "ccc"
$aTest[3] = "aaa"
$aTest[4] = "ccc"
$aTest[5] = "ddd"
$aTest[0] = 5


_ArrayDisplay($aTest,"Array before removing duplicates:")
$aTest = ArrayRemoveDuplicates($aTest,1)
_ArrayDisplay($aTest,"Array after removing duplicates:")



Func ArrayRemoveDuplicates($aArray,$StartIndex = 1,$EndIndex = "")
    Local $IndexSearch
    If $EndIndex = "" Then $EndIndex = UBound($aArray)-1
    ;MsgBox(0,"",$EndIndex)
    For $a = $StartIndex-1 To $EndIndex
        Do
            If $a < 0 Then $a = 0
            $IndexSearch = ArraySearch4($aArray,$aArray[$a],$a,$StartIndex)
            If $IndexSearch >= 0 Then
                _ArrayDelete($aArray,$IndexSearch)
                $EndIndex = $EndIndex-1
                $a = $a-1
            EndIf
        Until $IndexSearch < 0
        If $a = $EndIndex Then ExitLoop
    Next
    Return $aArray
EndFunc



Func ArraySearch4($aArray, $SubVar , $IgnoreIndex = -1, $StartIndex = 1, $EndIndex = 1)
    Local $OutPut = -1
    If $EndIndex = 1 Then $EndIndex = UBound($aArray) - 1
    If $IgnoreIndex = "" Then $IgnoreIndex = -1
    If $StartIndex <= $EndIndex Then
        For $a = $StartIndex To $EndIndex
            If $a <> $IgnoreIndex Then
                If $aArray[$a] = $SubVar Then
                    $OutPut = $a
                    ExitLoop
                EndIf
            EndIf
        Next
    EndIf
    Return $OutPut
EndFunc   ;==>ArraySearch4

the problem is with ArrayRemoveDuplicates

$StartIndex is the start range in the array to look for duplicates and delete them.

$EndIndex  is the end range in the array to look for duplicates and delete them.

 

this function works as expected in this case. But if $StartIndex is 0 then everything crashes ..

try to replace

$aTest = ArrayRemoveDuplicates($aTest,1)

with:

$aTest = ArrayRemoveDuplicates($aTest,0)

 and you will see the problem.

i dno't know why it is happen..

thanks for helpers!

Edited December 8, 2013 by Guest

[guinness]

What's wrong with _ArrayUnique()?

[Guest]

What's wrong with _ArrayUnique()?

It will do exactly what I want?

Anyway I want to know what the problem is ..

It drives me crazy.

Thanks for the help

Edited December 8, 2013 by Guest

[guinness]

Well if your aim is to create an array without duplicate data, then the answer is yes.

[AutID]

#include <Array.au3>

Local $aTest[5+1]
$aTest[1] = "aaa"
$aTest[2] = "ccc"
$aTest[3] = "aaa"
$aTest[4] = "ccc"
$aTest[5] = "ddd"
$aTest[0] = 5

_ArrayDisplay($aTest,"Array before removing duplicates:")
Local $aNewArray = _ArrayUnique($aTest)
_ArrayDelete($aNewArray, 0)
_ArrayDisplay($aNewArray,"Array after removing duplicates:")

Edited December 8, 2013 by AutID

[water]

It will do exactly what I want?

Why don't you try to read the help file? That should always be your first choice! That's one of the easiest ways to learn AutoIt.

[Guest]

Ok thanks ..

Now I understand why it happened. It was a logic problem.

thanks but i prefer to do things alone without using other functions.
But if I know the function _ArrayUnique before, I was not trying make this function.

Edited December 8, 2013 by Guest

[water]

thanks but i prefer to do things alone without using other functions.

Why?

But you are not very consistant. You use _ArrayDelete in your code. So you could use _ArrayUnique as well. It's from the same UDF.

[guinness]

thanks but i prefer to do things alone without using other functions.

There was another user who thought like this and it stunted their growth within AutoIt. Good luck with that.

Edit: To add to water's point, _ArrayDelete() adds a great deal of execution time to your script and is generally used for those who no little about the Array datatype.

Edited December 8, 2013 by guinness

[iamtheky]

_ArrayDelete() adds a great deal of execution time to your script and is generally used for those who no little about the Array datatype, or more correlative, those who have no concern for execution time and find it effective and easy to maintain?

[Guest]

Why?

But you are not very consistant. You use _ArrayDelete in your code. So you could use _ArrayUnique as well. It's from the same UDF.

That's why this specific case I'll use _ArrayUnique .

thanks for the help!

[guinness]

_ArrayDelete() adds a great deal of execution time to your script and is generally used for those who no little about the Array datatype, or more correlative, those who have no concern for execution time and find it effective and easy to maintain?

Pretty much the same words I used -_0

[Guest]

^ Good to know this.
This is something new to me..

[water]

If you have a look at the _ArrayDelete function you will see that it moves all entries following the deleted entry to fill the "gap".

That's what eats up the CPU.

[Guest]

Well. In my case, my script handles Array table once every 60 seconds and only in a specific mode. So it's not so bad. But anyway I probably will change some areas of my script after I know about it.