For loop error

[Reinhardt1julian]

So I have a for loop in my code which is basically like this:

For $x = 1 to _GUICtrlListView_GetItemCount($List1data)
    MsgBox(0,"",$x&" of "&_GUICtrlListView_GetItemCount($List1data))
    ;some stuff here
Next

But it's stuck on $x = 1 and it won't change

Why?

Edited December 4, 2013 by Reinhardt1julian

[guinness]

What does _GUICtrlListView_GetItemCount() return?

[Melba23]

Reinhardt1julian,

The problem is obvious - in line 35829 you are not furgling the qualopper.

;....

Seriously, what on earth do you expect us to say when faced with a small syntactically incorrect snippet like that? Post the whole code and then you might stand a chance of getting a sensible answer.

m23

[Reinhardt1julian]

It returns 46. I even tried to set the getItemCount as a variable before, add one and remove one to make sure it is an integer. But that didn't work either

[guinness]

I agree with Melba23, I reckon there is more to this than just that code above.

[Reinhardt1julian]

Reinhardt1julian,

The problem is obvious - in line 35829 you are not furgling the qualopper.

;....

Seriously, what on earth do you expect us to say when faced with a small syntactically incorrect snippet like that? Post the whole code and then you might stand a chance of getting a sensible answer.

m23

 

I know that it isn't that much. But my whole code is 1400 lines and the for loop alone is 150 lines. And

[guinness]

the for loop alone is 150 lines.

Then it's probably further inside that For loop which is the issue. Why not work backwards and learn the art of debugging.

[jdelaney]

Works fine for me.  Added your snippet into the base help file example

#include <GUIConstantsEx.au3>
#include <GuiListView.au3>

$Debug_LV = False ; Check ClassName being passed to ListView functions, set to True and use a handle to another control to see it work

_Main()

Func _Main()
    Local $hListView

    GUICreate("ListView Get Item Count", 400, 300)
    $hListView = GUICtrlCreateListView("col1|col2|col3", 2, 2, 394, 268)
    GUISetState()

    GUICtrlCreateListViewItem("line1|data1|more1", $hListView)
    GUICtrlCreateListViewItem("line2|data2|more2", $hListView)
    GUICtrlCreateListViewItem("line3|data3|more3", $hListView)
    GUICtrlCreateListViewItem("line4|data4|more4", $hListView)
    GUICtrlCreateListViewItem("line5|data5|more5", $hListView)

;~     MsgBox(4160, "Information", "Item Count: " & _GUICtrlListView_GetItemCount($hListView))

    ; Loop until user exits
    For $x = 1 to _GUICtrlListView_GetItemCount($hListView)
        MsgBox(0,"",$x&" of "&_GUICtrlListView_GetItemCount($hListView))
        ;some stuff here
    Next

    GUIDelete()
EndFunc   ;==>_Main

I bet, somewhere in your loop, you are setting x=x-1, or x-=1, so you never get above 1...or you have nested loops, both using the same variable (easy mistake in large loops).

example of that:

expandcollapse popup

#include <GUIConstantsEx.au3>
#include <GuiListView.au3>

$Debug_LV = False ; Check ClassName being passed to ListView functions, set to True and use a handle to another control to see it work

_Main()

Func _Main()
    Local $hListView

    GUICreate("ListView Get Item Count", 400, 300)
    $hListView = GUICtrlCreateListView("col1|col2|col3", 2, 2, 394, 268)
    GUISetState()

    GUICtrlCreateListViewItem("line1|data1|more1", $hListView)
    GUICtrlCreateListViewItem("line2|data2|more2", $hListView)
    GUICtrlCreateListViewItem("line3|data3|more3", $hListView)
    GUICtrlCreateListViewItem("line4|data4|more4", $hListView)
    GUICtrlCreateListViewItem("line5|data5|more5", $hListView)

;~     MsgBox(4160, "Information", "Item Count: " & _GUICtrlListView_GetItemCount($hListView))

    ; Loop until user exits
;~  For $x = 1 to _GUICtrlListView_GetItemCount($hListView)
;~      MsgBox(0,"",$x&" of "&_GUICtrlListView_GetItemCount($hListView))
;~      ;some stuff here
;~  Next

    ; Loop until user exits
    For $x = 1 to _GUICtrlListView_GetItemCount($hListView)
        If MsgBox(1,"",$x&" will always be one...cancel to exit.") > 1 Then Exit
        $x-=1
        ;some stuff here
    Next

    GUIDelete()
EndFunc   ;==>_Main

If none of those help, then post your code ...or at least code that reproduces it.

Edited December 4, 2013 by jdelaney

[Reinhardt1julian]

If you guys fins any problems in this code, tell me, but I will try to find it, too

expandcollapse popup

;this won't run, because it needs a file
For $x = 1 to _GUICtrlListView_GetItemCount($List1data)
        $line = FileReadLine($tempFile, $x)
        MsgBox(0,"",$x&" of "&_GUICtrlListView_GetItemCount($List1data))
        If $line = "0" Then
            If _checkmess(_GUICtrlListView_GetItemTextString($List1data, $x-1),$x-1,$tag3) AND StringInStr($used,"'"&$x-1&"'") = 0 Then
                Global $zero
                $zero[$zeronum] = $x-1
                $zeronum = $zeronum + 1
            Else
            EndIf
        ElseIf $line = "1" Then
            If _checkmess(_GUICtrlListView_GetItemTextString($List1data, $x-1),$x-1,$tag3) AND StringInStr($used,"'"&$x-1&"'") = 0 Then
                Global $one
                $one[$onenum] = $x-1
                $onenum = $onenum + 1
            Else
            EndIf
        ElseIf $line = "2" Then
            If _checkmess(_GUICtrlListView_GetItemTextString($List1data, $x-1),$x-1,$tag3) AND StringInStr($used,"'"&$x-1&"'") = 0 Then
                Global $two
                $two[$twonum] = $x-1
                $twonum = $twonum + 1
            Else
            EndIf
        ElseIf $line = "3" Then
            If _checkmess(_GUICtrlListView_GetItemTextString($List1data, $x-1),$x-1,$tag3) AND StringInStr($used,"'"&$x-1&"'") = 0 Then
                Global $three
                $three[$threenum] = $x-1
                $threenum = $threenum + 1
            Else
            EndIf
        ElseIf $line = "4" Then
            If _checkmess(_GUICtrlListView_GetItemTextString($List1data, $x-1),$x-1,$tag3)AND StringInStr($used,"'"&$x-1&"'") = 0 Then
                Global $four
                $four[$fournum] = $x-1
                $fournum = $fournum + 1
            Else
            EndIf
        ElseIf $line = "5" Then
            If _checkmess(_GUICtrlListView_GetItemTextString($List1data, $x-1),$x-1,$tag3) AND StringInStr($used,"'"&$x-1&"'") = 0 Then
                Global $five
                $five[$fivenum] = $x-1
                $fivenum = $fivenum + 1
            Else
            EndIf
        ElseIf $line = "6" Then
            If _checkmess(_GUICtrlListView_GetItemTextString($List1data, $x-1),$x-1,$tag3) AND StringInStr($used,"'"&$x-1&"'") = 0 Then
                Global $six
                $six[$sixnum] = $x-1
                $sixnum = $sixnum + 1
            Else
            EndIf
        ElseIf $line = "7" Then
            If _checkmess(_GUICtrlListView_GetItemTextString($List1data, $x-1),$x-1,$tag3) AND StringInStr($used,"'"&$x-1&"'") = 0 Then
                Global $seven
                $seven[$sevennum] = $x-1
                $sevennum = $sevennum + 1
            Else
            EndIf
        ElseIf $line = "8" Then
            If _checkmess(_GUICtrlListView_GetItemTextString($List1data, $x-1),$x-1,$tag3) AND StringInStr($used,"'"&$x-1&"'") = 0 Then
                Global $eight
                $eight[$eightnum] = $x-1
                $eightnum = $eightnum + 1
            Else
            EndIf
        ElseIf $line = "9" Then
            If _checkmess(_GUICtrlListView_GetItemTextString($List1data, $x-1),$x-1,$tag3) AND StringInStr($used,"'"&$x-1&"'") = 0 Then
                Global $nine
                $nine[$ninenum] = $x-1
                $ninenum = $ninenum + 1
            Else
            EndIf
        Else
        EndIf
        ;MsgBox(0,"",$zeronum&" - "&$onenum&" - "&$twonum&" - "&$threenum&" - "&$fournum&" - "&$fivenum&" - "&$sixnum&" - "&$sevennum&" - "&$eightnum&" - "&$ninenum)
        While 1
            If $zeronum > 0 Then
                If $zeronum = 1 Then
                    Return $zero[0]
                Else
                    Return $zero[Random(0,$zeronum-1)]
                EndIf
            ElseIf $onenum > 0 Then
                If $onenum = 1 Then
                    Return $one[0]
                Else
                    Return $one[Random(0,$onenum-1)]
                EndIf
            ElseIf $twonum > 0 Then
                If $twonum = 1 Then
                    Return $two[0]
                Else
                    Return $two[Random(0,$twonum-1)]
                EndIf
            ElseIf $threenum > 0 Then
                If $threenum = 1 Then
                    Return $three[0]
                Else
                    Return $three[Random(0,$threenum-1)]
                EndIf
            ElseIf $fournum > 0 Then
                If $fournum = 1 Then
                    Return $four[0]
                Else
                    Return $four[Random(0,$fournum-1)]
                EndIf
            ElseIf $fivenum > 0 Then
                If $fivenum = 1 Then
                    Return $five[0]
                Else
                    Return $five[Random(0,$fivenum-1)]
                EndIf
            ElseIf $sixnum > 0 Then
                If $sixnum = 1 Then
                    Return $six[0]
                Else
                    Return $six[Random(0,$sixnum-1)]
                EndIf
            ElseIf $sevennum > 0 Then
                If $sevennum = 1 Then
                    Return $seven[0]
                Else
                    Return $seven[Random(0,$sevennum-1)]
                EndIf
            ElseIf $eightnum > 0 Then
                If $eightnum = 1 Then
                    Return $eight[0]
                Else
                    Return $eight[Random(0,$eightnum-1)]
                EndIf
            ElseIf $ninenum > 0 Then
                If $ninenum = 1 Then
                    Return $nine[0]
                Else
                    Return $nine[Random(0,$ninenum-1)]
                EndIf
            Else
                Return False
            EndIf
        WEnd
    Next

[Melba23]

Reinhardt1julian,

Do you have another loop inside that one which also uses $x as its variable? Perhaps you are resetting the count inside the loop to a high ennough value that when you get to the final Next you fall through rather than looping back.

M23

Edit: "Post" button pressed before the code above appeared.

Edited December 4, 2013 by Melba23

[Reinhardt1julian]

Reinhardt1julian,

Do you have another loop inside that one which also uses $x as its variable? Perhaps you are resetting the count inside the loop to a high ennough value that when you get to the final Next you fall through rather than looping back.

M23

 

Doesn't seem like it. I postet the whole loop. And i can't find any other $x in the3 code except in the for loop.

[jdelaney]

You should look into functions to reduce the need to repeat blocks of the exact same code like that.

[DW1]

The only way out of your while loop is "Return" so I guess this is inside a function.  If you are returning, then you are ending the function completely, both the For loop and the While loop.

EDIT: In other words, there is no way for the script to ever make it to "Next".

Edited December 4, 2013 by DW1

[Reinhardt1julian]

The only way out of your while loop is "Return" so I guess this is inside a function.  If you are returning, then you are ending the function completely, both the For loop and the While loop.

EDIT: In other words, there is no way for the script to ever make it to "Next".

 

Oh my god, thank you! That was such a stupid mistake to make :/