SciTe + TIDY - #region #endregion - issue ?

[mLipok]

I had a problem with the directive # region # endregion

Here I present a brief example of malfunction TIDY (or at least I think)

#region testing1
#endregion testing1

#region-testing2
#endregion testing1

[Jos]

It would help when you define what the problem is and what version you run, but I guess your issue is that the last #Endregion is changed and the comment is removed?

[FireFox]

I see a hyphen here: #region-testing2

Edited August 17, 2013 by FireFox

[Jos]

I see a hyphen here: #region-testing2

I know why happens what I described, but first like to understand what people are asking.

[Jos]

@mlipok, I had a look at Tidy and see there is a discrepancy between the SciTE lexer logic and Tidy's way of checking for #Region and #EndRegion.

I have updated the current Beta version of Tidy to support other delimiters than a Space to recognise #Region and #EndRegion.

Edit: re-uploaded to avoid some debug messages still being displayed.

Cheers,

Jos

Edited August 17, 2013 by Jos

[mLipok]

Jos

I'm sorry but I have not had too much time.

Now I can only confirm that the change You did in new TIDY works flawlessly.

 

Below the correct result of the operation of the new TIDY

#region testing1
#endregion testing1

#region-testing2
#endregion-testing2

[mLipok]

btw.

I just checked one of my scripts (previously checked just an example).

I've made myself the job.

 

"c:MyScript.au3"(193) : ### Tidy Warning -> #EndRegion statements without #Region.

"c:MyScript.au3"(474) : ### Tidy Warning -> #EndRegion statements without #Region.

"c:MyScript.au3"(3694) : ### Tidy Warning -> #EndRegion statements without #Region.

"c:MyScript.au3"(5380) : ### Tidy Warning -> #EndRegion statements without #Region.

"c:MyScript.au3"(5403) : ### Tidy Warning -> #EndRegion statements without #Region.

"c:MyScript.au3"(5446) : ### Tidy Warning -> #EndRegion statements without #Region.

"c:MyScript.au3"(5929) : ### Tidy Warning -> #EndRegion statements without #Region.

"c:MyScript.au3"(6099) : ### Tidy Warning -> #EndRegion statements without #Region.

"c:MyScript.au3"(6120) : ### Tidy Warning -> #EndRegion statements without #Region.

"c:MyScript.au3"(6141) : ### Tidy Warning -> #EndRegion statements without #Region.

[mLipok]

This effect was due to the fact that in the middle of the script was one #endregion too much.

EDIT:

Something like that

#region testing1
#endregion testing1

#endregion
#region-testing2
#endregion-testing2 

EDIT2:

added line numbers to the example

Edited August 17, 2013 by mlipok

[Jos]

A check was added to Tidy to report these type of issues.

Jos

[mLipok]

In the example in the previous post I noticed one thing that could be further improved in TIDY

>"C:Program Files (x86)AutoIt3SciTEtidytidy.exe" "L:TOOLsMacrotest TIDY.au3"

Tidy AutoIt3 v2.3.0.15   Copyright © Jos van der Zande  August 17, 2013

"L:TOOLsMacrotest TIDY.au3"(4) : ### Tidy Warning -> #EndRegion statements without #Region.

"L:TOOLsMacrotest TIDY.au3"(6) : ### Tidy Warning -> #EndRegion statements without #Region.

+> Tidy AutoIt3 finished and has no updates to make!

>Exit code: 0    Time: 0.116

 

Or simply I do not get it, because I do not understand why it appeared the message:

 "L:TOOLsMacrotest TIDY.au3"(6) : ### Tidy Warning -> #EndRegion statements without #Region.

[Jos]

Agree, will have a look why that is happening.

[mLipok]

Jos

Thanks

btw. in

 

"c:MyScript.au3"(193) : ### Tidy Warning -> #EndRegion statements without #Region.

"c:MyScript.au3"(474) : ### Tidy Warning -> #EndRegion statements without #Region.

"c:MyScript.au3"(3694) : ### Tidy Warning -> #EndRegion statements without #Region.

...

....

 

 

 

Only first Warning was true.

All the others were wrongly listed by TIDY

So thank You in advance for cooperation, and eagerly check your results  on TIDY  

[Jos]

Try the current beta to see if that solves them all.

Thanks

Jos

[mLipok]

It's working.

Although I have further thoughts in this area

I will explain in a moment.

[mLipok]

I trying this script

#region testing1
#endregion testing1

#endregion testing bad endregion
#region-testing2
#endregion-testing2

Why do that something:

#region testing1
#endregion testing1

#endregion
#region-testing2
#endregion-testing2

and console:

 

>"C:Program Files (x86)AutoIt3SciTEtidytidy.exe" "L:TOOLsMacrotest TIDY.au3"

Tidy AutoIt3 v2.3.0.16   Copyright © Jos van der Zande  August 17, 2013

"L:TOOLsMacrotest TIDY.au3"(4) : ### Tidy Warning -> #EndRegion statements without #Region.

+> Tidy AutoIt3 finished. Original copied to:"L:TOOLsMacroBackUptest TIDY_old8.au3"

>Exit code: 0    Time: 1.223

 

 

I think it would be better that:

#region testing1
#endregion testing1

#endregion testing bad endregion
#region-testing2
#endregion-testing2

and console

 

>"C:Program Files (x86)AutoIt3SciTEtidytidy.exe" "L:TOOLsMacrotest TIDY.au3"

Tidy AutoIt3 v2.3.0.16   Copyright © Jos van der Zande  August 17, 2013

"L:TOOLsMacrotest TIDY.au3"(4) : ### Tidy Warning -> #EndRegion statements without #Region named:  testing bad endregion

+> Tidy AutoIt3 finished and has no updates to make!

>Exit code: 0    Time: 0.084

 

I think maybe I want to keep this string in my script "testing bad endregion" to be able to better diagnose the problem.

What You think about that ?

Edit:

I change second console output to that:

+> Tidy AutoIt3 finished and has no updates to make!

Edited August 17, 2013 by mlipok

[mLipok]

I check several other combinations, I even checked the Folding function of "SciTE".

It's works ok.

[Jos]

The current Beta Tidy v 2.3.0.17 retains that #EndRegion description for the one with the warning.

Cheers,

Jos

[mLipok]

Now TIDY is even better;)

 

ps.

Sorry for the delay. Was devoted to family life.