ElseIf with OR comparison executing incorrectly

[Tripredacus]

I just had to fix a problem where I did a comparison on a variable using OR in an ElseIf statement, and it would fail to match (expected) but still execute anyways. Here is a generic example:

If $value = "Name1" Then
; do Name1 stuff
ElseIf $value = "Name2" OR "Name5" Then
; do Name25 stuff
ElseIf $value = "Name3" Then
; do Name3 stuff
ElseIf $value = "Name4" Then
; do Name4 stuff
Else
; show error
EndIf

Now, SyntaxCheckProd did not show any validation issues but in practice this code would fail in this condition. If $value matched Name3 or Name4 values, it would execute the "Name25" code even though it should have been skipped. Any times when Name1, Name2 or Name5 matched, then the code would execute properly. I have not tested where Name4 would match. I "fixed" this by putting "Name5" code into its own ElseIf statement, but it makes me wonder why this ended up happening.

And yes, I should probable switch over to using Switch/Case instead but I am just curious.

Edited April 17, 2013 by Tripredacus

[guinness]

This is a good example of when to use a Switch...EndSwitch statement.

Edit: Saw your last comment.

Edited April 17, 2013 by guinness

[BrewManNH]

Your mistake was that it should have been written like this:

ElseIf $value = "Name2" OR $value = "Name5" Then

The way you wrote it meant that it was comparing $value to the string "Name2" OR comparing the string "Name5" to a boolean value of true or false. Because "Name5" isn't an empty string, it is evaluated as True.

Edited April 17, 2013 by BrewManNH

[Jos]

Either way... the OR logic is wrong.

Should be:

ElseIf $value = "Name2" OR $value = "Name5" Then

Jos

edit: like BrewManNH said.

Edited April 17, 2013 by Jos

[Tripredacus]

Thanks, it makes a lot of sense to me. If I have to modify this again to add support for more variables, I'll take the time to change it to switch.