Report Help File Issues Here

[guinness]

Guinness, I've committed it for the standard functions (r7640), feel free to undo it if you want.

I'm going to have a look at the UDF functions, and see if there is an easier way. I suspect the only way to really know is to check whether control ids are allowed is by looking at the function body for "If IsHWnd($hWnd) Then".

It's how I did it. Though if I did my job right they should say "Control ID/Handle to the control" throughout.

What do you think about mentioning the Default keyword too, as this is preferable I would say over -1.

[Mat]

I would be tempted to add Global Const $GUI_LASTCTRL = -1, but by that point you might as well be using the control id most likely stored in a variable.

If someone who was new to AutoIt read: GUICtrlSetBkColor(Default, ...) they would probably think we were setting the default control background colour, which is not the case.

It may be worth looking at removing -1 from any examples, and not telling people about that feature. It might be better that way.

[guinness]

If someone who was new to AutoIt read: GUICtrlSetBkColor(Default, ...) they would probably think we were setting the default control background colour, which is not the case.

But then -1 could look confusing as well, it could appear you're setting the left position of the control, it depends how the new user looks at it I suppose.

It may be worth looking at removing -1 from any examples, and not telling people about that feature. It might be better that way.

I hinted at this when BrewManNH brought it up.

[BrewManNH]

I would be tempted to add Global Const $GUI_LASTCTRL = -1, but by that point you might as well be using the control id most likely stored in a variable.

Bad idea in my opinion, for the reason you stated.

If someone who was new to AutoIt read: GUICtrlSetBkColor(Default, ...) they would probably think we were setting the default control background colour, which is not the case.

As I said earlier, I would think this would confuse far too many new users as to what the default keyword was referring to, it can be mentioned in the help file that it can be used, but I wouldn't make the examples using it.

It may be worth looking at removing -1 from any examples, and not telling people about that feature. It might be better that way.

I disagree with that, it's an extremely helpful feature (that you can use it), and I don't see the rationale behind hiding it. Why would you not want people to know it's possible? And why would you want to remove it from the examples?

[guinness]

I would be tempted to add Global Const $GUI_LASTCTRL = -1, but by that point you might as well be using the control id most likely stored in a variable.

Not to be pessimistic, but people barely use the constants that are already provided in the UDFs. -_0

[BrewManNH]

Not to be pessimistic, but people barely use the constants that are already provided in the UDFs. -_0

Mostly, I'm guessing, it's because they're not documented anywhere what they are, or at least they weren't previously

[guinness]

-3 is documented.

[Mat]

I disagree with that, it's an extremely helpful feature (that you can use it), and I don't see the rationale behind hiding it. Why would you not want people to know it's possible? And why would you want to remove it from the examples?

It's useful, but that doesn't necessarily make it correct. Functions like Adlib don't guarantee your script is run line by line like you expect, and even if it did it's all too easy to add lines that make a difference without realizing. I use it all the time, but it really isn't good programming practice to refer to something so vaguely.

-3 is not documented anywhere as far as I can see.

[BrewManNH]

It doesn't make it incorrect either.

The language allows it, your personal preference and guinness', doesn't mean it shouldn't be mentioned. That would be like not mentioning OnEvent mode because someone prefers message loop mode. The language allows both, so don't bring personal biases into the documentation.

[Mat]

It doesn't make it incorrect either.

The language allows it, your personal preference and guinness', doesn't mean it shouldn't be mentioned. That would be like not mentioning OnEvent mode because someone prefers message loop mode. The language allows both, so don't bring personal biases into the documentation.

It's not personal bias, as said, I use -1 pretty much all the time.

You are saying "Set the last created controls font to this." when you meant "Set this particular controls font to this.". Say what you mean.

[BrewManNH]

It's not personal bias, as said, I use -1 pretty much all the time.

You are saying "Set the last created controls font to this." when you meant "Set this particular controls font to this.". Say what you mean.

But you ARE saying set the last control's font, and set this particular controls font, they mean the same thing when you use -1.

Here's a good example of that.

#include <GUIConstantsEx.au3>
Opt("GUIOnEventmode", 1)
GUICreate("Test")
GUISetBkColor(0xC049ED)
GUISetOnEvent($GUI_EVENT_CLOSE, "_Exit")
GUICtrlCreateLabel("This is just a label, there's nothing in this script that will reference this label ever." & @CRLF & "Do you think I should have to create a variable to hold" & _
        " the control ID just so I" & @CRLF & "can set the font and its color?", 10, 10, 300, 200)
GUICtrlSetBkColor(-1, 0xFFFF00)
GUICtrlSetColor(-1, 0x0000FF)
GUICtrlSetFont(-1, 12, 400)
GUISetState()
While 1
    Sleep(10)
WEnd
Func _exit()
    Exit
EndFunc   ;==>_exit

Now I could have created a useless variable just to hold the control ID for the label in this script, but other than setting the parameters of the label, I'm never going to reference it again. If you hide the fact that -1 can be used in place of a throw away variable, by not mentioning it in the help file, then you're doing a disservice to the community.

[Mat]

But you ARE saying set the last control's font, and set this particular controls font, they mean the same thing when you use -1.

No they don't, they usually *achieve* the same thing, but they never mean the same thing. You are making the assumption that the last control is the one you want. There is never a guarantee of that.

Of course I code exactly like you, -1 was added to all the standard function docs 3 hours ago by me as well. I'm just trying to show that using -1 is not 100% correct.

[BrewManNH]

No they don't, they usually *achieve* the same thing, but they never mean the same thing.

If you I use -1 I'm telling AutoIt to set the font on the last control created. If I reference it with -1 or its control ID, the result is the same thing. We're splitting hairs on a bald guy from what I'm seeing.

You are making the assumption that the last control is the one you want. There is never a guarantee of that.

If I write the script, I am guaranteed that the last control is the one I want, or I suck at being a coder.

Of course I code exactly like you, -1 was added to all the standard function docs 3 hours ago by me as well. I'm just trying to show that using -1 is not 100% correct.

If you can show me where/how it's not 100% correct, without going to extremes, then I might agree with you.

[guinness]

I was referring to GUI_EVENT_CLOSE being documented but people still using the value.

Edited February 13, 2013 by guinness

[Mat]

If I write the script, I am guaranteed that the last control is the one I want, or I suck at being a coder.

Any function like Adlib, GUIRegisterMsg etc can execute code at any time. What if you create a control in response to a WM_ message?

[BrewManNH]

Any function like Adlib, GUIRegisterMsg etc can execute code at any time. What if you create a control in response to a WM_ message?

My script would have to deal with that. I've never created controls based on something like this going on, but if I did, I would make sure I'm accessing the correct control, otherwise I am not coding it correctly. That's where debugging comes in.

[AZJIO]

_GUICtrlAVI_Show

State of the AVI, can be the following values: ???

GUICreate("(Internal) AVI Play", 350, 200)

$hGUI = GUICreate("(External) AVI Play", 350, 200)

_GUICtrlAVI_Open, _GUICtrlAVI_OpenEx

; Play the sample AutoIt AVI

_GUICtrlAVI_Open($hAVI, $sFile)

Edited February 16, 2013 by AZJIO

[JohnOne]

Should all the IE examples include an _IEQuit() in them?

[guinness]

Should all the IE examples include an _IEQuit() in them?

Maybe? I don't use the IE functions so would need to do some research.

[JohnOne]

A lot of them create an instance of IE you see, but they are left open after example ends.