RunWait not actually waiting?

[Spatnonkl]

Hello,

my script uses a custom URL. I want my program to auto-register it, if it is not registered yet.

This needs admin rights, so i chose to build a seperate executable which requires admin. So, the main script doesn't need admin rights on every launch.

Func checkHandlerReg()
   $prot = StringTrimRight($protocolString,3)
   $reg = RegRead("HKEY_CLASSES_ROOT"&$prot&"shellopencommand","")
   $handlerPath = $rootDir&"binURL_handler.exe"
   If Not StringInStr($reg,$handlerPath) Then
      RunWait($rootDir&"binregHandler.exe")
   EndIf
   Sleep(100)
   $reg = RegRead("HKEY_CLASSES_ROOT"&$prot&"shellopencommand","")
   If Not StringInStr($reg,$handlerPath) Then
      MsgBox(4096,$PRODUCTNAME,"Error: Could not register URL-Handler!")
      Exit
   EndIf
EndFunc

My problem:

You might have noticed the Sleep command. If i omit it, the following RegRead returns an empty String and my error MsgBox appears.

The RegWrite which regHandler.exe executes, works every time, The following RegRead is executed too early.

If i replace the RunWait with:

#RequireAdmin
RegWrite("HKEY_CLASSES_ROOT"&$prot&"shellopencommand","","REG_SZ",""""&$rootDir&"binURL_handler.exe"" ""%1""")

Then omitting Sleep() works flawlessly.

Any idea?

Edited December 6, 2012 by Spatnonkl

[Spatnonkl]

*bump*

[ripdad]

I hope I understand what your question is -- if not let me know.

You are asking why do I need a Sleep in my script one way and not the other?

Windows always has a "delay write".

This could be anywhere from 10ms to 8000ms depending on interaction between programs and certain conditions.

I see nothing wrong with a Sleep where you have it and where it's needed.

[jchd]

I doubt that reading the Windows cache right after a write would give a distinct result from what was writen.

Another possibility is that the launched program actually invokes another executable (without waiting for completion).

Edited December 9, 2012 by jchd

[Spatnonkl]

Thanks for your answers. You got my question right.

The File "regHandler.exe" is also a compiled AutoIT Script.

This is the source code:

#RequireAdmin

#include "../lib/globalLib.au3"

Global $rootDir = StringTrimRight(@ScriptDir,4)

$prot = StringTrimRight($protocolString,3)
RegWrite("HKEY_CLASSES_ROOT"&$prot,"","REG_SZ","URL:"&$prot&" Protocol")
RegWrite("HKEY_CLASSES_ROOT"&$prot,"URL Protocol","REG_SZ","")
RegWrite("HKEY_CLASSES_ROOT"&$prot&"shellopencommand","","REG_SZ",""""&$rootDir&"binURL_handler.exe"" ""%1""")

The problem is that i need to check if regHandler was executed correctly. I guess i could let regHandler return an exit-code?

[ripdad]

For this instance...I see nothing wrong with using ClipPut($ExitCode) and retrieving it with ClipGet().

There are other ways. Someone else might have a better solution.

[jchd]

Exit($returnCode) would do that.

Edited December 10, 2012 by jchd

[ripdad]

I had forgotten that could be done with Exit. Thats definitely the way to go. Thanks jchd.

[Spatnonkl]

Okay. Now things get really weird.

regHandler should return 0 if any RegWrite fails and 1 if all RegWrite succeed.

Problem: checkHandlerReg() continues before UAC prompt is answered. So RunWait does not wait AGAIN. ExitCode is always 0.

#RequireAdmin seems to launch a new process.

http://www.autoitscript.com/autoit3/docs/keywords/RequireAdmin.htm

So regHandler is launched once without admin privileges, returns und RunWait returns too.

After that i answer the UAC prompt and a new process of regHandler is created with admin rights.

So, what i can do to wait for the right process?

regHandler.au3 Code:

#RequireAdmin

#include "../lib/globalLib.au3"

Global $rootDir = StringTrimRight(@ScriptDir,4)

$prot = StringTrimRight($protocolString,3)
$retCode = 1
$retCode = BitAND($retCode,RegWrite("HKEY_CLASSES_ROOT"&$prot,"","REG_SZ","URL:"&$prot&" Protocol"))
$retCode = BitAND($retCode,RegWrite("HKEY_CLASSES_ROOT"&$prot,"URL Protocol","REG_SZ",""))
$retCode = BitAND($retCode,RegWrite("HKEY_CLASSES_ROOT"&$prot&"shellopencommand","","REG_SZ",""""&$rootDir&"binURL_handler.exe"" ""%1"""))
Exit $retCode

Func checkHandlerReg()
  $prot = StringTrimRight($protocolString,3)
  $reg = RegRead("HKEY_CLASSES_ROOT"&$prot&"shellopencommand","")
  $handlerPath = $rootDir&"binURL_handler.exe"
  If Not StringInStr($reg,$handlerPath) Then
    $returnID = RunWait($rootDir&"binregHandler.exe")
    If $returnID<>1 Then
      MsgBox(4096,$PRODUCTNAME,"Error: Could not register URL-Handler!")
      Exit
    EndIf
  EndIf
EndFunc

Edited December 11, 2012 by Spatnonkl

[BrewManNH]

Have you tried running it with RunAsWait? Because, as you said, using #RequireAdmin will close the first run, then open a new run and ask for Admin privileges. You can see this if you run it in SciTE using ConsoleWrites in a script, you won't see any of the writes because the first process has already closed.

[Jos]

Try compiling the reghandler with:

#AutoIt3Wrapper_Res_requestedExecutionLevel=requireAdministrator

Requires the full version of SciTE4AutoIt3 installed.

[Spatnonkl]

@BrewManHH:

I suppose you suggest running as user named "Administrator"? But this is not the same as using admin privileges. I want to run everything as the initial user.

@Jos:

Instead of #RequireAdmin or additional?

I use a make.bat which invokes "AutoIt3aut2exeaut2exe.exe"

Can't use that one?

//edit:

If I compile regHandler with Scite and the rest with aut2exe, the compiled regHandler.exe icon gets a little UAC (sub-)icon. Seems right. But now RunWait does not run regHandler.exe anymore (immediatly returns 0).

Edited December 11, 2012 by Spatnonkl

[Jos]

You indeed still need to run AutoIt3Wrapper. Next version of aut2exe will likely support all these PE settings.

Are you running your base script also as admin with atleast #RequireAdmin?

Jos

[Spatnonkl]

Changed my make.bat to use AutoIt3Wrapper.exe

RunWait still can't launch regHandler.exe

Are you running your base script also as admin with atleast #RequireAdmin?

No. Because that's exactly what i'm trying to avoid. Refer to first post.

Edited December 11, 2012 by Spatnonkl

[Jos]

No. Because that's exactly what i'm trying to avoid. Refer to first post.

You could use ShellExecuteWait() but will get the UAC prompt.

Jos

[Spatnonkl]

This seems to work for me. Thanks!

Why is #RequireAdmin not enough for the Compiler to know?

[BrewManNH]

According to MSDN if you're a standard user and the program you're trying to launch has requireAdministrator in its manifest, you can't run it unless you have certain settings set correctly, and even then might not be able to run the program at all.

[Jos]

This seems to work for me. Thanks!

Why is #RequireAdmin not enough for the Compiler to know?

You mean for your compiled reghandler.exe ? AutoIt3 will internally re-shell the script thus creating a new process.

[Spatnonkl]

Okay, thanks for the explanation. I would suggest to explain this behaviour of #RequireAdmin in AutoIT Help File.

[Jos]

Okay, thanks for the explanation. I would suggest to explain this behaviour of #RequireAdmin in AutoIT Help File.

Doesn't it already by stating?:

As this function launch a new process, some functions as Consolewrite() cannot be captured (Scite will not display anything).

Jos