stephend Posted December 5, 2012 Share Posted December 5, 2012 Hi, I'm trying to write a script to move 80 PCs from one container to another, they are all in the same group. I've been using ad.au3 which is great but I think I've got the syntax for the target wrong. I've tried with and without escaping the commas. I got the FQDN by looking at the AD in ADSIedit, edited for security #include<ad.au3> _AD_Open() if _AD_IsMemberOf("4096", "xxx004096" & "$") Then ;_AD_MoveObject("DC=ad,DC=xxx,DC=yy,DC=uk,OU=test",@ComputerName & "$") _AD_MoveObject("DC=ad\,DC=xxx\,DC=yy\,DC=uk\,OU=test",@ComputerName & "$") MsgBox(262144,"","here" & @tab & @error) Else MsgBox(262144,"",@error) Endif I can see that the PC is a member of the group but I always get "here" and then error 1 - the target does not exist. Could someone please point me in the right direction or provide an example. Many thanks, Stephen Link to comment Share on other sites More sharing options...
BrewManNH Posted December 5, 2012 Share Posted December 5, 2012 Wouldn't it be easier to just move them manually? Unless you're doing this a lot of times, moving a computer account from one OU to another takes approximately 2 seconds. If I posted any code, assume that code was written using the latest release version unless stated otherwise. Also, if it doesn't work on XP I can't help with that because I don't have access to XP, and I'm not going to.Give a programmer the correct code and he can do his work for a day. Teach a programmer to debug and he can do his work for a lifetime - by Chirag GudeHow to ask questions the smart way! I hereby grant any person the right to use any code I post, that I am the original author of, on the autoitscript.com forums, unless I've specifically stated otherwise in the code or the thread post. If you do use my code all I ask, as a courtesy, is to make note of where you got it from. Back up and restore Windows user files _Array.au3 - Modified array functions that include support for 2D arrays. - ColorChooser - An add-on for SciTE that pops up a color dialog so you can select and paste a color code into a script. - Customizable Splashscreen GUI w/Progress Bar - Create a custom "splash screen" GUI with a progress bar and custom label. - _FileGetProperty - Retrieve the properties of a file - SciTE Toolbar - A toolbar demo for use with the SciTE editor - GUIRegisterMsg demo - Demo script to show how to use the Windows messages to interact with controls and your GUI. - Latin Square password generator Link to comment Share on other sites More sharing options...
water Posted December 5, 2012 Share Posted December 5, 2012 (edited) You don't have to escape the OU. This should work: _AD_MoveObject("OU=test,DC=ad,DC=xxx,DC=yy,DC=uk",@ComputerName & "$")I assume that the OU you posted is wrong. It should start with OU=... BTW: Error 1 means: OU does not exist Edited December 5, 2012 by water stephend 1 My UDFs and Tutorials: Spoiler UDFs: Active Directory (NEW 2024-07-28 - Version 1.6.3.0) - Download - General Help & Support - Example Scripts - Wiki ExcelChart (2017-07-21 - Version 0.4.0.1) - Download - General Help & Support - Example Scripts OutlookEX (2021-11-16 - Version 1.7.0.0) - Download - General Help & Support - Example Scripts - Wiki OutlookEX_GUI (2021-04-13 - Version 1.4.0.0) - Download Outlook Tools (2019-07-22 - Version 0.6.0.0) - Download - General Help & Support - Wiki PowerPoint (2021-08-31 - Version 1.5.0.0) - Download - General Help & Support - Example Scripts - Wiki Task Scheduler (2022-07-28 - Version 1.6.0.1) - Download - General Help & Support - Wiki Standard UDFs: Excel - Example Scripts - Wiki Word - Wiki Tutorials: ADO - Wiki WebDriver - Wiki Link to comment Share on other sites More sharing options...
stephend Posted December 6, 2012 Author Share Posted December 6, 2012 Thanks water, putting the OU at the beginning of the line sorted the problem. BrewmanNH, there are 80 PCs with non-contiguous names (out of a total of 300+ PCs in an OU) that need to be moved in and out of the "exam" container on a regular basis, perhaps I'm missing something (I often do :-) ) as I've not found any way to do this easily from the GUI. When I look at the list of names of PCs in a group I don't see any option to move them. Thanks to you both for replying, Stephen Link to comment Share on other sites More sharing options...
water Posted December 6, 2012 Share Posted December 6, 2012 Glad the problem could be solved My UDFs and Tutorials: Spoiler UDFs: Active Directory (NEW 2024-07-28 - Version 1.6.3.0) - Download - General Help & Support - Example Scripts - Wiki ExcelChart (2017-07-21 - Version 0.4.0.1) - Download - General Help & Support - Example Scripts OutlookEX (2021-11-16 - Version 1.7.0.0) - Download - General Help & Support - Example Scripts - Wiki OutlookEX_GUI (2021-04-13 - Version 1.4.0.0) - Download Outlook Tools (2019-07-22 - Version 0.6.0.0) - Download - General Help & Support - Wiki PowerPoint (2021-08-31 - Version 1.5.0.0) - Download - General Help & Support - Example Scripts - Wiki Task Scheduler (2022-07-28 - Version 1.6.0.1) - Download - General Help & Support - Wiki Standard UDFs: Excel - Example Scripts - Wiki Word - Wiki Tutorials: ADO - Wiki WebDriver - Wiki Link to comment Share on other sites More sharing options...
BrewManNH Posted December 6, 2012 Share Posted December 6, 2012 Thanks water, putting the OU at the beginning of the line sorted the problem. BrewmanNH, there are 80 PCs with non-contiguous names (out of a total of 300+ PCs in an OU) that need to be moved in and out of the "exam" container on a regular basis, perhaps I'm missing something (I often do :-) ) as I've not found any way to do this easily from the GUI. When I look at the list of names of PCs in a group I don't see any option to move them.Thanks to you both for replying,StephenIn the AD screen, you highlight the ones you're moving, then drag them to the OU you want them to be moved to. If you're moving everything out of one OU to another OU it's as easy as highlight the first one, SHIFT-Click the last one, drag them to the correct OU. You may get a popup asking you f it's ok to move them if it's the first time you're doing it and havent' clicked the ck box in the dialog.If they're not all being moved, and they're not easily sorted, it isnt' as easy. If I posted any code, assume that code was written using the latest release version unless stated otherwise. Also, if it doesn't work on XP I can't help with that because I don't have access to XP, and I'm not going to.Give a programmer the correct code and he can do his work for a day. Teach a programmer to debug and he can do his work for a lifetime - by Chirag GudeHow to ask questions the smart way! I hereby grant any person the right to use any code I post, that I am the original author of, on the autoitscript.com forums, unless I've specifically stated otherwise in the code or the thread post. If you do use my code all I ask, as a courtesy, is to make note of where you got it from. Back up and restore Windows user files _Array.au3 - Modified array functions that include support for 2D arrays. - ColorChooser - An add-on for SciTE that pops up a color dialog so you can select and paste a color code into a script. - Customizable Splashscreen GUI w/Progress Bar - Create a custom "splash screen" GUI with a progress bar and custom label. - _FileGetProperty - Retrieve the properties of a file - SciTE Toolbar - A toolbar demo for use with the SciTE editor - GUIRegisterMsg demo - Demo script to show how to use the Windows messages to interact with controls and your GUI. - Latin Square password generator Link to comment Share on other sites More sharing options...
Recommended Posts
Create an account or sign in to comment
You need to be a member in order to leave a comment
Create an account
Sign up for a new account in our community. It's easy!
Register a new accountSign in
Already have an account? Sign in here.
Sign In Now