Loop through an array

[tes5884]

The script is looping through a csv file with old pc names. It's then supposed to rename the pc's base on the service tag.

It seems to broken at the section where it loops through the array.

What am I doing wrong?

Thanks!!

#include <Constants.au3>
#include <Array.au3>
#include <CSV.au3>


$pid = Run("wmic bios get serialnumber", "", "", $STDERR_CHILD + $STDOUT_CHILD)
ProcessWaitClose($pid)
$std = StdoutRead($pid)
$tag = StringRight(StringStripWS($std, 8), 7)


Local $dpt = "DPT"
Local $nPcName = $dpt & "-" & $tag


$oPcName = _ParseCSV("test.csv")

For $i = 0 To UBound($oPcName)
Run(@ComSpec & " /k netdom renamecomputer " & $oPcName[$i] & " /NewName:" & $nPcName & " /Force")
Next

[BrewManNH]

I'm assuming when you say broken it means you're getting an array subscript error? If so, use For $i = 0 to Ubound($oPCName) - 1

[tes5884]

Tried that, still got error below.

ServiceTag.au3 (19) : ==> Array variable has incorrect number of subscripts or subscript dimension range exceeded.:
Run(@ComSpec & " /k netdom renamecomputer " & $oPcName[$i] & " /NewName:" & $nPcName & " /Force")
Run(@ComSpec & " /k netdom renamecomputer " & ^ ERROR

The CSV file contains the following values;

tzvi-pc
test-pc

Thanks!

[jdelaney]

Let me try this post again...

Do an _arraydisplay after the following line

$oPcName = _ParseCSV("test.csv")

send us back the output

[tes5884]

the array seems to be fine, see attached.

Thanks!

[Jos]

change this line:

For $i = 0 To UBound($oPcName) -1

[tes5884]

change this line:

For $i = 0 To UBound($oPcName) -1

Already did that per BrewManNH

[Jos]

Well,

With the provided info that should fix it since your array only has 0 & 1 so shown in the arraydisplay.

Post the latest version of your script with the arraydisplay before the ForNext loop so we can see what you are testing with.

Jos

[BrewManNH]

Add this after the line "For $i = 0 To UBound($oPcName) - 1"

ConsoleWrite("$i = " & $i & @CRLF)

Run your script from Scite and report the output from the console window at the bottom of the scite screen.

Edited October 24, 2012 by BrewManNH

[tes5884]

Add this after the line "For $i = 0 To UBound($oPcName) - 1"

ConsoleWrite("$i = " & $i & @CRLF)

Run your script from Scite and report the output from the console window at the bottom of the scite screen.

That worked!

$i = 0
$i = 1

Now why am I getting an error when I try to get the output of $oPcName[$i]

[Skruge]

You have a 2-dimensional array, so you have to reference the elements differently.

UBound($oPcName) returns 2 because the array is 2-dimensional. (Not the row count, as you were expecting)

UBound($oPcName,1) also returns 2 because you have two lines in the CSV file.

Try this:

For $i = 0 To UBound($oPcName,1) -1
Run(@ComSpec & " /k netdom renamecomputer " & $oPcName[$i][0] & " /NewName:" & $nPcName & " /Force")
Next

Edit: Missed the -1

Edited October 24, 2012 by Skruge

[tes5884]

This is the exact and entire script at this time.

#include <Constants.au3>
#include <Array.au3>
#include <CSV.au3>


$pid = Run("wmic bios get serialnumber", "", "", $STDERR_CHILD + $STDOUT_CHILD)
ProcessWaitClose($pid)
$std = StdoutRead($pid)
$tag = StringRight(StringStripWS($std, 8), 7)


Local $dpt = "DPT"
Local $nPcName = $dpt & "-" & $tag


$oPcName = _ParseCSV("test.csv")
_ArrayDisplay($oPcName)

For $i = 0 To UBound($oPcName) -1
ConsoleWrite("$i = " & $i & @CRLF)
Run(@ComSpec & " /k netdom renamecomputer " & $oPcName[$i] & " /NewName:" & $nPcName & " /Force")
Next

[tes5884]

@Skruge it worked! Thank you all for helping!

This is the working edition if anyone else has the same problem..

#include <Constants.au3>
#include <Array.au3>
#include <CSV.au3>


$pid = Run("wmic bios get serialnumber", "", "", $STDERR_CHILD + $STDOUT_CHILD)
ProcessWaitClose($pid)
$std = StdoutRead($pid)
$tag = StringRight(StringStripWS($std, 8), 7)


Local $dpt = "DPT"
Local $nPcName = $dpt & "-" & $tag


$oPcName = _ParseCSV("test.csv")
_ArrayDisplay($oPcName)

For $i = 0 To UBound($oPcName, 1)
ConsoleWrite("$i = " & $i & @CRLF)
Run(@ComSpec & " /k netdom renamecomputer " & $oPcName[$i][0] & " /NewName:" & $nPcName & " /Force")
Next

Edited October 24, 2012 by tes5884

[Mechaflash]

The wicked two-headed array strikes again...

[jdelaney]

figured as much (mutli dim array, that is)

Edited October 24, 2012 by jdelaney

[BrewManNH]

I missed the Col1 in the array display, good catch.

[Skruge]

This is the working edition if has the same problem..

I'm not sure from your phrasing if you're still having issues, but the code you posted is missing the -1 after UBound. (I edited my post but it looks like you got the original)

If you still need help, let us know.

Cheers!

[tes5884]

I'm not sure from your phrasing if you're still having issues, but the code you posted is missing the -1 after UBound. (I edited my post but it looks like you got the original)

If you still need help, let us know.

Cheers!

Fixed. It works perfectly thanks..

This is the working edition if anyone else has the same problem..